{"header":{"message":"Support hydra-build-products on binary cache stores","description":null,"timestamp":"2016-02-26T13:45:03Z","authors":[{"email":"eelco.dolstra@logicblox.com","name":"Eelco Dolstra"}]},"hash":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC","authors":[],"deps":{"hashes":[["BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC","Support hydra-build-products on binary cache stores"],["AA",null],["73YR46NJNYZQKHA3QDJCAZYAKC2CGEF5LIS44NOIPDZU6FX6BDPQC","hydra-queue-runner: Write directly to a binary cache"],["WHULPA6SJJVCXISPL3GAQIRIKQN2DTUSMWGP2ECITWYMLHOON3SQC","Handle failure with output"],["GS4BE6TB6GH2JUZJHDPHL6YG7J7YYESF3YOZJZ2CFABXUTO4VYPQC","Asynchronously compress build logs"],["24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC","Start of single-process hydra-queue-runner"],["T5BIOVJEMBIASP7EKQVV2N3VD6I56UXH6LCD5I33BDQEVHJAMGKQC","Add support for tracking custom metrics"],["DKJFD6JNNK5LJMRGQABMJZKMFZLGY3ADKJWF6J4BBHEUPY3NB67QC","Process Nix API changes"],["MHVIT4JYWUYD4UCGB2AHLXWLX6B5SYE22BREERNGANT7RGGDUFOAC","Split hydra-queue-runner.cc more"],["NAYQT2GTCJPBFRSK7CBFX655F2NGTBPICJSCYG2CSCQ5NRDHZG6QC","hydra-queue-runner: Use cmdBuildDerivation"],["ZK76B5ZZCEOJQUDOVKDZPE6IN2YIXQONFUIJ633OAXNC73OG3YSAC","Load the queue in order of global priority"],["NJJ7H64SZOX5EGACDCQAUQ7R6UEWD5IIC35A2MWFOOJV55DJYPHAC","Very basic multi-threaded queue runner"],["YHP5DSOOKAXAYHUDMYO6EKX2YAN7DLDQPJX5K52TCP7EXQVP6JAAC","Improve parsing of hydra-build-products"]],"deps":["73YR46NJNYZQKHA3QDJCAZYAKC2CGEF5LIS44NOIPDZU6FX6BDPQC"],"known":["24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC","NJJ7H64SZOX5EGACDCQAUQ7R6UEWD5IIC35A2MWFOOJV55DJYPHAC","WHULPA6SJJVCXISPL3GAQIRIKQN2DTUSMWGP2ECITWYMLHOON3SQC","GS4BE6TB6GH2JUZJHDPHL6YG7J7YYESF3YOZJZ2CFABXUTO4VYPQC","YHP5DSOOKAXAYHUDMYO6EKX2YAN7DLDQPJX5K52TCP7EXQVP6JAAC","NAYQT2GTCJPBFRSK7CBFX655F2NGTBPICJSCYG2CSCQ5NRDHZG6QC","MHVIT4JYWUYD4UCGB2AHLXWLX6B5SYE22BREERNGANT7RGGDUFOAC","T5BIOVJEMBIASP7EKQVV2N3VD6I56UXH6LCD5I33BDQEVHJAMGKQC","ZK76B5ZZCEOJQUDOVKDZPE6IN2YIXQONFUIJ633OAXNC73OG3YSAC","DKJFD6JNNK5LJMRGQABMJZKMFZLGY3ADKJWF6J4BBHEUPY3NB67QC"]},"hunks":[{"Edit":{"inode":{"change":3,"pos":441},"path":"src/hydra-queue-runner/build-result.cc","line":5,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":20}],"down_context":[{"change":3,"pos":531}],"flag":"BLOCK","start":0,"end":26,"inode":{"change":3,"pos":441}}},"contents":[{"Add":{"text":"#include \"fs-accessor.hh\"","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:25"}}]}},{"Edit":{"inode":{"change":3,"pos":441},"path":"src/hydra-queue-runner/build-result.cc","line":8,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":553},"to":{"change":3,"start":0,"end":402},"introduced_by":3}],"inode":{"change":3,"pos":441}}},"contents":[{"Del":{"text":"","pos":"T5BIOVJEMBIASP7EKQVV2N3VD6I56UXH6LCD5I33BDQEVHJAMGKQC:0"}},{"Del":{"text":"","pos":"T5BIOVJEMBIASP7EKQVV2N3VD6I56UXH6LCD5I33BDQEVHJAMGKQC:1"}},{"Del":{"text":"static std::tuple secureRead(Path fileName)","pos":"T5BIOVJEMBIASP7EKQVV2N3VD6I56UXH6LCD5I33BDQEVHJAMGKQC:59"}},{"Del":{"text":"{","pos":"T5BIOVJEMBIASP7EKQVV2N3VD6I56UXH6LCD5I33BDQEVHJAMGKQC:61"}},{"Del":{"text":" auto fail = std::make_tuple(false, \"\");","pos":"T5BIOVJEMBIASP7EKQVV2N3VD6I56UXH6LCD5I33BDQEVHJAMGKQC:105"}},{"Del":{"text":"","pos":"T5BIOVJEMBIASP7EKQVV2N3VD6I56UXH6LCD5I33BDQEVHJAMGKQC:106"}},{"Del":{"text":" if (!pathExists(fileName)) return fail;","pos":"T5BIOVJEMBIASP7EKQVV2N3VD6I56UXH6LCD5I33BDQEVHJAMGKQC:150"}},{"Del":{"text":"","pos":"T5BIOVJEMBIASP7EKQVV2N3VD6I56UXH6LCD5I33BDQEVHJAMGKQC:151"}},{"Del":{"text":" try {","pos":"T5BIOVJEMBIASP7EKQVV2N3VD6I56UXH6LCD5I33BDQEVHJAMGKQC:161"}},{"Del":{"text":" /* For security, resolve symlinks. */","pos":"T5BIOVJEMBIASP7EKQVV2N3VD6I56UXH6LCD5I33BDQEVHJAMGKQC:207"}},{"Del":{"text":" fileName = canonPath(fileName, true);","pos":"T5BIOVJEMBIASP7EKQVV2N3VD6I56UXH6LCD5I33BDQEVHJAMGKQC:253"}},{"Del":{"text":" if (!isInStore(fileName)) return fail;","pos":"T5BIOVJEMBIASP7EKQVV2N3VD6I56UXH6LCD5I33BDQEVHJAMGKQC:300"}},{"Del":{"text":" return std::make_tuple(true, readFile(fileName));","pos":"T5BIOVJEMBIASP7EKQVV2N3VD6I56UXH6LCD5I33BDQEVHJAMGKQC:358"}},{"Del":{"text":" } catch (Error & e) { return fail; }","pos":"T5BIOVJEMBIASP7EKQVV2N3VD6I56UXH6LCD5I33BDQEVHJAMGKQC:399"}},{"Del":{"text":"}","pos":"T5BIOVJEMBIASP7EKQVV2N3VD6I56UXH6LCD5I33BDQEVHJAMGKQC:401"}}]}},{"Replacement":{"inode":{"change":3,"pos":441},"path":"src/hydra-queue-runner/build-result.cc","line":10,"ins":{"up_context":[{"change":3,"pos":555}],"down_context":[{"change":3,"pos":606}],"flag":"BLOCK","start":27,"end":141,"inode":{"change":3,"pos":441}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":555},"to":{"change":3,"start":419,"end":493},"introduced_by":3}],"inode":{"change":3,"pos":441}},"ins_contents":[{"Add":{"text":"BuildOutput getBuildOutput(nix::ref store,","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:76"}},{"Add":{"text":" nix::ref accessor, const Derivation & drv)","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:140"}}],"del_contents":[{"Del":{"text":"BuildOutput getBuildOutput(nix::ref store, const Derivation & drv)","pos":"DKJFD6JNNK5LJMRGQABMJZKMFZLGY3ADKJWF6J4BBHEUPY3NB67QC:492"}}]}},{"Edit":{"inode":{"change":3,"pos":441},"path":"src/hydra-queue-runner/build-result.cc","line":31,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1146},"to":{"change":2,"start":1107,"end":1113},"introduced_by":2}],"inode":{"change":3,"pos":441}}},"contents":[{"Del":{"text":"#if 0","pos":"73YR46NJNYZQKHA3QDJCAZYAKC2CGEF5LIS44NOIPDZU6FX6BDPQC:1112"}}]}},{"Replacement":{"inode":{"change":3,"pos":441},"path":"src/hydra-queue-runner/build-result.cc","line":42,"ins":{"up_context":[{"change":3,"pos":58}],"down_context":[{"change":3,"pos":113}],"flag":"BLOCK","start":142,"end":248,"inode":{"change":3,"pos":441}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":58},"to":{"change":3,"start":58,"end":113},"introduced_by":3}],"inode":{"change":3,"pos":441}},"ins_contents":[{"Add":{"text":" if (accessor->stat(failedFile).type == FSAccessor::Type::tRegular)","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:216"}},{"Add":{"text":" res.failed = true;","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:247"}}],"del_contents":[{"Del":{"text":" if (pathExists(failedFile)) res.failed = true;","pos":"WHULPA6SJJVCXISPL3GAQIRIKQN2DTUSMWGP2ECITWYMLHOON3SQC:112"}}]}},{"Replacement":{"inode":{"change":3,"pos":441},"path":"src/hydra-queue-runner/build-result.cc","line":45,"ins":{"up_context":[{"change":3,"pos":114}],"down_context":[{"change":3,"pos":523}],"flag":"BLOCK","start":249,"end":422,"inode":{"change":3,"pos":441}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":114},"to":{"change":3,"start":403,"end":523},"introduced_by":3}],"inode":{"change":3,"pos":441}},"ins_contents":[{"Add":{"text":" Path productsFile = output + \"/nix-support/hydra-build-products\";","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:322"}},{"Add":{"text":" if (accessor->stat(productsFile).type != FSAccessor::Type::tRegular)","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:399"}},{"Add":{"text":" continue;","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:421"}}],"del_contents":[{"Del":{"text":" auto file = secureRead(output + \"/nix-support/hydra-build-products\");","pos":"T5BIOVJEMBIASP7EKQVV2N3VD6I56UXH6LCD5I33BDQEVHJAMGKQC:480"}},{"Del":{"text":" if (!std::get<0>(file)) continue;","pos":"T5BIOVJEMBIASP7EKQVV2N3VD6I56UXH6LCD5I33BDQEVHJAMGKQC:522"}}]}},{"Replacement":{"inode":{"change":3,"pos":441},"path":"src/hydra-queue-runner/build-result.cc","line":51,"ins":{"up_context":[{"change":3,"pos":1339}],"down_context":[{"change":3,"pos":640}],"flag":"BLOCK","start":423,"end":517,"inode":{"change":3,"pos":441}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1339},"to":{"change":3,"start":525,"end":604},"introduced_by":3}],"inode":{"change":3,"pos":441}},"ins_contents":[{"Add":{"text":" for (auto & line : tokenizeString(accessor->readFile(productsFile), \"\\n\")) {","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:516"}}],"del_contents":[{"Del":{"text":" for (auto & line : tokenizeString(std::get<1>(file), \"\\n\")) {","pos":"T5BIOVJEMBIASP7EKQVV2N3VD6I56UXH6LCD5I33BDQEVHJAMGKQC:603"}}]}},{"Edit":{"inode":{"change":3,"pos":441},"path":"src/hydra-queue-runner/build-result.cc","line":64,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":629}],"down_context":[{"change":3,"pos":2316}],"flag":"BLOCK","start":518,"end":654,"inode":{"change":3,"pos":441}}},"contents":[{"Add":{"text":" // FIXME: should we disallow products referring to other","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:586"}},{"Add":{"text":" // store paths, or that are outside the input closure?","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:653"}}]}},{"Replacement":{"inode":{"change":3,"pos":441},"path":"src/hydra-queue-runner/build-result.cc","line":67,"ins":{"up_context":[{"change":3,"pos":2388}],"down_context":[{"change":3,"pos":2527}],"flag":"BLOCK","start":655,"end":759,"inode":{"change":3,"pos":441}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":2388},"to":{"change":3,"start":976,"end":1102},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":1102},"to":{"change":3,"start":2446,"end":2527},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":2446},"to":{"change":3,"start":2446,"end":2527},"introduced_by":3}],"inode":{"change":3,"pos":441}},"ins_contents":[{"Add":{"text":" product.path = canonPath(product.path);","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:706"}},{"Add":{"text":" if (!isInStore(product.path)) continue;","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:758"}}],"del_contents":[{"Del":{"text":" try {","pos":"YHP5DSOOKAXAYHUDMYO6EKX2YAN7DLDQPJX5K52TCP7EXQVP6JAAC:993"}},{"Del":{"text":" product.path = canonPath(product.path, true);","pos":"YHP5DSOOKAXAYHUDMYO6EKX2YAN7DLDQPJX5K52TCP7EXQVP6JAAC:1055"}},{"Del":{"text":" } catch (Error & e) { continue; }","pos":"YHP5DSOOKAXAYHUDMYO6EKX2YAN7DLDQPJX5K52TCP7EXQVP6JAAC:1101"}},{"Del":{"text":" if (!isInStore(product.path) || !pathExists(product.path)) continue;","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:2526"}}]}},{"Replacement":{"inode":{"change":3,"pos":441},"path":"src/hydra-queue-runner/build-result.cc","line":70,"ins":{"up_context":[{"change":3,"pos":2528}],"down_context":[{"change":3,"pos":2628}],"flag":"BLOCK","start":760,"end":877,"inode":{"change":3,"pos":441}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":2528},"to":{"change":3,"start":2528,"end":2628},"introduced_by":3}],"inode":{"change":3,"pos":441}},"ins_contents":[{"Add":{"text":" auto st = accessor->stat(product.path);","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:811"}},{"Add":{"text":" if (st.type == FSAccessor::Type::tMissing) continue;","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:876"}}],"del_contents":[{"Del":{"text":" /* FIXME: check that the path is in the input closure","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:2594"}},{"Del":{"text":" of the build? */","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:2627"}}]}},{"Edit":{"inode":{"change":3,"pos":441},"path":"src/hydra-queue-runner/build-result.cc","line":74,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":2712},"to":{"change":3,"start":2712,"end":2876},"introduced_by":3}],"inode":{"change":3,"pos":441}}},"contents":[{"Del":{"text":"","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:2712"}},{"Del":{"text":" struct stat st;","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:2740"}},{"Del":{"text":" if (stat(product.path.c_str(), &st))","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:2789"}},{"Del":{"text":" throw SysError(format(\"getting status of ‘%1%’\") % product.path);","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:2875"}}]}},{"Replacement":{"inode":{"change":3,"pos":441},"path":"src/hydra-queue-runner/build-result.cc","line":75,"ins":{"up_context":[{"change":3,"pos":2877}],"down_context":[{"change":3,"pos":2916}],"flag":"BLOCK","start":878,"end":935,"inode":{"change":3,"pos":441}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":2877},"to":{"change":3,"start":2877,"end":2916},"introduced_by":3}],"inode":{"change":3,"pos":441}},"ins_contents":[{"Add":{"text":" if (st.type == FSAccessor::Type::tRegular) {","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:934"}}],"del_contents":[{"Del":{"text":" if (S_ISREG(st.st_mode)) {","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:2915"}}]}},{"Replacement":{"inode":{"change":3,"pos":441},"path":"src/hydra-queue-runner/build-result.cc","line":77,"ins":{"up_context":[{"change":3,"pos":2958}],"down_context":[{"change":3,"pos":3143}],"flag":"BLOCK","start":936,"end":1184,"inode":{"change":3,"pos":441}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":2958},"to":{"change":3,"start":2958,"end":3143},"introduced_by":3}],"inode":{"change":3,"pos":441}},"ins_contents":[{"Add":{"text":" product.fileSize = st.fileSize;","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:983"}},{"Add":{"text":" auto contents = accessor->readFile(product.path);","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:1049"}},{"Add":{"text":" product.sha1hash = hashString(htSHA1, contents);","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:1114"}},{"Add":{"text":" product.sha256hash = hashString(htSHA256, contents);","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:1183"}}],"del_contents":[{"Del":{"text":" product.fileSize = st.st_size;","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:3004"}},{"Del":{"text":" product.sha1hash = hashFile(htSHA1, product.path);","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:3071"}},{"Del":{"text":" product.sha256hash = hashFile(htSHA256, product.path);","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:3142"}}]}},{"Edit":{"inode":{"change":3,"pos":441},"path":"src/hydra-queue-runner/build-result.cc","line":86,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3219},"to":{"change":2,"start":1114,"end":1121},"introduced_by":2}],"inode":{"change":3,"pos":441}}},"contents":[{"Del":{"text":"#endif","pos":"73YR46NJNYZQKHA3QDJCAZYAKC2CGEF5LIS44NOIPDZU6FX6BDPQC:1120"}}]}},{"Replacement":{"inode":{"change":3,"pos":441},"path":"src/hydra-queue-runner/build-result.cc","line":97,"ins":{"up_context":[{"change":3,"pos":3665}],"down_context":[{"change":3,"pos":3865}],"flag":"BLOCK","start":1185,"end":1432,"inode":{"change":3,"pos":441}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3665},"to":{"change":2,"start":1122,"end":1128},"introduced_by":2},{"previous":"","flag":"DELETED","from":{"change":2,"pos":1128},"to":{"change":3,"start":3665,"end":3865},"introduced_by":2},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3665},"to":{"change":3,"start":3665,"end":3865},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3865},"to":{"change":2,"start":1129,"end":1136},"introduced_by":2}],"inode":{"change":3,"pos":441}},"ins_contents":[{"Add":{"text":" auto st = accessor->stat(product.path);","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:1236"}},{"Add":{"text":" if (st.type == FSAccessor::Type::tMissing)","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:1291"}},{"Add":{"text":" throw Error(format(\"getting status of ‘%1%’\") % product.path);","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:1374"}},{"Add":{"text":" if (st.type == FSAccessor::Type::tDirectory)","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:1431"}}],"del_contents":[{"Del":{"text":"#if 0","pos":"73YR46NJNYZQKHA3QDJCAZYAKC2CGEF5LIS44NOIPDZU6FX6BDPQC:1127"}},{"Del":{"text":" struct stat st;","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:3692"}},{"Del":{"text":" if (stat(product.path.c_str(), &st))","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:3741"}},{"Del":{"text":" throw SysError(format(\"getting status of ‘%1%’\") % product.path);","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:3827"}},{"Del":{"text":" if (S_ISDIR(st.st_mode))","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:3864"}},{"Del":{"text":"#endif","pos":"73YR46NJNYZQKHA3QDJCAZYAKC2CGEF5LIS44NOIPDZU6FX6BDPQC:1135"}}]}},{"Edit":{"inode":{"change":3,"pos":441},"path":"src/hydra-queue-runner/build-result.cc","line":105,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3931},"to":{"change":2,"start":1137,"end":1143},"introduced_by":2}],"inode":{"change":3,"pos":441}}},"contents":[{"Del":{"text":"#if 0","pos":"73YR46NJNYZQKHA3QDJCAZYAKC2CGEF5LIS44NOIPDZU6FX6BDPQC:1142"}}]}},{"Replacement":{"inode":{"change":3,"pos":441},"path":"src/hydra-queue-runner/build-result.cc","line":108,"ins":{"up_context":[{"change":3,"pos":4104}],"down_context":[{"change":3,"pos":1103}],"flag":"BLOCK","start":1433,"end":1509,"inode":{"change":3,"pos":441}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4104},"to":{"change":3,"start":4104,"end":4142},"introduced_by":3}],"inode":{"change":3,"pos":441}},"ins_contents":[{"Add":{"text":" if (accessor->stat(p).type != FSAccessor::Type::tRegular) continue;","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:1508"}}],"del_contents":[{"Del":{"text":" if (!pathExists(p)) continue;","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:4141"}}]}},{"Replacement":{"inode":{"change":3,"pos":441},"path":"src/hydra-queue-runner/build-result.cc","line":110,"ins":{"up_context":[{"change":3,"pos":1117}],"down_context":[{"change":3,"pos":1166}],"flag":"BLOCK","start":1510,"end":1569,"inode":{"change":3,"pos":441}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1117},"to":{"change":3,"start":1117,"end":1166},"introduced_by":3}],"inode":{"change":3,"pos":441}},"ins_contents":[{"Add":{"text":" res.releaseName = trim(accessor->readFile(p));","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:1568"}}],"del_contents":[{"Del":{"text":" res.releaseName = trim(readFile(p));","pos":"YHP5DSOOKAXAYHUDMYO6EKX2YAN7DLDQPJX5K52TCP7EXQVP6JAAC:1165"}}]}},{"Replacement":{"inode":{"change":3,"pos":441},"path":"src/hydra-queue-runner/build-result.cc","line":117,"ins":{"up_context":[{"change":3,"pos":664}],"down_context":[{"change":3,"pos":814}],"flag":"BLOCK","start":1570,"end":1815,"inode":{"change":3,"pos":441}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":664},"to":{"change":3,"start":664,"end":814},"introduced_by":3}],"inode":{"change":3,"pos":441}},"ins_contents":[{"Add":{"text":" Path metricsFile = output + \"/nix-support/hydra-metrics\";","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:1635"}},{"Add":{"text":" if (accessor->stat(metricsFile).type != FSAccessor::Type::tRegular) continue;","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:1721"}},{"Add":{"text":" for (auto & line : tokenizeString(accessor->readFile(metricsFile), \"\\n\")) {","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:1814"}}],"del_contents":[{"Del":{"text":" auto file = secureRead(output + \"/nix-support/hydra-metrics\");","pos":"T5BIOVJEMBIASP7EKQVV2N3VD6I56UXH6LCD5I33BDQEVHJAMGKQC:734"}},{"Del":{"text":" for (auto & line : tokenizeString(std::get<1>(file), \"\\n\")) {","pos":"T5BIOVJEMBIASP7EKQVV2N3VD6I56UXH6LCD5I33BDQEVHJAMGKQC:813"}}]}},{"Edit":{"inode":{"change":3,"pos":441},"path":"src/hydra-queue-runner/build-result.cc","line":129,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1208},"to":{"change":2,"start":1144,"end":1151},"introduced_by":2}],"inode":{"change":3,"pos":441}}},"contents":[{"Del":{"text":"#endif","pos":"73YR46NJNYZQKHA3QDJCAZYAKC2CGEF5LIS44NOIPDZU6FX6BDPQC:1150"}}]}},{"Edit":{"inode":{"change":3,"pos":4329},"path":"src/hydra-queue-runner/build-result.hh","line":7,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":4389}],"down_context":[{"change":3,"pos":4389}],"flag":"BLOCK","start":1816,"end":1840,"inode":{"change":3,"pos":4329}}},"contents":[{"Add":{"text":"#include \"store-api.hh\"","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:1839"}}]}},{"Replacement":{"inode":{"change":3,"pos":4329},"path":"src/hydra-queue-runner/build-result.hh","line":41,"ins":{"up_context":[{"change":3,"pos":4741}],"down_context":[],"flag":"BLOCK","start":1841,"end":1966,"inode":{"change":3,"pos":4329}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4741},"to":{"change":3,"start":545,"end":630},"introduced_by":3}],"inode":{"change":3,"pos":4329}},"ins_contents":[{"Add":{"text":"BuildOutput getBuildOutput(nix::ref store,","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:1895"}},{"Add":{"text":" nix::ref accessor, const nix::Derivation & drv);","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:1965"}}],"del_contents":[{"Del":{"text":"BuildOutput getBuildOutput(nix::ref store, const nix::Derivation & drv);","pos":"DKJFD6JNNK5LJMRGQABMJZKMFZLGY3ADKJWF6J4BBHEUPY3NB67QC:629"}}]}},{"Replacement":{"inode":{"change":3,"pos":133},"path":"src/hydra-queue-runner/builder.cc","line":129,"ins":{"up_context":[{"change":3,"pos":4608}],"down_context":[{"change":3,"pos":4678}],"flag":"BLOCK","start":1967,"end":2069,"inode":{"change":3,"pos":133}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4608},"to":{"change":2,"start":1433,"end":1507},"introduced_by":2}],"inode":{"change":3,"pos":133}},"ins_contents":[{"Add":{"text":" if (result.success()) res = getBuildOutput(destStore, destStore->getFSAccessor(), step->drv);","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:2068"}}],"del_contents":[{"Del":{"text":" if (result.success()) res = getBuildOutput(destStore, step->drv);","pos":"73YR46NJNYZQKHA3QDJCAZYAKC2CGEF5LIS44NOIPDZU6FX6BDPQC:1506"}}]}},{"Replacement":{"inode":{"change":3,"pos":20067},"path":"src/hydra-queue-runner/queue-monitor.cc","line":162,"ins":{"up_context":[{"change":3,"pos":24924}],"down_context":[{"change":3,"pos":24982}],"flag":"BLOCK","start":2070,"end":2160,"inode":{"change":3,"pos":20067}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":24924},"to":{"change":2,"start":12757,"end":12819},"introduced_by":2}],"inode":{"change":3,"pos":20067}},"ins_contents":[{"Add":{"text":" BuildOutput res = getBuildOutput(destStore, destStore->getFSAccessor(), drv);","pos":"BAFICF73XUYNAYT6T6X7GQIFHG6CLGPYYNFBMC6ON6SVPNOXO6RAC:2159"}}],"del_contents":[{"Del":{"text":" BuildOutput res = getBuildOutput(destStore, drv);","pos":"73YR46NJNYZQKHA3QDJCAZYAKC2CGEF5LIS44NOIPDZU6FX6BDPQC:12818"}}]}}],"owner":"grahamc","repo":"hydra","token":"dIwHHlkEC9Tfdc1SQ2LJx3W36N/6z70gejC4WWE2HH4=","login":null}

…

Dependencies

Change contents

Review