{"header":{"message":"Remove Persona support","description":"Persona is no longer supported by Mozilla, so let's remove it.","timestamp":"2016-10-20T12:14:04Z","authors":[{"email":"edolstra@gmail.com","name":"Eelco Dolstra"}]},"hash":"BPT4WJ7UWVRNXFO2GD2I2P5Z5PHKZDRVIOAAUW23JI5H4GCHLGSAC","authors":[],"deps":{"hashes":[["BPT4WJ7UWVRNXFO2GD2I2P5Z5PHKZDRVIOAAUW23JI5H4GCHLGSAC","Remove Persona support"],["AA",null],["XHOZT4WTBN3Y7Q2MBANFS65X4HYL6SGPA7JNB7T7OD726SU2ACWAC","Add a command `hydra-create-user' for managing user accounts"],["JATZRMWWP6ENJRULJ2PFW6NT35C4N3WVWACAFFNI5DKF2H6AY7FAC","Lazy load Google and Persona login stuff"],["BKMQXGBOQIANQGBI3JMMVE3CA32SJF2MI4XMXAJA3EWZ2MYPZDTQC","Allow public dashboards"],["D44B24QC6NCED6DVUYP2IJJEVBG2JNBKPBRRSLI5UXQTKA23DJQQC","Store the account type (\"hydra\" or \"persona\") explicitly in the database"],["3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC","Add support for logging in via a Google account"],["QVIQAYZTTDRODPFP6HCWOETJ2OYLECU34FD4K5YKL7ENLG6HI3GAC","Be paranoid about the Persona email address"],["IDP66ILEKRRM3NH5XGKKSP77XTZXBY2DWVLQWZHOSZDZUCDO4LGQC","Use Google's verifier"],["XJRJ4J7M6BC433TBLWHHKX7UYYCFX6M7ZQLUEYYTREPCSM6M3RDQC","Add user registration"],["ZDENAYQI5DRRNUIDVKUGC45NK6C4ZFUL5FYMACTRZOCYQXPMY63QC","* email notification of evaluation errors to project owner (if desired)"],["JFW656FT5JSDCA5NBNFGTJABIR2LR5VRDRYI7KF54PYNFDSL4DMAC","Add a flag to enable Persona support"],["3YHNO5H2IBHEAHVVYKTD4TYWR5AU2MUWYYMMCRSEIL5MDGRXMTIAC","Don't use Perl's -w flag"],["J5UVLXOK6EDIL5I7VKWH4V2QDS4DPD7FHRK6XBWSXFRQS4JKXFZQC","* Start of a basic Catalyst web interface."],["7VHPMFAGIYN4NCFBVPVCYDENEDB6KPNMHPWML7WJJUESK6ZQYMJQC","Use /usr/bin/env to find perl"],["2CZSW5S53UW7ACDNT5T3UQNJKFBCXCBYLQ5CL6GVCCOMKBGXZIEQC","Don't redirect to /login if authentication is required"],["2DHE2ZAKR4AU7OE6E5CYNFWVGQXLHEX5LFKVU43PMBVX3QW6RHFAC","Allow Hydra to run as a private instance by requiring a login."],["KN3VYE5P2RJB3KZ355LA5C2T2D5S2IR3QZFE53AJIWUVMETEEYDAC","* Cleaned up the foreign key constraints."],["JARRBLZDQ2JZWY7IUVPTOT7WJMBPMLFLF2MGLVGOYROAAISYGLSAC","Bootstrapify the Hydra forms (except the project and jobset edit pages)"],["36ZTCZ4FDV6ILURQEIGFHCP57ALZH6OWYNN3MBXG2QXZSBULBPMAC","Add basic Persona support"],["PFB5ZUQWW67FRYY54QGTAVTWYMUKXLXRA2XCY3IWK6HZNE6DDLFAC","Fix legacy login"],["HK32XC42XOS7JKJMFT3XJKPXVSI44SFGKUUSJIL5VGPIHYNNWXLAC",""],["UAPS46BQNEZACYO2LYXEXIK5YESDG2N2B3BYIZGVETGP6LOM4OGAC",""],["HL6ZYWHFSOSTGCUEP2K554F5OY4RWAHJYS2MA2V3JMZIG262LFKAC","Allow configuring a set of domains to allow logins from Persona."],["QL55ECJ6KMMBUOWQ6LKSOVN7L43CH4S6SPE2AQ3VX3KSGC32RP4AC","- adapted ui for hydra, more in line with nixos.org website"],["N22GPKYTOLZLBGTGDATQDVZ4R5APZEAOIA7L32X4UXBH4XNI7MWAC","* Put info about logs / build products in the DB."]],"deps":["XHOZT4WTBN3Y7Q2MBANFS65X4HYL6SGPA7JNB7T7OD726SU2ACWAC","JATZRMWWP6ENJRULJ2PFW6NT35C4N3WVWACAFFNI5DKF2H6AY7FAC","BKMQXGBOQIANQGBI3JMMVE3CA32SJF2MI4XMXAJA3EWZ2MYPZDTQC"],"known":["J5UVLXOK6EDIL5I7VKWH4V2QDS4DPD7FHRK6XBWSXFRQS4JKXFZQC","UAPS46BQNEZACYO2LYXEXIK5YESDG2N2B3BYIZGVETGP6LOM4OGAC","HK32XC42XOS7JKJMFT3XJKPXVSI44SFGKUUSJIL5VGPIHYNNWXLAC","KN3VYE5P2RJB3KZ355LA5C2T2D5S2IR3QZFE53AJIWUVMETEEYDAC","ZDENAYQI5DRRNUIDVKUGC45NK6C4ZFUL5FYMACTRZOCYQXPMY63QC","JARRBLZDQ2JZWY7IUVPTOT7WJMBPMLFLF2MGLVGOYROAAISYGLSAC","XJRJ4J7M6BC433TBLWHHKX7UYYCFX6M7ZQLUEYYTREPCSM6M3RDQC","36ZTCZ4FDV6ILURQEIGFHCP57ALZH6OWYNN3MBXG2QXZSBULBPMAC","2CZSW5S53UW7ACDNT5T3UQNJKFBCXCBYLQ5CL6GVCCOMKBGXZIEQC","PFB5ZUQWW67FRYY54QGTAVTWYMUKXLXRA2XCY3IWK6HZNE6DDLFAC","D44B24QC6NCED6DVUYP2IJJEVBG2JNBKPBRRSLI5UXQTKA23DJQQC","QVIQAYZTTDRODPFP6HCWOETJ2OYLECU34FD4K5YKL7ENLG6HI3GAC","JFW656FT5JSDCA5NBNFGTJABIR2LR5VRDRYI7KF54PYNFDSL4DMAC","HL6ZYWHFSOSTGCUEP2K554F5OY4RWAHJYS2MA2V3JMZIG262LFKAC","2DHE2ZAKR4AU7OE6E5CYNFWVGQXLHEX5LFKVU43PMBVX3QW6RHFAC","3YHNO5H2IBHEAHVVYKTD4TYWR5AU2MUWYYMMCRSEIL5MDGRXMTIAC","7VHPMFAGIYN4NCFBVPVCYDENEDB6KPNMHPWML7WJJUESK6ZQYMJQC","3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC","IDP66ILEKRRM3NH5XGKKSP77XTZXBY2DWVLQWZHOSZDZUCDO4LGQC"]},"hunks":[{"Replacement":{"inode":{"change":5,"pos":804},"path":"src/lib/Hydra/Controller/Root.pm","line":21,"ins":{"up_context":[{"change":5,"pos":1}],"down_context":[{"change":5,"pos":87}],"flag":"BLOCK","start":0,"end":48,"inode":{"change":5,"pos":804}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":1},"to":{"change":5,"start":38,"end":87},"introduced_by":5},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":87},"to":{"change":5,"start":24,"end":72},"introduced_by":5}],"inode":{"change":5,"pos":804}},"ins_contents":[{"Add":{"text":" return $c->request->path eq \"google-login\" ||","pos":"BPT4WJ7UWVRNXFO2GD2I2P5Z5PHKZDRVIOAAUW23JI5H4GCHLGSAC:47"}}],"del_contents":[{"Del":{"text":" return $c->request->path eq \"persona-login\" ||","pos":"2DHE2ZAKR4AU7OE6E5CYNFWVGQXLHEX5LFKVU43PMBVX3QW6RHFAC:86"}},{"Del":{"text":" $c->request->path eq \"google-login\" ||","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:71"}}]}},{"Replacement":{"inode":{"change":5,"pos":252},"path":"src/lib/Hydra/Controller/User.pm","line":57,"ins":{"up_context":[{"change":5,"pos":1}],"down_context":[{"change":5,"pos":405}],"flag":"BLOCK","start":49,"end":109,"inode":{"change":5,"pos":252}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":1},"to":{"change":5,"start":337,"end":405},"introduced_by":5}],"inode":{"change":5,"pos":252}},"ins_contents":[{"Add":{"text":" # If allowed_domains is set, check if the email address","pos":"BPT4WJ7UWVRNXFO2GD2I2P5Z5PHKZDRVIOAAUW23JI5H4GCHLGSAC:108"}}],"del_contents":[{"Del":{"text":" # If persona_allowed_domains is set, check if the email address","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:404"}}]}},{"Replacement":{"inode":{"change":5,"pos":252},"path":"src/lib/Hydra/Controller/User.pm","line":60,"ins":{"up_context":[{"change":5,"pos":488}],"down_context":[{"change":5,"pos":489}],"flag":"BLOCK","start":110,"end":216,"inode":{"change":5,"pos":252}},"del":{"edges":[{"previous":"","flag":"DELETED","from":{"change":5,"pos":488},"to":{"change":5,"start":145,"end":216},"introduced_by":5},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":145},"to":{"change":5,"start":145,"end":216},"introduced_by":5}],"inode":{"change":5,"pos":252}},"ins_contents":[{"Add":{"text":" my $allowed_domains = $c->config->{allowed_domains} // ($c->config->{persona_allowed_domains} // \"\");","pos":"BPT4WJ7UWVRNXFO2GD2I2P5Z5PHKZDRVIOAAUW23JI5H4GCHLGSAC:215"}}],"del_contents":[{"Del":{"text":" my $allowed_domains = $c->config->{persona_allowed_domains} || \"\";","pos":"HL6ZYWHFSOSTGCUEP2K554F5OY4RWAHJYS2MA2V3JMZIG262LFKAC:215"}}]}},{"Replacement":{"inode":{"change":5,"pos":252},"path":"src/lib/Hydra/Controller/User.pm","line":76,"ins":{"up_context":[{"change":5,"pos":669}],"down_context":[{"change":5,"pos":738}],"flag":"BLOCK","start":217,"end":293,"inode":{"change":5,"pos":252}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":669},"to":{"change":5,"start":669,"end":738},"introduced_by":5}],"inode":{"change":5,"pos":252}},"ins_contents":[{"Add":{"text":" # Automatically upgrade legacy Persona accounts to Google accounts.","pos":"BPT4WJ7UWVRNXFO2GD2I2P5Z5PHKZDRVIOAAUW23JI5H4GCHLGSAC:292"}}],"del_contents":[{"Del":{"text":" # Automatically upgrade Persona accounts to Google accounts.","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:737"}}]}},{"Edit":{"inode":{"change":5,"pos":252},"path":"src/lib/Hydra/Controller/User.pm","line":100,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":1022},"to":{"change":5,"start":1022,"end":1214},"introduced_by":5},{"previous":"","flag":"DELETED","from":{"change":5,"pos":1214},"to":{"change":5,"start":1115,"end":1116},"introduced_by":5},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":1115},"to":{"change":5,"start":1115,"end":1116},"introduced_by":5},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":1116},"to":{"change":5,"start":1215,"end":1276},"introduced_by":5},{"previous":"","flag":"DELETED","from":{"change":5,"pos":1276},"to":{"change":5,"start":1116,"end":1117},"introduced_by":5},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":1116},"to":{"change":5,"start":1116,"end":1117},"introduced_by":5},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":1117},"to":{"change":5,"start":1277,"end":1760},"introduced_by":5}],"inode":{"change":5,"pos":252}}},"contents":[{"Del":{"text":"sub persona_login :Path('/persona-login') Args(0) {","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:1073"}},{"Del":{"text":" my ($self, $c) = @_;","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:1098"}},{"Del":{"text":" requirePost($c);","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:1119"}},{"Del":{"text":"","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:1120"}},{"Del":{"text":" error($c, \"Logging in via Persona is not enabled.\") unless $c->config->{enable_persona};","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:1213"}},{"Del":{"text":"","pos":"36ZTCZ4FDV6ILURQEIGFHCP57ALZH6OWYNN3MBXG2QXZSBULBPMAC:1115"}},{"Del":{"text":" my $assertion = $c->stash->{params}->{assertion} or die;","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:1275"}},{"Del":{"text":"","pos":"36ZTCZ4FDV6ILURQEIGFHCP57ALZH6OWYNN3MBXG2QXZSBULBPMAC:1116"}},{"Del":{"text":" my $ua = new LWP::UserAgent;","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:1309"}},{"Del":{"text":" my $response = $ua->post(","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:1339"}},{"Del":{"text":" 'https://verifier.login.persona.org/verify',","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:1392"}},{"Del":{"text":" { assertion => $assertion,","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:1427"}},{"Del":{"text":" audience => $c->uri_for('/')","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:1466"}},{"Del":{"text":" });","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:1478"}},{"Del":{"text":" error($c, \"Did not get a response from Persona.\") unless $response->is_success;","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:1562"}},{"Del":{"text":"","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:1563"}},{"Del":{"text":" my $d = decode_json($response->decoded_content) or die;","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:1623"}},{"Del":{"text":" error($c, \"Persona says: $d->{reason}\") if $d->{status} ne \"okay\";","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:1694"}},{"Del":{"text":"","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:1695"}},{"Del":{"text":" doEmailLogin($self, $c, \"persona\", $d->{email}, undef);","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:1755"}},{"Del":{"text":"}","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:1757"}},{"Del":{"text":"","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:1758"}},{"Del":{"text":"","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:1759"}}]}},{"Edit":{"inode":{"change":5,"pos":3592},"path":"src/root/auth.tt","line":5,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":123},"to":{"change":3,"start":123,"end":237},"introduced_by":3}],"inode":{"change":5,"pos":3592}}},"contents":[{"Del":{"text":" [% END %]","pos":"JATZRMWWP6ENJRULJ2PFW6NT35C4N3WVWACAFFNI5DKF2H6AY7FAC:134"}},{"Del":{"text":"","pos":"JATZRMWWP6ENJRULJ2PFW6NT35C4N3WVWACAFFNI5DKF2H6AY7FAC:135"}},{"Del":{"text":" [% IF c.user.type == 'persona' %]","pos":"JATZRMWWP6ENJRULJ2PFW6NT35C4N3WVWACAFFNI5DKF2H6AY7FAC:171"}},{"Del":{"text":" ","pos":"JATZRMWWP6ENJRULJ2PFW6NT35C4N3WVWACAFFNI5DKF2H6AY7FAC:236"}}]}},{"Edit":{"inode":{"change":5,"pos":3592},"path":"src/root/auth.tt","line":75,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":414},"to":{"change":3,"start":414,"end":530},"introduced_by":3}],"inode":{"change":5,"pos":3592}}},"contents":[{"Del":{"text":" [% END %]","pos":"JATZRMWWP6ENJRULJ2PFW6NT35C4N3WVWACAFFNI5DKF2H6AY7FAC:429"}},{"Del":{"text":" [% IF c.config.enable_persona %]","pos":"JATZRMWWP6ENJRULJ2PFW6NT35C4N3WVWACAFFNI5DKF2H6AY7FAC:468"}},{"Del":{"text":" $.getScript(\"https://login.persona.org/include.js\");","pos":"JATZRMWWP6ENJRULJ2PFW6NT35C4N3WVWACAFFNI5DKF2H6AY7FAC:529"}}]}},{"Edit":{"inode":{"change":5,"pos":3592},"path":"src/root/auth.tt","line":96,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":655},"to":{"change":3,"start":655,"end":665},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":665},"to":{"change":5,"start":5866,"end":5893},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":5866},"to":{"change":5,"start":5866,"end":5893},"introduced_by":5},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":5893},"to":{"change":3,"start":666,"end":760},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":760},"to":{"change":5,"start":6000,"end":6001},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":6000},"to":{"change":5,"start":6000,"end":6001},"introduced_by":5},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":6001},"to":{"change":3,"start":761,"end":1147},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":1147},"to":{"change":5,"start":6338,"end":6350},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":6338},"to":{"change":5,"start":6338,"end":6350},"introduced_by":5},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":6350},"to":{"change":3,"start":1148,"end":1202},"introduced_by":3}],"inode":{"change":5,"pos":3592}}},"contents":[{"Del":{"text":" });","pos":"JATZRMWWP6ENJRULJ2PFW6NT35C4N3WVWACAFFNI5DKF2H6AY7FAC:664"}},{"Del":{"text":" ","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:5879"}},{"Del":{"text":" [% END %]","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:5891"}},{"Del":{"text":"","pos":"3QWDDLBR5DGFK5Y3TDMK55R2SCHRHFVO2KW2BMZGIYRTIQEZC45AC:5892"}},{"Del":{"text":" [% IF c.config.enable_persona %]","pos":"JATZRMWWP6ENJRULJ2PFW6NT35C4N3WVWACAFFNI5DKF2H6AY7FAC:700"}},{"Del":{"text":"

…

Dependencies

Change contents

Review