Fix the jobset unchanged check

Dependencies

• [2] RXVJFQ5A Evaluator cleanups
• [3] BMSQD2ZH Indentation
• [4] 5SHCWE7X * Prevent repeated evaluation of a jobset with the same inputs. This
• [5] FM4O2L4M hydra: if evaluator sees cached build, also add the buildproducts
• [6] PIMGMGAF Rename hydra_eval_jobs to hydra-eval-jobs
• [7] FDE3BJAP * Refactoring.
• [*] OOQ2D3KC * Refactoring: move fetchInput out of hydra_scheduler into a separate
• [*] N22GPKYT * Put info about logs / build products in the DB.
• [*] S6OISBQ3 * Mark the "current" builds in a jobset, i.e. those corresponding to
• [*] RFE6T5LG * Store jobset evaluations in the database explicitly. This includes

Change contents

• replacement in src/lib/Hydra/Helper/AddBuilds.pm at line 791
  [2.94]→[2.94:216](∅→∅)
  − # Return the most recent evaluation of the given jobset that had new

  − # builds, or undefined if no such evaluation exists.
  [2.94]

  [2.216]
  + # Return the most recent evaluation of the given jobset (that

  + # optionally had new builds), or undefined if no such evaluation

  + # exists.
• replacement in src/lib/Hydra/Helper/AddBuilds.pm at line 795
  [2.240]→[2.240:372](∅→∅)
  − my ($db, $jobset) = @_;

  − my ($prevEval) = $jobset->jobsetevals({ hasnewbuilds => 1 }, { order_by => "id DESC", rows => 1 });
  [2.240]

  [2.372]
  + my ($db, $jobset, $hasNewBuilds) = @_;

  + my ($prevEval) = $jobset->jobsetevals(

  + ($hasNewBuilds ? { hasnewbuilds => 1 } : { }),

  + { order_by => "id DESC", rows => 1 });
• replacement in src/script/hydra-evaluator at line 113
  [3.2334]→[2.1869:1961](∅→∅)
  − my $prevEval = getPrevJobsetEval($db, $jobset);

  − if ($prevEval->hash eq $argsHash) {
  [3.2334]

  [2.1961]
  + if (getPrevJobsetEval($db, $jobset, 0)->hash eq $argsHash) {
• edit in src/script/hydra-evaluator at line 128
  [11.5278]

  [2.2020]
  + my $prevEval = getPrevJobsetEval($db, $jobset, 1);

  +
• edit in src/script/hydra-evaluator at line 170
  [12.6534]

  [12.6534]
  + print STDERR " created new eval ", $ev->id, "\n";

  + } else {

  + print STDERR " created cached eval ", $ev->id, "\n";