* Release sets: need to include the jobset name to disambiguate

[?]

Mar 14, 2009, 10:34 PM

E6IC7YIKCWI3LIG3DK7VTACIKCMMQWCOYROXXZL5FYHUWJ7CPN4AC

Dependencies

[2] MWU6FF4K
[3] S5PV6IIM * Represent jobs explicitly in the DB.
[4] IN272KZW * Automatically keep all builds in the latest successful release in
[5] 3ZCEPLNO
[6] L2E6EVE2 * Merged the Build and Job tables.
[7] HKWIDRO6 * I love untyped databases...
[8] R5D7DZPE
[9] QU5I5GCL
[10] AFTXA575 * $HYDRA_DATA environment variable.
[11] 2T42QGZD * Register builds as GC roots so they don't get deleted.
[12] TMP2FRIW
[13] NLJJZVHO * Use ->update({...}) properly.
[14] 3E6IP3R3 * Add the name of the jobset to ReleaseSetJobs, otherwise we can't
[15] G6HJY2V4
[*] J5UVLXOK * Start of a basic Catalyst web interface.
[*] 2GK5DOU7 * Downloading closures.
[*] N22GPKYT * Put info about logs / build products in the DB.

Change contents

edit in src/lib/Hydra/Controller/Root.pm at line 119

[4.495]

[4.495]

$name =~ /^(\w+):(\w+)$/ or error($c, "Invalid job name: $name");
my $jobsetName = $1;
my $jobName = $2;
replacement in src/lib/Hydra/Controller/Root.pm at line 124

[4.496]→[4.0:63](∅→∅)

die "Invalid job name: $name" unless $name =~ /^\w+$/;

[4.496]

[4.63]

error($c, "Jobset `$jobsetName' doesn't exist.")
unless $releaseSet->project->jobsets->find({name => $jobsetName});

# !!! We could check whether the job exists, but that would
# require the scheduler to have seen the job, which may not be
# the case.
replacement in src/lib/Hydra/Controller/Root.pm at line 132

[4.541]→[4.541:568](∅→∅)

{ job => $name

[4.541]

[4.568]

{ jobset => $jobsetName
, job => $jobName
replacement in src/lib/Hydra/Helper/Nix.pm at line 127

[4.1530]→[3.48:114](∅→∅)

{ job => $primaryJob->get_column('job'), finished => 1 },

[4.1530]

[4.1587]

{ jobset => $primaryJob->get_column('jobset'), job => $primaryJob->get_column('job'), finished => 1 },
replacement in src/lib/Hydra/Helper/Nix.pm at line 157

[4.2478]→[3.115:182](∅→∅)

{ job => $job->get_column('job'), finished => 1 },

[4.2478]

[4.2536]

{ jobset => $job->get_column('jobset'), job => $job->get_column('job'), finished => 1 },
replacement in src/root/edit-releaseset.tt at line 17

[2.79]→[4.474:614](∅→∅),[4.474]→[4.474:614](∅→∅)

<td><input type="text" class="string" [% HTML.attributes(id => "$baseName-name", name => "$baseName-name", value => job.job) %] /></td>

[2.79]

[4.614]

<td><input type="text" class="string" [% HTML.attributes(id => "$baseName-name", name => "$baseName-name", value => "$job.jobset:$job.job") %] /></td>
replacement in src/sql/hydra.sql at line 46

[4.2312]→[4.2312:2407](∅→∅)

disabled integer not null default 0, -- true means hold this job until its re-enabled

[4.2312]

[4.2510]

disabled integer not null default 0,
edit in src/sql/hydra.sql at line 271

[3.7353]

[3.7353]

disabled integer not null default 0,