perlcritic: Readonly -> ReadonlyX

[?]
Dec 14, 2021, 3:03 PM
GANSIVJ4DQVMWT7I4WVSC2YM5LQ7SKBLCXK23YPWFHT7Z6ASJZJAC

Dependencies

  • [2] 3IS4CTTL Allow _ in release names
  • [3] JVUEJJXY Also allow : (colon) in pathCompRE.
  • [4] OK4P3AMK Remove the ability to add multiple jobset input alternatives
  • [5] TPNHTE5V Remove obsolete Builds columns and provide accurate "Running builds"
  • [6] S5RUGITI Prometheus: init Tiny, TinyShared
  • [7] BKTYQRT4 Use PrometheusTinyShared
  • [8] 7DWCXNC7 Use the new Nix Perl bindings
  • [9] A52HEFHQ * Allow builds to be restarted (if they failed with a transient error,
  • [10] ONGLIFOY allow _'s in first character of filenames
  • [11] 4KLYYXWW Allow dashes in attrNames
  • [12] XJRJ4J7M Add user registration
  • [13] HNUZZHS4 Allow dots in jobset names (like "release-13.09")
  • [14] RWNXH3H2 lastModified -> lastModifiedDate
  • [15] 7I2U2MHU perlcritic: use strict, use warnings
  • [16] W63765MK Add dollar to pathCompRE, which allows files with dollars in them to be served by Hydra, e.g. sphinx generated docs often has these types of files.
  • [17] PCKLFRT5 Support push notification of repository changes
  • [18] R6B5CAFF Let Builds.timestamp refer to the time the build was added
  • [19] FPK5LF53 * Put the project-related actions in a separate controller. Put the
  • [20] HQGXL4MX Add validation for project and jobset names
  • [21] URM4AXZX flake.nix sort hydra-perl-deps inputs
  • [22] N45RZUQ6 Reduce I/O in build listings by only fetching required columns
  • [23] I7DFJWL6 hydra-notify: initial scratch take of prometheus events
  • [24] 5NO7NCKT * Refactoring.
  • [25] LBNVQXUB * Build the /build stuff in a separate controller.
  • [26] LSZLZHJY Allow users to edit their own settings
  • [27] 7UJ5YV4V * Provide a channel for each project containing all the latest
  • [28] CS7T2XFI
  • [29] M2JQG2SN Flake: add perlcritic deps
  • [30] G5ZR3ZVZ hydra: put contents links into html, add links to files from contents page
  • [31] RX5IIZMT Use Email::MIME instead of Email::Simple
  • [*] 2G37UFZF flake: add TestPostgreSQL for per-test DBs

Change contents

  • edit in flake.nix at line 202
    [6.1561]
    [33.2187]
    ReadonlyX = final.perlPackages.buildPerlModule {
    pname = "ReadonlyX";
    version = "1.04";
    src = final.fetchurl {
    url = "mirror://cpan/authors/id/S/SA/SANKO/ReadonlyX-1.04.tar.gz";
    sha256 = "81bb97dba93ac6b5ccbce04a42c3590eb04557d75018773ee18d5a30fcf48188";
    };
    buildInputs = with final.perlPackages; [ ModuleBuildTiny TestFatal ];
    meta = {
    homepage = "https://github.com/sanko/readonly";
    description = "Faster facility for creating read-only scalars, arrays, hashes";
    license = final.lib.licenses.artistic2;
    };
    };
  • replacement in flake.nix at line 490
    [7.37][8.2514:2539](),[8.2514][8.2514:2539]()
    Readonly
    [7.37]
    [8.2573]
    ReadonlyX
  • replacement in src/lib/Hydra/Helper/CatalystUtils.pm at line 7
    [8.3535][8.92:106]()
    use Readonly;
    [8.3535]
    [8.144]
    use ReadonlyX;
  • replacement in src/lib/Hydra/Helper/CatalystUtils.pm at line 37
    [8.634][5.1569:1727]()
    Readonly our @buildListColumns => ('id', 'finished', 'timestamp', 'stoptime', 'project', 'jobset', 'job', 'nixname', 'system', 'buildstatus', 'releasename');
    [8.634]
    [8.3595]
    Readonly::Array our @buildListColumns => ('id', 'finished', 'timestamp', 'stoptime', 'project', 'jobset', 'job', 'nixname', 'system', 'buildstatus', 'releasename');
  • replacement in src/lib/Hydra/Helper/CatalystUtils.pm at line 320
    [8.218][3.0:79](),[8.78][8.1630:1697](),[3.79][8.1630:1697](),[8.1630][8.1630:1697](),[8.1697][2.0:68](),[2.68][8.0:62](),[8.1763][8.0:62](),[8.62][8.1824:1886](),[8.1824][8.1824:1886](),[8.1886][8.94:158](),[8.158][8.1948:2077](),[8.1948][8.1948:2077](),[8.2077][8.3554:3610](),[8.3610][4.451:513]()
    Readonly our $pathCompRE => "(?:[A-Za-z0-9-\+\._\$][A-Za-z0-9-\+\._\$:]*)";
    Readonly our $relPathRE => "(?:$pathCompRE(?:/$pathCompRE)*)";
    Readonly our $relNameRE => "(?:[A-Za-z0-9-_][A-Za-z0-9-\._]*)";
    Readonly our $attrNameRE => "(?:[A-Za-z_][A-Za-z0-9-_]*)";
    Readonly our $projectNameRE => "(?:[A-Za-z_][A-Za-z0-9-_]*)";
    Readonly our $jobsetNameRE => "(?:[A-Za-z_][A-Za-z0-9-_\.]*)";
    Readonly our $jobNameRE => "(?:$attrNameRE(?:\\.$attrNameRE)*)";
    Readonly our $systemRE => "(?:[a-z0-9_]+-[a-z0-9_]+)";
    Readonly our $userNameRE => "(?:[a-z][a-z0-9_\.]*)";
    Readonly our $inputNameRE => "(?:[A-Za-z_][A-Za-z0-9-_]*)";
    [8.218]
    [8.1658]
    Readonly::Scalar our $pathCompRE => "(?:[A-Za-z0-9-\+\._\$][A-Za-z0-9-\+\._\$:]*)";
    Readonly::Scalar our $relPathRE => "(?:$pathCompRE(?:/$pathCompRE)*)";
    Readonly::Scalar our $relNameRE => "(?:[A-Za-z0-9-_][A-Za-z0-9-\._]*)";
    Readonly::Scalar our $attrNameRE => "(?:[A-Za-z_][A-Za-z0-9-_]*)";
    Readonly::Scalar our $projectNameRE => "(?:[A-Za-z_][A-Za-z0-9-_]*)";
    Readonly::Scalar our $jobsetNameRE => "(?:[A-Za-z_][A-Za-z0-9-_\.]*)";
    Readonly::Scalar our $jobNameRE => "(?:$attrNameRE(?:\\.$attrNameRE)*)";
    Readonly::Scalar our $systemRE => "(?:[a-z0-9_]+-[a-z0-9_]+)";
    Readonly::Scalar our $userNameRE => "(?:[a-z][a-z0-9_\.]*)";
    Readonly::Scalar our $inputNameRE => "(?:[A-Za-z_][A-Za-z0-9-_]*)";