Dependencies

• [2] KFFNFE4D
• [3] JD27RBKM
• [4] 7YBYT2LQ
• [5] KOTB7BKV
• [6] J5UVLXOK * Start of a basic Catalyst web interface.
• [7] LQNBKF3D
• [8] 2AUODJBT
• [9] L5VIEXSC * Allow downloading of build products.
• [10] W6DC6K4I * Happy Javascript hacking.
• [11] UVMFS73T * Some jQuery / CSS hackery.
• [12] DVNWJXWW * Generic declaration of build products.
• [13] MOCEUXZA * Support serving products that are directories (such as manuals or
• [14] B72GLND4
• [15] K5BEBWKM
• [*] UAPS46BQ

Change contents

• edit in src/HydraFrontend/lib/HydraFrontend/Controller/Root.pm at line 12
  [3.1084]

  [17.0]
  +

  +

  + # Security checking of filenames.

  + my $pathCompRE = "(?:[A-Za-z0-9-\+][A-Za-z0-9-\+\._]*)";

  + my $relPathRE = "(?:$pathCompRE(?:\/$pathCompRE)*)";
• edit in src/HydraFrontend/lib/HydraFrontend/Controller/Root.pm at line 82
  [3.385]

  [3.385]
  + # The Nix expression path must be relative and can't contain ".." elements.
• replacement in src/HydraFrontend/lib/HydraFrontend/Controller/Root.pm at line 84
  [3.466]→[3.466:570](∅→∅)
  − die "Invalid Nix expression path: $nixExprPath" unless $nixExprPath =~ /^\w++$/; # !!! stricter
  [3.466]

  [3.570]
  + die "Invalid Nix expression path: $nixExprPath" if $nixExprPath !~ /^$relPathRE$/;
• replacement in src/HydraFrontend/lib/HydraFrontend/Controller/Root.pm at line 303
  [3.218]→[3.218:356](∅→∅)
  − if ($elem eq "." || $elem eq ".." || $elem !~ /^[\w\-\.]+$/) {

  − return error($c, "Invalid filename $elem.");

  − }
  [3.218]

  [3.356]
  + return error($c, "Invalid filename $elem.") if $elem !~ /^$pathCompRE$/;
• replacement in src/HydraFrontend/root/hydra.css at line 19
  [3.8897]→[3.1902:1923](∅→∅)
  − margin-top: 2em;
  [3.8897]

  [3.8897]
  + margin-top: 1em;
• edit in src/HydraFrontend/root/hydra.css at line 24
  [3.8926]→[3.1924:1947](∅→∅)
  − margin-top: 1.5em;
• edit in src/HydraFrontend/root/hydra.css at line 181
  [3.3711]

  [3.1948]
  + }

  +

  + div.template {

  + display: none;
• replacement in src/HydraFrontend/root/hydra.css at line 187
  [3.1951]→[3.1951:1987](∅→∅)
  − div.indent {

  − padding-left: 2em;
  [3.1951]

  [3.3711]
  + div.jobset {

  + border: solid black 1px;

  + padding-left: 1em;

  + padding-right: 1em;

  + padding-bottom: 1em;

  + margin-bottom: 1em;

  + }

  +

  + div.jobset-edit {

  + border: solid black 1px;

  + background-color: #f8f8f8;

  + padding-left: 1em;

  + padding-right: 1em;

  + margin-bottom: 1em;
• replacement in src/HydraFrontend/root/hydra.css at line 203
  [3.1607]→[3.1988:2022](∅→∅)
  − div.template {

  − display: none;
  [3.1607]

  [3.2022]
  + div.jobset-edit h3, div.jobset h3 {

  + margin-top: 0.5em;
• replacement in src/HydraFrontend/root/project.tt at line 16
  [3.3444]→[2.89:112](∅→∅)
  − <div class="jobset">
  [3.3444]

  [3.1783]
  + <div class="jobset[% IF edit %] jobset-edit[% END %]">
• edit in src/HydraFrontend/root/project.tt at line 20
  [3.1826]→[2.203:226](∅→∅),[2.226]→[3.1871:1872](∅→∅),[3.2323]→[3.1871:1872](∅→∅),[3.1871]→[3.1871:1872](∅→∅)
  − <div class="indent">

  −
• edit in src/HydraFrontend/root/project.tt at line 91
  [3.2848]→[3.2848:2857](∅→∅)
  − </div>