* Cleanup.

[?]

Mar 5, 2010, 4:37 PM

ID5DHUFUROHFV4UHHMCLH3S4BWDSK7JRYIAZ2QF37LJERXIDQKMQC

Dependencies

[2] XBU2ODSP * More renaming.
[3] P5X4P6VK * Renaming "release sets" to "views" (not finished yet). Having
[4] T2232OBS * Add some DB indices to make the /releases page much faster.
[5] IN272KZW * Automatically keep all builds in the latest successful release in
[6] PPJN6SDP * paging for releases page
[*] 2GK5DOU7 * Downloading closures.

Change contents

replacement in src/lib/Hydra/Helper/Nix.pm at line 167

[3.1942]→[3.1942:2396](∅→∅)

{ project => $job->get_column('project'), jobset => $job->get_column('jobset')
, job => $job->get_column('job'), finished => 1
}
, { join => 'resultInfo', rows => 1
, order_by => ["buildstatus", "timestamp"]
, where => \ attrsToSQL($job->attrs, "build.id")
, '+select' => ["resultInfo.buildstatus"], '+as' => ["buildstatus"]
});
return $thisBuild ;

[3.1942]

[3.2396]

{ project => $job->get_column('project'), jobset => $job->get_column('jobset')
, job => $job->get_column('job'), finished => 1
},
{ join => 'resultInfo', rows => 1
, order_by => ["buildstatus", "timestamp"]
, where => \ attrsToSQL($job->attrs, "build.id")
, '+select' => ["resultInfo.buildstatus"], '+as' => ["buildstatus"]
});
edit in src/lib/Hydra/Helper/Nix.pm at line 176

[3.2401]→[3.2401:2404](∅→∅),[3.2404]→[2.1049:1050](∅→∅),[2.1050]→[3.2404:2899](∅→∅),[3.2404]→[3.2404:2899](∅→∅)

}

sub findLastJobForPrimaryBuild {
my ($primaryBuild, $job) = @_;
my $thisBuild;
my $depBuilds;
$depBuilds = $primaryBuild->dependentBuilds;
$thisBuild = findLastJobForBuilds($depBuilds, $job) ;

# don't do recursive yet
# if (!defined $thisBuild) {
#
# foreach my $build ($depBuilds->all) {
# $thisBuild = findLastJobForPrimaryBuild($build, $job) ;
# if (defined $thisBuild) {
# last ;
# }
# }
# }
replacement in src/lib/Hydra/Helper/Nix.pm at line 192

[3.2095]→[3.2095:2207](∅→∅),[3.2207]→[3.2926:3001](∅→∅),[3.3001]→[3.2730:2740](∅→∅),[3.2730]→[3.2730:2740](∅→∅)

my $thisBuild;

if ($job->isprimary) {
$thisBuild = $primaryBuild;
} else {
$thisBuild = findLastJobForPrimaryBuild($primaryBuild, $job) ;
}

[3.2095]

[3.2740]

my $thisBuild = $job->isprimary
? $primaryBuild
: findLastJobForBuilds(scalar $primaryBuild->dependentBuilds, $job);