Use notFound instead of status_not_found

[?]

Oct 3, 2013, 12:16 PM

IRRNAEVLR2BOH46LC7IUM2US5VYO4UO7MPVOEZDZKHUOGS52QXTAC

Dependencies

[2] H66SHOS7 Fix and clean up editing project settings
[3] LZVO64YG Merge in the first bits of the API work
[4] UWVMQIAC * Refactoring.
[5] 3HZY24CX * Make jobsets viewable under
[6] FPK5LF53 * Put the project-related actions in a separate controller. Put the
[7] 75XUS62Y * Added a page to quickly see all failed builds and failed evaluations
[8] GNIEG2GC * Disambiguate jobs by jobset name. I.e. jobs with the same name in
[9] UMFB2767 Hydra/64: Leaving number of builds empty gives DBIx error
[10] NPG7RSJL The field is actually enabled, not disabled

Change contents

replacement in src/lib/Hydra/Controller/Jobset.pm at line 15

[3.6289]→[3.6289:6350](∅→∅)

if ($project) {
$c->stash->{project} = $project;

[3.6289]

[3.518]

notFound($c, "Project ‘$projectName’ doesn't exist.") if !$project;
replacement in src/lib/Hydra/Controller/Jobset.pm at line 17

[3.519]→[3.6351:6488](∅→∅)

$c->stash->{jobset_} = $project->jobsets->search({'me.name' => $jobsetName});
my $jobset = $c->stash->{jobset_}->single;

[3.519]

[3.0]

$c->stash->{project} = $project;
replacement in src/lib/Hydra/Controller/Jobset.pm at line 19

[3.1]→[3.6489:6555](∅→∅)

if ($jobset) {
$c->stash->{jobset} = $jobset;

[3.1]

[3.6555]

$c->stash->{jobset_} = $project->jobsets->search({'me.name' => $jobsetName});
my $jobset = $c->stash->{jobset_}->single;

if ($jobset) {
$c->stash->{jobset} = $jobset;
} else {
if ($c->action->name eq "jobset" and $c->request->method eq "PUT") {
$c->stash->{jobsetName} = $jobsetName;
replacement in src/lib/Hydra/Controller/Jobset.pm at line 28

[3.6572]→[3.6572:6922](∅→∅)

if ($c->action->name eq "jobset" and $c->request->method eq "PUT") {
$c->stash->{jobsetName} = $jobsetName;
} else {
$self->status_not_found(
$c,
message => "Jobset $jobsetName doesn't exist."
);
$c->detach;
}

[3.6572]

[3.6922]

notFound($c, "Jobset ‘$jobsetName’ doesn't exist.");
edit in src/lib/Hydra/Controller/Jobset.pm at line 30

[3.6932]→[3.6932:7086](∅→∅)

} else {
$self->status_not_found(
$c,
message => "Project $projectName doesn't exist."
);
$c->detach;
edit in src/lib/Hydra/Controller/Project.pm at line 3

[3.1283]→[2.0:10](∅→∅)

use utf8;
replacement in src/lib/Hydra/Controller/Project.pm at line 29

[3.1713]→[2.268:483](∅→∅),[2.483]→[3.16570:16576](∅→∅),[3.16570]→[3.16570:16576](∅→∅)

if (!$c->stash->{project} && !($c->action->name eq "project" and $c->request->method eq "PUT")) {
$self->status_not_found($c, message => "Project ‘$projectName’ doesn't exist.");
$c->detach;
}

[3.1713]

[3.1753]

notFound($c, "Project ‘$projectName’ doesn't exist.")
if (!$c->stash->{project} && !($c->action->name eq "project" and $c->request->method eq "PUT"));