{"header":{"message":"Include the project and jobset names in the configuration blocks","description":"to set the timeout for a specific input in the GitInput plugin.\n\nRemove the comments about using inputs with spaces.","timestamp":"2017-04-29T02:43:35Z","authors":[{"email":"jrivera-contractor@cars.com","name":"Joel Rivera"}]},"hash":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC","authors":[],"deps":{"hashes":[["JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC","Include the project and jobset names in the configuration blocks"],["AA",null],["34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC","Allow to configure the timeout value for the GitInput plugin in different places."],["JAH3UPWAVSHXIPNGL6PROQPZBYZHPJNFONWBDZX4HCX646USZXUQC","Support revision control systems via plugins"],["7EGUBBRQLBNFHH2E3ZMOTJBV36JG2A4Y5J2CR5I7V3WOXJVNLXYAC","Lock paths in the scm cache"]],"deps":["34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC"],"known":["JAH3UPWAVSHXIPNGL6PROQPZBYZHPJNFONWBDZX4HCX646USZXUQC","7EGUBBRQLBNFHH2E3ZMOTJBV36JG2A4Y5J2CR5I7V3WOXJVNLXYAC"]},"hunks":[{"Replacement":{"inode":{"change":3,"pos":4877},"path":"src/lib/Hydra/Plugin/GitInput.pm","line":52,"ins":{"up_context":[{"change":2,"pos":705}],"down_context":[{"change":2,"pos":752}],"flag":"BLOCK","start":0,"end":76,"inode":{"change":3,"pos":4877}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":705},"to":{"change":2,"start":705,"end":752},"introduced_by":2}],"inode":{"change":3,"pos":4877}},"ins_contents":[{"Add":{"text":"=item _pluginConfig($main_config, $project_name, $jobset_name, $input_name)","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:75"}}],"del_contents":[{"Del":{"text":"=item _pluginConfig($main_config, $input_name)","pos":"34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC:751"}}]}},{"Replacement":{"inode":{"change":3,"pos":4877},"path":"src/lib/Hydra/Plugin/GitInput.pm","line":65,"ins":{"up_context":[{"change":2,"pos":1160}],"down_context":[{"change":2,"pos":1308}],"flag":"BLOCK","start":77,"end":335,"inode":{"change":3,"pos":4877}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":1160},"to":{"change":2,"start":1160,"end":1308},"introduced_by":2}],"inode":{"change":3,"pos":4877}},"ins_contents":[{"Add":{"text":"Expected configuration format in the hydra config file:","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:132"}},{"Add":{"text":" ","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:148"}},{"Add":{"text":" # general timeout","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:172"}},{"Add":{"text":" timeout = 400","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:192"}},{"Add":{"text":"","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:193"}},{"Add":{"text":" ","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:227"}},{"Add":{"text":" # specific timeout for a particular input","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:277"}},{"Add":{"text":" timeout = 400","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:299"}},{"Add":{"text":" ","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:334"}}],"del_contents":[{"Del":{"text":"","pos":"34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC:1171"}},{"Del":{"text":" # general timeout","pos":"34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC:1191"}},{"Del":{"text":" timeout = 400","pos":"34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC:1207"}},{"Del":{"text":" ","pos":"34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC:1222"}},{"Del":{"text":" # specific timeout for a particular input name","pos":"34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC:1273"}},{"Del":{"text":" timeout = 400","pos":"34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC:1291"}},{"Del":{"text":" ","pos":"34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC:1307"}}]}},{"Replacement":{"inode":{"change":3,"pos":4877},"path":"src/lib/Hydra/Plugin/GitInput.pm","line":75,"ins":{"up_context":[{"change":2,"pos":1309}],"down_context":[{"change":2,"pos":1483}],"flag":"BLOCK","start":336,"end":353,"inode":{"change":3,"pos":4877}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":1309},"to":{"change":2,"start":1309,"end":1483},"introduced_by":2}],"inode":{"change":3,"pos":4877}},"ins_contents":[{"Add":{"text":" ","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:352"}}],"del_contents":[{"Del":{"text":" # use quotes when the input name has spaces","pos":"34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC:1354"}},{"Del":{"text":" <\"foot with spaces\">","pos":"34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC:1377"}},{"Del":{"text":" # specific timeout for a particular input name","pos":"34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC:1428"}},{"Del":{"text":" timeout = 400","pos":"34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC:1446"}},{"Del":{"text":" ","pos":"34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC:1469"}},{"Del":{"text":"","pos":"34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC:1482"}}]}},{"Replacement":{"inode":{"change":3,"pos":4877},"path":"src/lib/Hydra/Plugin/GitInput.pm","line":78,"ins":{"up_context":[{"change":2,"pos":1508}],"down_context":[{"change":2,"pos":1549}],"flag":"BLOCK","start":354,"end":424,"inode":{"change":3,"pos":4877}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":1508},"to":{"change":2,"start":1508,"end":1549},"introduced_by":2}],"inode":{"change":3,"pos":4877}},"ins_contents":[{"Add":{"text":" my ($main_config, $project_name, $jobset_name, $input_name) = @_;","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:423"}}],"del_contents":[{"Del":{"text":" my ($main_config, $input_name) = @_;","pos":"34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC:1548"}}]}},{"Edit":{"inode":{"change":3,"pos":4877},"path":"src/lib/Hydra/Plugin/GitInput.pm","line":84,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":1667}],"down_context":[{"change":2,"pos":1667}],"flag":"BLOCK","start":425,"end":490,"inode":{"change":3,"pos":4877}}},"contents":[{"Add":{"text":" my $input_block = \"$project_name:$jobset_name:$input_name\";","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:488"}},{"Add":{"text":"","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:489"}}]}},{"Replacement":{"inode":{"change":3,"pos":4877},"path":"src/lib/Hydra/Plugin/GitInput.pm","line":91,"ins":{"up_context":[{"change":2,"pos":1846}],"down_context":[{"change":2,"pos":1902}],"flag":"BLOCK","start":491,"end":548,"inode":{"change":3,"pos":4877}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":1846},"to":{"change":2,"start":1846,"end":1902},"introduced_by":2}],"inode":{"change":3,"pos":4877}},"ins_contents":[{"Add":{"text":" _printIfDebug \"Parsing plugin configuration:\\n\";","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:547"}}],"del_contents":[{"Del":{"text":" _printIfDebug \"Parsing plugin configuration: \";","pos":"34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC:1901"}}]}},{"Replacement":{"inode":{"change":3,"pos":4877},"path":"src/lib/Hydra/Plugin/GitInput.pm","line":94,"ins":{"up_context":[{"change":2,"pos":1944}],"down_context":[{"change":2,"pos":2163}],"flag":"BLOCK","start":549,"end":783,"inode":{"change":3,"pos":4877}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":1944},"to":{"change":2,"start":1944,"end":2163},"introduced_by":2}],"inode":{"change":3,"pos":4877}},"ins_contents":[{"Add":{"text":" if (defined $cfg->{$input_block} and %{$cfg->{$input_block}}) {","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:616"}},{"Add":{"text":" _printIfDebug \"Merging sections from $input_block\\n\";","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:679"}},{"Add":{"text":" # merge with precedense to the input block","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:731"}},{"Add":{"text":" $cfg = {%{$cfg}, %{$cfg->{$input_block}}};","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:782"}}],"del_contents":[{"Del":{"text":" if (defined $cfg->{$input_name} and %{$cfg->{$input_name}}) {","pos":"34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC:2009"}},{"Del":{"text":" _printIfDebug \"Merging sections for $input_name\\n\";","pos":"34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC:2070"}},{"Del":{"text":" $cfg = {%{$cfg}, %{$cfg->{$input_name}}}; # merge with precedense to the input name","pos":"34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC:2162"}}]}},{"Replacement":{"inode":{"change":3,"pos":4877},"path":"src/lib/Hydra/Plugin/GitInput.pm","line":101,"ins":{"up_context":[{"change":2,"pos":2254}],"down_context":[{"change":2,"pos":2317}],"flag":"BLOCK","start":784,"end":850,"inode":{"change":3,"pos":4877}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":2254},"to":{"change":2,"start":2254,"end":2317},"introduced_by":2}],"inode":{"change":3,"pos":4877}},"ins_contents":[{"Add":{"text":" _printIfDebug \"Using custom timeout for $input_block:\\n\";","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:849"}}],"del_contents":[{"Del":{"text":" _printIfDebug \"Using custom timeout for $input_name:\";","pos":"34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC:2316"}}]}},{"Replacement":{"inode":{"change":3,"pos":4877},"path":"src/lib/Hydra/Plugin/GitInput.pm","line":103,"ins":{"up_context":[{"change":2,"pos":2330}],"down_context":[{"change":2,"pos":2394}],"flag":"BLOCK","start":851,"end":918,"inode":{"change":3,"pos":4877}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":2330},"to":{"change":2,"start":2330,"end":2394},"introduced_by":2}],"inode":{"change":3,"pos":4877}},"ins_contents":[{"Add":{"text":" _printIfDebug \"Using default timeout for $input_block:\\n\";","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:917"}}],"del_contents":[{"Del":{"text":" _printIfDebug \"Using default timeout for $input_name:\";","pos":"34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC:2393"}}]}},{"Replacement":{"inode":{"change":3,"pos":4877},"path":"src/lib/Hydra/Plugin/GitInput.pm","line":110,"ins":{"up_context":[{"change":3,"pos":237}],"down_context":[{"change":3,"pos":280}],"flag":"BLOCK","start":919,"end":981,"inode":{"change":3,"pos":4877}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":237},"to":{"change":3,"start":237,"end":280},"introduced_by":3}],"inode":{"change":3,"pos":4877}},"ins_contents":[{"Add":{"text":" my ($self, $type, $name, $value, $project, $jobset) = @_;","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:980"}}],"del_contents":[{"Del":{"text":" my ($self, $type, $name, $value) = @_;","pos":"7EGUBBRQLBNFHH2E3ZMOTJBV36JG2A4Y5J2CR5I7V3WOXJVNLXYAC:279"}}]}},{"Replacement":{"inode":{"change":3,"pos":4877},"path":"src/lib/Hydra/Plugin/GitInput.pm","line":115,"ins":{"up_context":[{"change":2,"pos":2531}],"down_context":[{"change":2,"pos":2585}],"flag":"BLOCK","start":982,"end":1178,"inode":{"change":3,"pos":4877}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":2531},"to":{"change":2,"start":2531,"end":2585},"introduced_by":2}],"inode":{"change":3,"pos":4877}},"ins_contents":[{"Add":{"text":" my $cfg = _pluginConfig($self->{config},","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:1026"}},{"Add":{"text":" $project->get_column('name'),","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:1084"}},{"Add":{"text":" $jobset->get_column('name'),","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:1141"}},{"Add":{"text":" $name);","pos":"JYXWIQG4SYQYKID7V4KLHLCTNF2DEH73FPNIF5EU2VZTAVPSE6SAC:1177"}}],"del_contents":[{"Del":{"text":" my $cfg = _pluginConfig($self->{config}, $name);","pos":"34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC:2583"}},{"Del":{"text":"","pos":"34SOPSVFSYMJ4BTJBGREAU4H2LHFWI2GKTGZ6R3B4CTUITMVX35QC:2584"}}]}}],"owner":"grahamc","repo":"hydra","token":"gBJYumvxPvqR2ddwQIa9mQVHuNzCa31Jk7V+oXz1mJo=","login":null}

…

Dependencies

Change contents

Review