Fix broken logic for showing/hiding jobsets

[?]
Nov 1, 2016, 12:03 PM
KGH6UBAATMKHKTU6EJVVGOIFY56O6LXPYSIMQIRZQJUP2C7EERZQC

Dependencies

  • [2] 2CFO2MHS Hide hidden jobsets for project admins by default
  • [3] ZB3JV52W Add a "My jobsets" tab to the dashboard
  • [4] MCCHPWHE Indicate disabled/hidden projects/jobsets in the overviews
  • [5] SBMOICGV Evil CSS hackery to prevent link targets from being under the navbar
  • [6] JY7BXXOP Split viewing and editing a project
  • [7] KSBB33RE Add a dashboard
  • [8] 3PNG7NIB Remove trailing whitespace
  • [9] LCLXI7PT Search: Mark disabled projects/jobsets/jobs
  • [*] IK53RV4V
  • [*] 7YBYT2LQ
  • [*] J5UVLXOK * Start of a basic Catalyst web interface.

Change contents

  • replacement in src/root/common.tt at line 514
    [3.1179][2.78:201]()
    <tr class="[% IF j.hidden && !showHidden %] hidden-jobset [% END %] [% IF !j.enabled %] disabled-jobset [% END %]" >
    [3.1179]
    [3.1190]
    <tr class="jobset [% IF j.hidden && !showHidden %] hidden-jobset [% END %] [% IF !j.enabled %] disabled-jobset [% END %]" >
  • replacement in src/root/project.tt at line 30
    [2.302][2.302:547]()
    $(document).ready(function() {
    $('#show-hidden').on('click', function (e) {
    var show = !$(this).hasClass('active');
    if (show)
    $('tr.hidden-jobset').show();
    else
    $('tr.hidden-jobset').hide();
    [2.302]
    [2.547]
    function showJobsets() {
    var showHidden = $('#show-hidden').hasClass('active');
    var showDisabled = $('#show-disabled').hasClass('active');
    $('tr.jobset').map(function() {
    var hide =
    ($(this).hasClass('hidden-jobset') && !showHidden) ||
    ($(this).hasClass('disabled-jobset') && !showDisabled);
    if (hide) $(this).hide(); else $(this).show();
  • edit in src/root/project.tt at line 39
    [2.557]
    [2.557]
    return false;
    };
  • replacement in src/root/project.tt at line 42
    [2.558][2.558:774]()
    $('#show-disabled').on('click', function (e) {
    var show = !$(this).hasClass('active');
    if (show)
    $('tr.disabled-jobset').show();
    else
    $('tr.disabled-jobset').hide();
    [2.558]
    [2.774]
    $(document).ready(function() {
    $('#show-hidden, #show-disabled').on('click', function(e) {
    $(this).toggleClass('active');
    showJobsets();
    return false;
  • edit in src/root/project.tt at line 48
    [2.784]
    [2.784]
    showJobsets();
  • edit in src/root/static/css/hydra.css at line 48
    [3.523][2.1181:1222]()
    }
    tr.hidden-jobset {
    display: none;