perlcritic: don't open files as bare words

Dependencies

• [2] THUMRES3 hydra: add Coverity Scan plugin
• [3] I3S23ZI2 Fix registerRoot
• [4] O3NM62IZ Support multiple machines files
• [5] 3D3F5I74 Fix race between hydra-eval-jobs and hydra-update-gc-roots
• [6] 4LL3WLON Write Hydra roots as regular files instead of symlinks
• [7] MRJCQ4EO Don't use given/when
• [8] HTL6HIBM machine-status: Read /etc/nix.machines instead of using the BuildMachines table
• [9] F5RYSE7T qualify order by column
• [10] 4YCF3KBG Concurrent hydra-evaluator
• [11] 7I2U2MHU perlcritic: use strict, use warnings
• [12] KJQWSRCC Speed up hydra-update-gc-roots
• [13] A63IHCMX * Register GC roots properly.
• [14] IN272KZW * Automatically keep all builds in the latest successful release in
• [15] SZPBGW2N Fix a race condition in hydra-update-gc-roots
• [16] ACFFJUAN hydra-update-gc-roots: Keep more evals
• [17] NCYM2P3D Derivations with multiple outputs break the 'link name is store path' assumption
• [18] N74SRHS6 Remove the "releases" feature
• [19] UUWTUFAM CoverityScan: $b -> $build (perlcritic)
• [20] 2T42QGZD * Register builds as GC roots so they don't get deleted.
• [21] UGA45FNC Add a plugin for backing up builds in s3
• [*] 2GK5DOU7 * Downloading closures.
• [*] WZ3AEJ67 * hydra_update_gc_roots.pl registers build outputs that should be kept

Change contents

• replacement in src/lib/Hydra/Helper/Nix.pm at line 144
  [3.24]→[5.0:91](∅→∅),[5.968]→[5.0:91](∅→∅)
  − open ROOT, ">$link" or die "cannot create GC root `$link' to `$path'";

  − close ROOT;
  [3.24]

  [5.751]
  + open my $root, ">$link" or die "cannot create GC root `$link' to `$path'";

  + close $root;
• replacement in src/lib/Hydra/Helper/Nix.pm at line 344
  [4.2084]→[4.2084:2128](∅→∅),[4.2128]→[5.644:669](∅→∅),[5.644]→[5.644:669](∅→∅)
  − open CONF, "<$machinesFile" or die;

  − while (<CONF>) {
  [4.2084]

  [5.669]
  + open my $conf, "<$machinesFile" or die;

  + while (<$conf>) {
• replacement in src/lib/Hydra/Helper/Nix.pm at line 361
  [5.1350]→[5.1350:1370](∅→∅)
  − close CONF;
  [5.1350]

  [5.1370]
  + close $conf;
• replacement in src/lib/Hydra/Plugin/CoverityScan.pm at line 55
  [2.1517]→[2.1517:1588](∅→∅)
  − opendir TARBALLS, $tarballs or die;

  − while (readdir TARBALLS) {
  [2.1517]

  [2.1588]
  + opendir my $tarballs_handle, $tarballs or die;

  + while (readdir $tarballshandle) {
• replacement in src/lib/Hydra/Plugin/CoverityScan.pm at line 60
  [2.1707]→[2.1707:1730](∅→∅)
  − closedir TARBALLS;
  [2.1707]

  [2.1730]
  + closedir $tarballs_handle;
• replacement in src/script/hydra-s3-backup-collect-garbage at line 29
  [5.8345]→[5.8345:8417](∅→∅)
  − opendir DIR, $gcRootsDir or die;

  − my @roots = readdir DIR;

  − closedir DIR;
  [5.8345]

  [5.8417]
  + opendir my $dir, $gcRootsDir or die;

  + my @roots = readdir $dir;

  + closedir $dir;
• replacement in src/script/hydra-update-gc-roots at line 66
  [5.228]→[5.228:300](∅→∅)
  − opendir DIR, $gcRootsDir or die;

  − my @roots = readdir DIR;

  − closedir DIR;
  [5.228]

  [5.300]
  + opendir my $dir, $gcRootsDir or die;

  + my @roots = readdir $dir;

  + closedir $dir;
• replacement in t/s3-backup-test.pl at line 42
  [5.11440]→[5.11440:11494](∅→∅)
  − opendir DIR, $gcRootsDir or die;

  − while(readdir DIR) {
  [5.11440]

  [5.11494]
  + opendir my $dir, $gcRootsDir or die;

  + while(readdir $dir) {
• replacement in t/s3-backup-test.pl at line 47
  [5.11562]→[5.11562:11576](∅→∅)
  − closedir DIR;
  [5.11562]

  [5.11576]
  + closedir $dir;