GiteaStatus: $build -> $topbuild, $b -> $build (perlcritic)

[?]
Aug 21, 2021, 1:44 AM
NSSZSVR2R7IUOUUKWA3KVYBOPIO4VWQ4PUK7QQWLG46JT7DUPNQQC

Dependencies

  • [2] JFG4FYTW Implement simple status notifications for Git repos hosted on gitea
  • [3] 6SK7HL54 Make gitea public URL configurable
  • [4] ZLLMZMPO Fix error codes for GiteaStatus plugin

Change contents

  • replacement in src/lib/Hydra/Plugin/GiteaStatus.pm at line 32
    [2.1742][2.1742:1793]()
    my ($self, $build, $dependents, $status) = @_;
    [2.1742]
    [2.1793]
    my ($self, $topbuild, $dependents, $status) = @_;
  • replacement in src/lib/Hydra/Plugin/GiteaStatus.pm at line 36
    [2.1898][2.1898:2022]()
    foreach my $b ($build, @{$dependents}) {
    my $jobName = showJobName $b;
    my $evals = $build->jobsetevals;
    [2.1898]
    [2.2022]
    foreach my $build ($topbuild, @{$dependents}) {
    my $jobName = showJobName $build;
    my $evals = $topbuild->jobsetevals;
  • replacement in src/lib/Hydra/Plugin/GiteaStatus.pm at line 42
    [2.2154][2.2154:2204]()
    next if $status < 2 && $b->finished == 1;
    [2.2154]
    [2.2204]
    next if $status < 2 && $build->finished == 1;
  • replacement in src/lib/Hydra/Plugin/GiteaStatus.pm at line 44
    [2.2205][2.2205:2265]()
    my $state = toGiteaState($status, $b->buildstatus);
    [2.2205]
    [2.2265]
    my $state = toGiteaState($status, $build->buildstatus);
  • replacement in src/lib/Hydra/Plugin/GiteaStatus.pm at line 48
    [2.2344][2.2344:2537]()
    target_url => "$baseurl/build/" . $b->id,
    description => "Hydra build #" . $b->id . " of $jobName",
    context => "Hydra " . $b->get_column('job'),
    [2.2344]
    [2.2537]
    target_url => "$baseurl/build/" . $build->id,
    description => "Hydra build #" . $build->id . " of $jobName",
    context => "Hydra " . $build->get_column('job'),