More charset hackery

[?]
Aug 23, 2014, 2:39 PM
NYVW5G4OPE5XCNZQ6RTDYZOS2OSZC2VK6ONUMPKTC64H3WBQ63FAC

Dependencies

  • [2] 2MSFKTD5 Ensure proper encoding of error messages
  • [3] 2DHE2ZAK Allow Hydra to run as a private instance by requiring a login.
  • [4] AGQ2MGFE Clean up error handling
  • [5] LZVO64YG Merge in the first bits of the API work
  • [6] KYSBJAYN Allow dashes in jobset input names
  • [7] SMM4HQTP * Put actions related to builds under /build (e.g. /log/<buildid>
  • [8] NYC3LZKH * Generate NAR archives on the fly. Necessary for producing channels
  • [9] LSZLZHJY Allow users to edit their own settings
  • [10] J5UVLXOK * Start of a basic Catalyst web interface.
  • [11] 7G7QH3IT Set a 500 HTTP status on errors
  • [*] UAPS46BQ

Change contents

  • edit in src/lib/Hydra/Controller/Root.pm at line 24
    [3.213]
    [13.1]
  • edit in src/lib/Hydra/Controller/Root.pm at line 200
    [4.403][2.13:70]()
    my @errors = map { encode_utf8($_); } @{$c->error};
  • replacement in src/lib/Hydra/Controller/Root.pm at line 201
    [4.43][2.71:162]()
    if (scalar @errors) {
    $c->stash->{json}->{error} = join "\n", @errors;
    [4.43]
    [4.144]
    if (scalar @{$c->error}) {
    # FIXME: dunno why we need to do decode_utf8 here.
    $c->stash->{json}->{error} = join "\n", map { decode_utf8($_); } @{$c->error};
  • replacement in src/lib/Hydra/Controller/Root.pm at line 212
    [4.1669][2.163:204]()
    $c->stash->{errors} = [@errors];
    [4.1669]
    [4.0]
    $c->stash->{errors} = $c->error;