Enable setting checkresponsible in the edit jobset form

[?]
Oct 7, 2013, 2:46 PM
RQI3GRC6NSTPQMBTTOM37ITBZQIROTIGAIPDCVZ672TSEJVECB2AC

Dependencies

  • [2] ZFEN2MAO Simplify jobset cloning
  • [3] LZVO64YG Merge in the first bits of the API work
  • [4] ZCTQCN3E Use inputTypes from plugins to determine valid input types
  • [5] ODNCGFQ5 * Improved the navigation bar: don't include all projects (since that
  • [6] 2G63HKCH Fix some wellformedness issues
  • [7] OX6NYJDV Split viewing and editing a jobset
  • [8] VJFLX7B6 Fix rendering of jobset inputs
  • [9] TQVKZQUG Use the REST API in the web interface for editing jobsets
  • [10] UMFB2767 Hydra/64: Leaving number of builds empty gives DBIx error
  • [*] 3HZY24CX * Make jobsets viewable under

Change contents

  • replacement in src/lib/Hydra/Controller/Jobset.pm at line 232
    [3.1][2.693:778]()
    my $input = $jobset->jobsetinputs->create({ name => $name, type => $type });
    [3.1]
    [3.186]
    my $input = $jobset->jobsetinputs->create({
    name => $name,
    type => $type,
    checkresponsible => $c->stash->{params}->{"input-$baseName-checkresponsible"}
    });
  • edit in src/root/edit-jobset.tt at line 27
    [3.1668]
    [3.1668]
    </td>
    <td>
    <input type="checkbox" id="[% baseName %]-checkresponsible" name="[% baseName %]-checkresponsible" [% if input.checkresponsible; 'checked="checked"'; END %]/>
  • replacement in src/root/edit-jobset.tt at line 37
    [3.1788][3.1788:1851]()
    <tr><th>Input name</th><th>Type</th><th>Values</th></tr>
    [3.1788]
    [3.1851]
    <tr><th>Input name</th><th>Type</th><th>Values</th><th>Check for responsible commits?</tr>
  • replacement in src/root/edit-jobset.tt at line 44
    [3.2042][3.974:1149]()
    <td colspan="3" style="text-align: center;"><button type="button" class="add-input btn btn-success"><i class="icon-plus icon-white"></i> Add a new input</button></td>
    [3.2042]
    [3.2216]
    <td colspan="4" style="text-align: center;"><button type="button" class="add-input btn btn-success"><i class="icon-plus icon-white"></i> Add a new input</button></td>
  • edit in src/root/edit-jobset.tt at line 170
    [3.2399]
    [3.2399]
    $("#input-template-checkresponsible", x).attr("name", newid + "-checkresponsible");