restart/cancelBuilds: always pass resultsets explicitly

[?]
Oct 21, 2021, 1:34 PM
RXCJ5VEPMHWKB5KNZOFETVHLYN5VQRMUKZCYJCDOAFDFFDZYP3AQC

Dependencies

  • [2] VJKBXUEV allow users with 'restart-jobs' role to restart individual builds
  • [3] SGG4O42H perl: jobsetevals -> jobset via by jobset_id
  • [4] C7XPUHU6 JobsetEvals: fixup permission references
  • [5] RXSEJG7W Do not delete builds when clearing the queue. Fixes #8.
  • [6] DETQRBBR clear_queue_non_current: Don't use isCurrent
  • [7] YQFIBA4J Restart builds failed due to unsupported system type
  • [8] JO75HQLO Add a restart-jobs role
  • [9] B7IDAXTZ Admin controller: Use PathPart, not Path
  • [10] MOX7XJ2E Merge the BuildSchedulingInfo table into the Builds table
  • [11] A52HEFHQ * Allow builds to be restarted (if they failed with a transient error,
  • [12] GJFYEU3S * Nix now stores logs by default as bzip2, make sure the build page uncompresses before showing.
  • [13] ZILILXXK * Allow scheduled builds to be cancelled. They're not removed from
  • [14] UOINKJ2J Add an action to cancel all builds in a jobset eval
  • [15] VHV6GI4L Add a jobset eval action to restart all aborted/cancelled builds
  • [16] OSVLMLCQ hydra: factored out build restart and
  • [17] 67NFGL7D add links in admin page to clear queue (all non-running builds, and all non-running old (non-current) builds)
  • [18] KEBKLMYZ clear-queue-non-current: Work around PostgreSQL query optimizer stupidity
  • [19] GXRKOXQJ Add cancel-build role
  • [20] AR5EHCUF Add action to restart all failed builds in an eval
  • [21] LZVO64YG Merge in the first bits of the API work
  • [22] J6T5EF5N Fix cancelling non-current builds
  • [23] R6B5CAFF Let Builds.timestamp refer to the time the build was added
  • [*] ZWCTAZGL added newsitems, added some admin options to clear various caches.
  • [*] LBNVQXUB * Build the /build stuff in a separate controller.
  • [*] U4TD3AIQ Add support for viewing jobset evaluations

Change contents

  • replacement in src/lib/Hydra/Controller/Admin.pm at line 35
    [5.117][5.0:50]()
    my $builds = $c->model('DB::Builds')->search(
    [5.117]
    [3.0]
    my $builds = $c->model('DB::Builds')->search_rs(
  • replacement in src/lib/Hydra/Controller/Build.pm at line 490
    [2.51][5.0:107](),[5.230][5.0:107]()
    my $n = restartBuilds($c->model('DB')->schema, $c->model('DB::Builds')->search({ id => $build->id }));
    [2.51]
    [5.107]
    my $n = restartBuilds($c->model('DB')->schema, $c->model('DB::Builds')->search_rs({ id => $build->id }));
  • replacement in src/lib/Hydra/Controller/Build.pm at line 501
    [5.55][5.248:354](),[5.618][5.248:354]()
    my $n = cancelBuilds($c->model('DB')->schema, $c->model('DB::Builds')->search({ id => $build->id }));
    [5.55]
    [5.354]
    my $n = cancelBuilds($c->model('DB')->schema, $c->model('DB::Builds')->search_rs({ id => $build->id }));
  • replacement in src/lib/Hydra/Controller/JobsetEval.pm at line 156
    [5.62][5.52:150](),[4.117][5.52:150](),[5.436][5.52:150]()
    my $builds = $c->stash->{eval}->builds->search({ finished => 1, buildstatus => $condition });
    [4.117]
    [5.541]
    my $builds = $c->stash->{eval}->builds->search_rs({ finished => 1, buildstatus => $condition });