RunCommandLogs: add a did_succeed helper

[?]
Nov 18, 2021, 7:27 PM
RZBW3YWDH4BXCTSM4KW4MWBOD5QYATN6RK62IPESVXW2NNO3MEGAC

Dependencies

  • [2] CBU7KGFE Record the errno if exec fails
  • [*] 2GNJU4VF RunCommandLogs: init table
  • [*] VYS5RV7Y RunCommand: create run logs for each execution
  • [*] 3AKZKWCR RunCommand: Test

Change contents

  • edit in src/lib/Hydra/Schema/Result/RunCommandLogs.pm at line 230
    [5.2262]
    [5.2262]
    =head2 did_succeed
    Return:
    * true if the task ran and finished successfully,
    * false if the task did not run successfully but is completed
    * undef if the task has not yet run
    =cut
    sub did_succeed {
    my ($self) = @_;
  • edit in src/lib/Hydra/Schema/Result/RunCommandLogs.pm at line 243
    [5.2263]
    [5.2263]
    if (!defined($self->end_time)) {
    return undef;
    }
  • edit in src/lib/Hydra/Schema/Result/RunCommandLogs.pm at line 247
    [5.2264]
    [4.2945]
    if (!defined($self->exit_code)) {
    return 0;
    }
    return $self->exit_code == 0;
    }
  • edit in t/Schema/Result/RunCommandLogs.t at line 56
    [5.3884]
    [5.3884]
    is($runlog->did_succeed(), undef, "The process has not yet succeeded.");
  • edit in t/Schema/Result/RunCommandLogs.t at line 68
    [5.4390]
    [5.4390]
    ok($runlog->did_succeed(), "The process did succeed.");
  • edit in t/Schema/Result/RunCommandLogs.t at line 81
    [5.4965]
    [5.4965]
    ok(!$runlog->did_succeed(), "The process did not succeed.");
  • edit in t/Schema/Result/RunCommandLogs.t at line 94
    [5.5541]
    [5.5541]
    ok(!$runlog->did_succeed(), "The process did not succeed.");
  • edit in t/Schema/Result/RunCommandLogs.t at line 107
    [5.6092]
    [5.6092]
    ok(!$runlog->did_succeed(), "The process did not succeed.");
  • edit in t/plugins/RunCommand/basic.t at line 55
    [5.6672]
    [5.6672]
    ok($runlog->did_succeed(), "The process did succeed.");
  • edit in t/plugins/RunCommand/errno.t at line 42
    [2.1585]
    [2.1585]
    ok(!$runlog->did_succeed(), "The process did not succeed.");