{"header":{"message":"hydra-evaluator: add a 'ONE_AT_A_TIME' evaluator style","description":"In the past, jobsets which are automatically evaluated are evaluated\nregularly, on a schedule. This schedule means a new evaluation is\ncreated every checkInterval seconds (assuming something changed.)\n\nThis model works well for architectures where our build farm can\neasily keep up with demand.\n\nThis commit adds a new type of evaluation, called ONE_AT_A_TIME, which\nonly schedules a new evaluation if the previous evaluation of the\njobset has no unfinished builds.\n\nThis model of evaluation lets us have 'low-tier' architectures.\n\nFor example, we could now have a jobset for ARMv7l builds, where\nthe buildfarm only has a single, underpowered ARMv7l builder.\nConfiguring that jobset as ONE_AT_A_TIME will create an evaluation\nand then won't schedule another evaluation until every job of\nthe existing evaluation is complete.\n\nThis way, the cache will have a complete collection of pre-built\nsoftware for some commits, but the underpowered architecture will\nnever become backlogged in ancient revisions.","timestamp":"2020-03-04T00:53:18Z","authors":[{"email":"graham@grahamc.com","name":"Graham Christensen"}]},"hash":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC","authors":[],"deps":{"hashes":[["UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC","hydra-evaluator: add a 'ONE_AT_A_TIME' evaluator style"],["AA",null],["K6CGDFOTL2YODZPNT36RKQ3JW435323R52LLNWW4XELWR4JRDH3AC","hydra-evaluator: make the logic of the scheduler easier to read"],["2YXO5ZGQU6YB7M3JTJA6VAGK3L25R7CJ6HBF2EV4VYKA4JORHYDQC","Hydra/28: Rename \"scheduler\" to \"evaluator\""],["4YCF3KBGI4VYKHJXAREJLCJLY3UWB2FX447CJ4XQWFRKRFKG5WCQC","Concurrent hydra-evaluator"],["P6EWEJHLQBX4SIF2PQ5UW4XFLBF2V4MTKPQIL6DKMUELKGEW7U4QC","hydra-evaluator: Allow setting the maximum number of concurrent evaluations"],["ODNCGFQ5FPKFI624BVMLW7PJ2EFJOR3TY66OCZM42UNNTWBCF2TQC","* Improved the navigation bar: don't include all projects (since that"],["PCKLFRT5IZVLG47GQQ23GBSROKUR4CUEZW4PRVGREHNDFTCZ7VBAC","Support push notification of repository changes"],["C3AG65SWAGDSML5MBD4ZPRCHI2LNNDN6IQZOI3HLYRJRPAW3QPAAC","Add one-shot jobsets"],["KN3VYE5P2RJB3KZ355LA5C2T2D5S2IR3QZFE53AJIWUVMETEEYDAC","* Cleaned up the foreign key constraints."],["FYO6NECE4YJC76HQIG35NNJABODV7KNQKREK5YKZU6O2MNNSQTMAC","hydra"],["K22TMPH534XFKE6MWYRZSOCRWB7MCBKTMUBIBDF36FJR5DF5UE3AC","Make the info tables less compressed"],["OX6NYJDVCDX2UCJ4QQMTRJVZ535NOMCJGYCHDLCADJPQI7RMCXPQC","Split viewing and editing a jobset"],["W4G5MZZSCK7VGSZJQKLS6XMQPFDIL7D542XWDMFMO4RZEO4FQB2QC","hydra-evaluator improvements"],["AMI4DGBKDMQVDLEDZVMA3RGNNJU5CWSGVX5GIPH2BOK6VKQ4DGGAC","Don't trigger evaluation of disabled jobsets"],["3HZY24CX4U2TO74HOY4YX3LBJIYF4DLXHCIY7J2RASAC4COMSMZAC","* Make jobsets viewable under"],["N22GPKYTOLZLBGTGDATQDVZ4R5APZEAOIA7L32X4UXBH4XNI7MWAC","* Put info about logs / build products in the DB."]],"deps":["K6CGDFOTL2YODZPNT36RKQ3JW435323R52LLNWW4XELWR4JRDH3AC"],"known":["ODNCGFQ5FPKFI624BVMLW7PJ2EFJOR3TY66OCZM42UNNTWBCF2TQC","KN3VYE5P2RJB3KZ355LA5C2T2D5S2IR3QZFE53AJIWUVMETEEYDAC","FYO6NECE4YJC76HQIG35NNJABODV7KNQKREK5YKZU6O2MNNSQTMAC","2YXO5ZGQU6YB7M3JTJA6VAGK3L25R7CJ6HBF2EV4VYKA4JORHYDQC","OX6NYJDVCDX2UCJ4QQMTRJVZ535NOMCJGYCHDLCADJPQI7RMCXPQC","K22TMPH534XFKE6MWYRZSOCRWB7MCBKTMUBIBDF36FJR5DF5UE3AC","PCKLFRT5IZVLG47GQQ23GBSROKUR4CUEZW4PRVGREHNDFTCZ7VBAC","AMI4DGBKDMQVDLEDZVMA3RGNNJU5CWSGVX5GIPH2BOK6VKQ4DGGAC","C3AG65SWAGDSML5MBD4ZPRCHI2LNNDN6IQZOI3HLYRJRPAW3QPAAC","4YCF3KBGI4VYKHJXAREJLCJLY3UWB2FX447CJ4XQWFRKRFKG5WCQC","W4G5MZZSCK7VGSZJQKLS6XMQPFDIL7D542XWDMFMO4RZEO4FQB2QC","P6EWEJHLQBX4SIF2PQ5UW4XFLBF2V4MTKPQIL6DKMUELKGEW7U4QC"]},"hunks":[{"Edit":{"inode":{"change":3,"pos":575},"path":"src/hydra-evaluator/hydra-evaluator.cc","line":18,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":166}],"down_context":[{"change":3,"pos":761}],"flag":"BLOCK","start":0,"end":91,"inode":{"change":3,"pos":575}}},"contents":[{"Add":{"text":"enum class EvaluationStyle","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:26"}},{"Add":{"text":"{","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:28"}},{"Add":{"text":" SCHEDULE = 1,","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:46"}},{"Add":{"text":" ONESHOT = 2,","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:63"}},{"Add":{"text":" ONE_AT_A_TIME = 3,","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:86"}},{"Add":{"text":"};","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:89"}},{"Add":{"text":"","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:90"}}]}},{"Edit":{"inode":{"change":3,"pos":575},"path":"src/hydra-evaluator/hydra-evaluator.cc","line":34,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":925}],"down_context":[{"change":3,"pos":925}],"flag":"BLOCK","start":92,"end":149,"inode":{"change":3,"pos":575}}},"contents":[{"Add":{"text":" std::optional evaluation_style;","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:148"}}]}},{"Replacement":{"inode":{"change":3,"pos":575},"path":"src/hydra-evaluator/hydra-evaluator.cc","line":71,"ins":{"up_context":[{"change":3,"pos":1527}],"down_context":[{"change":3,"pos":1664}],"flag":"BLOCK","start":150,"end":316,"inode":{"change":3,"pos":575}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1527},"to":{"change":3,"start":1527,"end":1664},"introduced_by":3}],"inode":{"change":3,"pos":575}},"ins_contents":[{"Add":{"text":" (\"select project, j.name, lastCheckedTime, triggerTime, checkInterval, j.enabled as jobset_enabled from Jobsets j join Projects p on j.project = p.name \"","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:315"}}],"del_contents":[{"Del":{"text":" (\"select project, j.name, lastCheckedTime, triggerTime, checkInterval from Jobsets j join Projects p on j.project = p.name \"","pos":"4YCF3KBGI4VYKHJXAREJLCJLY3UWB2FX447CJ4XQWFRKRFKG5WCQC:1663"}}]}},{"Edit":{"inode":{"change":3,"pos":575},"path":"src/hydra-evaluator/hydra-evaluator.cc","line":89,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":2284}],"down_context":[{"change":3,"pos":2284}],"flag":"BLOCK","start":317,"end":763,"inode":{"change":3,"pos":575}}},"contents":[{"Add":{"text":" switch (row[\"jobset_enabled\"].as(0)) {","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:372"}},{"Add":{"text":" case 1:","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:396"}},{"Add":{"text":" jobset.evaluation_style = EvaluationStyle::SCHEDULE;","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:469"}},{"Add":{"text":" break;","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:496"}},{"Add":{"text":" case 2:","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:520"}},{"Add":{"text":" jobset.evaluation_style = EvaluationStyle::ONESHOT;","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:592"}},{"Add":{"text":" break;","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:619"}},{"Add":{"text":" case 3:","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:643"}},{"Add":{"text":" jobset.evaluation_style = EvaluationStyle::ONE_AT_A_TIME;","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:721"}},{"Add":{"text":" break;","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:748"}},{"Add":{"text":" }","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:762"}}]}},{"Edit":{"inode":{"change":3,"pos":575},"path":"src/hydra-evaluator/hydra-evaluator.cc","line":155,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":111}],"down_context":[{"change":2,"pos":111}],"flag":"BLOCK","start":764,"end":885,"inode":{"change":3,"pos":575}}},"contents":[{"Add":{"text":" debug(\"shouldEvaluate %s:%s? no: already running\",","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:826"}},{"Add":{"text":" jobset.name.first, jobset.name.second);","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:884"}}]}},{"Replacement":{"inode":{"change":3,"pos":575},"path":"src/hydra-evaluator/hydra-evaluator.cc","line":160,"ins":{"up_context":[{"change":2,"pos":148}],"down_context":[{"change":2,"pos":220}],"flag":"BLOCK","start":886,"end":958,"inode":{"change":3,"pos":575}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":148},"to":{"change":2,"start":148,"end":220},"introduced_by":2}],"inode":{"change":3,"pos":575}},"ins_contents":[{"Add":{"text":" if (jobset.triggerTime != std::numeric_limits::max()) {","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:957"}}],"del_contents":[{"Del":{"text":" if (jobset.triggerTime == std::numeric_limits::max()) {","pos":"K6CGDFOTL2YODZPNT36RKQ3JW435323R52LLNWW4XELWR4JRDH3AC:219"}}]}},{"Edit":{"inode":{"change":3,"pos":575},"path":"src/hydra-evaluator/hydra-evaluator.cc","line":162,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":277}],"down_context":[{"change":2,"pos":277}],"flag":"BLOCK","start":959,"end":1075,"inode":{"change":3,"pos":575}}},"contents":[{"Add":{"text":" debug(\"shouldEvaluate %s:%s? yes: requested\",","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:1016"}},{"Add":{"text":" jobset.name.first, jobset.name.second);","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:1074"}}]}},{"Edit":{"inode":{"change":3,"pos":575},"path":"src/hydra-evaluator/hydra-evaluator.cc","line":170,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":480}],"down_context":[{"change":2,"pos":480}],"flag":"BLOCK","start":1076,"end":1200,"inode":{"change":3,"pos":575}}},"contents":[{"Add":{"text":" debug(\"shouldEvaluate %s:%s? no: checkInterval <= 0\",","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:1141"}},{"Add":{"text":" jobset.name.first, jobset.name.second);","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:1199"}}]}},{"Edit":{"inode":{"change":3,"pos":575},"path":"src/hydra-evaluator/hydra-evaluator.cc","line":174,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":516}],"down_context":[{"change":2,"pos":516}],"flag":"BLOCK","start":1201,"end":1497,"inode":{"change":3,"pos":575}}},"contents":[{"Add":{"text":"","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:1201"}},{"Add":{"text":" if (jobset.lastCheckedTime + jobset.checkInterval <= time(0)) {","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:1273"}},{"Add":{"text":" // Time to schedule a fresh evaluation. If the jobset","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:1339"}},{"Add":{"text":" // is a ONE_AT_A_TIME jobset, ensure the previous jobset","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:1408"}},{"Add":{"text":" // has no remaining, unfinished work.","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:1458"}},{"Add":{"text":"","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:1459"}},{"Add":{"text":" auto conn(dbPool.get());","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:1496"}}]}},{"Edit":{"inode":{"change":3,"pos":575},"path":"src/hydra-evaluator/hydra-evaluator.cc","line":182,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":517}],"down_context":[{"change":2,"pos":517}],"flag":"BLOCK","start":1498,"end":1533,"inode":{"change":3,"pos":575}}},"contents":[{"Add":{"text":" pqxx::work txn(*conn);","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:1532"}}]}},{"Replacement":{"inode":{"change":3,"pos":575},"path":"src/hydra-evaluator/hydra-evaluator.cc","line":184,"ins":{"up_context":[{"change":2,"pos":518}],"down_context":[{"change":2,"pos":666}],"flag":"BLOCK","start":1534,"end":3619,"inode":{"change":3,"pos":575}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":518},"to":{"change":2,"start":518,"end":666},"introduced_by":2}],"inode":{"change":3,"pos":575}},"ins_contents":[{"Add":{"text":" if (jobset.evaluation_style == EvaluationStyle::ONE_AT_A_TIME) {","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:1610"}},{"Add":{"text":" auto evaluation_res = txn.parameterized","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:1666"}},{"Add":{"text":" (\"select id from JobsetEvals \"","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:1717"}},{"Add":{"text":" \"where project = $1 and jobset = $2 \"","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:1776"}},{"Add":{"text":" \"order by id desc limit 1\")","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:1825"}},{"Add":{"text":" (jobset.name.first)","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:1863"}},{"Add":{"text":" (jobset.name.second)","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:1902"}},{"Add":{"text":" .exec();","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:1929"}},{"Add":{"text":"","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:1930"}},{"Add":{"text":" if (evaluation_res.empty()) {","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:1976"}},{"Add":{"text":" // First evaluation, so allow scheduling.","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:2038"}},{"Add":{"text":" debug(\"shouldEvaluate(one-at-a-time) %s:%s? yes: no prior eval\",","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:2123"}},{"Add":{"text":" jobset.name.first, jobset.name.second);","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:2189"}},{"Add":{"text":" return true;","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:2222"}},{"Add":{"text":" }","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:2240"}},{"Add":{"text":"","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:2241"}},{"Add":{"text":" auto evaluation_id = evaluation_res[0][0].as();","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:2310"}},{"Add":{"text":"","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:2311"}},{"Add":{"text":" auto unfinished_build_res = txn.parameterized","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:2373"}},{"Add":{"text":" (\"select id from Builds \"","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:2419"}},{"Add":{"text":" \"join JobsetEvalMembers \"","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:2466"}},{"Add":{"text":" \" on (JobsetEvalMembers.build = Builds.id) \"","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:2535"}},{"Add":{"text":" \"where JobsetEvalMembers.eval = $1 \"","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:2593"}},{"Add":{"text":" \" and builds.finished = 0 \"","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:2643"}},{"Add":{"text":" \" limit 1\")","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:2676"}},{"Add":{"text":" (evaluation_id)","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:2710"}},{"Add":{"text":" .exec();","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:2737"}},{"Add":{"text":"","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:2738"}},{"Add":{"text":" // If the previous evaluation has no unfinished builds","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:2809"}},{"Add":{"text":" // schedule!","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:2838"}},{"Add":{"text":" if (unfinished_build_res.empty()) {","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:2890"}},{"Add":{"text":" debug(\"shouldEvaluate(one-at-a-time) %s:%s? yes: no unfinished builds\",","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:2982"}},{"Add":{"text":" jobset.name.first, jobset.name.second);","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:3048"}},{"Add":{"text":" return true;","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:3081"}},{"Add":{"text":" } else {","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:3106"}},{"Add":{"text":" debug(\"shouldEvaluate(one-at-a-time) %s:%s? no: at least one unfinished build\",","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:3206"}},{"Add":{"text":" jobset.name.first, jobset.name.second);","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:3273"}},{"Add":{"text":" return false;","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:3307"}},{"Add":{"text":" }","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:3325"}},{"Add":{"text":"","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:3326"}},{"Add":{"text":"","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:3327"}},{"Add":{"text":" } else {","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:3348"}},{"Add":{"text":" // EvaluationStyle::ONESHOT, EvaluationStyle::SCHEDULED","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:3420"}},{"Add":{"text":" debug(\"shouldEvaluate(oneshot/scheduled) %s:%s? yes: checkInterval elapsed\",","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:3513"}},{"Add":{"text":" jobset.name.first, jobset.name.second);","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:3575"}},{"Add":{"text":" return true;","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:3604"}},{"Add":{"text":" }","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:3618"}}],"del_contents":[{"Del":{"text":" if (jobset.lastCheckedTime + jobset.checkInterval <= time(0)) {","pos":"K6CGDFOTL2YODZPNT36RKQ3JW435323R52LLNWW4XELWR4JRDH3AC:589"}},{"Del":{"text":" // Time to schedule a fresh evaluation","pos":"K6CGDFOTL2YODZPNT36RKQ3JW435323R52LLNWW4XELWR4JRDH3AC:640"}},{"Del":{"text":" return true;","pos":"K6CGDFOTL2YODZPNT36RKQ3JW435323R52LLNWW4XELWR4JRDH3AC:665"}}]}},{"Replacement":{"inode":{"change":16,"pos":104},"path":"src/lib/Hydra/Controller/Jobset.pm","line":229,"ins":{"up_context":[{"change":3,"pos":108}],"down_context":[{"change":3,"pos":2074}],"flag":"BLOCK","start":3620,"end":3661,"inode":{"change":16,"pos":104}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":108},"to":{"change":3,"start":108,"end":149},"introduced_by":3}],"inode":{"change":16,"pos":104}},"ins_contents":[{"Add":{"text":" die if $enabled < 0 || $enabled > 3;","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:3660"}}],"del_contents":[{"Del":{"text":" die if $enabled < 0 || $enabled > 2;","pos":"C3AG65SWAGDSML5MBD4ZPRCHI2LNNDN6IQZOI3HLYRJRPAW3QPAAC:148"}}]}},{"Edit":{"inode":{"change":3,"pos":367},"path":"src/root/edit-jobset.tt","line":71,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":684}],"down_context":[{"change":3,"pos":684}],"flag":"BLOCK","start":3662,"end":3739,"inode":{"change":3,"pos":367}}},"contents":[{"Add":{"text":" ","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:3738"}}]}},{"Replacement":{"inode":{"change":3,"pos":8409},"path":"src/root/jobset.tt","line":132,"ins":{"up_context":[{"change":3,"pos":852}],"down_context":[{"change":3,"pos":992}],"flag":"BLOCK","start":3740,"end":3924,"inode":{"change":3,"pos":8409}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":852},"to":{"change":3,"start":852,"end":992},"introduced_by":3}],"inode":{"change":3,"pos":8409}},"ins_contents":[{"Add":{"text":" [% IF jobset.enabled == 0; \"Disabled\"; ELSIF jobset.enabled == 1; \"Enabled\"; ELSIF jobset.enabled == 2; \"One-shot\"; ELSIF jobset.enabled == 3; \"One-at-a-time\"; END %]","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:3923"}}],"del_contents":[{"Del":{"text":" [% IF jobset.enabled == 0; \"Disabled\"; ELSIF jobset.enabled == 1; \"Enabled\"; ELSIF jobset.enabled == 2; \"One-shot\"; END %]","pos":"C3AG65SWAGDSML5MBD4ZPRCHI2LNNDN6IQZOI3HLYRJRPAW3QPAAC:991"}}]}},{"Replacement":{"inode":{"change":17,"pos":1},"path":"src/sql/hydra.sql","line":64,"ins":{"up_context":[{"change":3,"pos":3384}],"down_context":[{"change":3,"pos":5089}],"flag":"BLOCK","start":3925,"end":4033,"inode":{"change":17,"pos":1}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3384},"to":{"change":3,"start":1675,"end":1764},"introduced_by":3}],"inode":{"change":17,"pos":1}},"ins_contents":[{"Add":{"text":" enabled integer not null default 1, -- 0 = disabled, 1 = enabled, 2 = one-shot, 3 = one-at-a-time","pos":"UANT7MOVK62YKFDQ5AJU2XETFKPUAEMJ4WJPRNJ7OJXN2E6DOFLQC:4032"}}],"del_contents":[{"Del":{"text":" enabled integer not null default 1, -- 0 = disabled, 1 = enabled, 2 = one-shot","pos":"C3AG65SWAGDSML5MBD4ZPRCHI2LNNDN6IQZOI3HLYRJRPAW3QPAAC:1763"}}]}}],"owner":"grahamc","repo":"hydra","token":"eY0v4nwaFPHPC7xtDxUqXkNE9jbWz1qAK0iaautmKaI=","login":null}

…

Dependencies

Change contents

Review