GitlabStatus: $build -> $topbuild, $b -> $build (perlcritic)

[?]
Aug 21, 2021, 1:40 AM
XXCNIG3GTOEB6PMTZX2WTYN5OJ5T5XXBRH64CR2IVDWXCQJQENEQC

Dependencies

  • [2] 6HWIUOSU Avoid fetching Projects/Jobsets just to get the name column
  • [3] YXU6JABK Create a gitlab status plugin
  • [4] 5WNGKHLZ Plugins: Add isEnabled method

Change contents

  • replacement in src/lib/Hydra/Plugin/GitlabStatus.pm at line 40
    [3.1066][3.1066:1117]()
    my ($self, $build, $dependents, $status) = @_;
    [3.1066]
    [3.1117]
    my ($self, $topbuild, $dependents, $status) = @_;
  • replacement in src/lib/Hydra/Plugin/GitlabStatus.pm at line 44
    [3.1222][3.1222:1346]()
    foreach my $b ($build, @{$dependents}) {
    my $jobName = showJobName $b;
    my $evals = $build->jobsetevals;
    [3.1222]
    [3.1346]
    foreach my $build ($topbuild, @{$dependents}) {
    my $jobName = showJobName $build;
    my $evals = $topbuild->jobsetevals;
  • replacement in src/lib/Hydra/Plugin/GitlabStatus.pm at line 50
    [3.1478][3.1478:1528]()
    next if $status < 2 && $b->finished == 1;
    [3.1478]
    [3.1528]
    next if $status < 2 && $build->finished == 1;
  • replacement in src/lib/Hydra/Plugin/GitlabStatus.pm at line 52
    [3.1529][3.1529:1590]()
    my $state = toGitlabState($status, $b->buildstatus);
    [3.1529]
    [3.1590]
    my $state = toGitlabState($status, $build->buildstatus);
  • replacement in src/lib/Hydra/Plugin/GitlabStatus.pm at line 56
    [3.1669][3.1669:1801](),[3.1801][2.1027:1085]()
    target_url => "$baseurl/build/" . $b->id,
    description => "Hydra build #" . $b->id . " of $jobName",
    name => "Hydra " . $b->get_column('job'),
    [3.1669]
    [3.1851]
    target_url => "$baseurl/build/" . $build->id,
    description => "Hydra build #" . $build->id . " of $jobName",
    name => "Hydra " . $build->get_column('job'),