clean up build page for build that failed with result

[?]
Jun 10, 2011, 7:36 AM
ZEEZRG2ELCFZRPLUGSFZEMT43MEMWIM7TTC7PMMGTMKQ4F2OGSFAC

Dependencies

  • [2] V62IBGJV * Cannot call isValidPath on a logfile. This happened to work because
  • [3] KJOGCBGZ hydra: current build -> this build
  • [4] 22JB5HNE make changes section more compact/readable
  • [5] CEARA7OH * hydra: show running buildsteps on build page
  • [6] LQNG45RT hydra: description at changes section
  • [7] ZNKPGZHF hydra: error on buildpage for queued build
  • [8] BIZEPF2T ignore this
  • [9] ZI535LI6 * hydra: 'new' UI for project/jobset/job/build
  • [10] TW5ZQX5Z * Move up the build products in the builds page, since they're more
  • [11] JBUTIGW7 hydra: description at changes section
  • [12] NZI7E2E3 * hydra: handle case where logfile is empty
  • [13] XHK7IGYI * hdyra: show last succeeded build and changes since on build status summary if build has failed
  • [*] LBNVQXUB * Build the /build stuff in a separate controller.
  • [*] J5UVLXOK * Start of a basic Catalyst web interface.

Change contents

  • replacement in src/lib/Hydra/Controller/Build.pm at line 57
    [4.71][2.0:126]()
    if (defined $build->resultInfo && $build->resultInfo->buildstatus == 1 && !($path eq "") && -f $lastBuildStep->logfile) {
    [4.71]
    [4.207]
    if (defined $build->resultInfo && ($build->resultInfo->buildstatus == 1 || $build->resultInfo->buildstatus == 6) && !($path eq "") && -f $lastBuildStep->logfile) {
  • replacement in src/root/build.tt at line 183
    [4.6726][4.59:125]()
    [% IF build.buildsteps && build.resultInfo.buildstatus != 0 %]
    [4.6726]
    [4.289]
    [% IF build.buildsteps && build.resultInfo.buildstatus != 0 && build.resultInfo.buildstatus != 6 %]
  • replacement in src/root/build.tt at line 193
    [4.73][4.73:264](),[4.264][3.0:40]()
    <th>Last successful build</th>
    [% IF prevSuccessfulBuild && firstBrokenBuild && firstBrokenBuild.id != build.id %]<th>First broken build</th>[% END %]
    <th>This build</th>
    [4.73]
    [4.307]
    <th>Last successful build <tt>[% INCLUDE renderDateTime timestamp = prevSuccessfulBuild.timestamp %]</tt></th>
    [% IF prevSuccessfulBuild && firstBrokenBuild && firstBrokenBuild.id != build.id %]<th>First broken build <tt>[% INCLUDE renderDateTime timestamp = firstBrokenBuild.timestamp %]</tt></th>[% END %]
    <th>This build <tt>[% INCLUDE renderDateTime timestamp = build.timestamp %]</tt></th>