{"header":{"message":"Make jobset deletion consistent with project deletion","description":null,"timestamp":"2013-02-26T16:36:49Z","authors":[{"email":"eelco.dolstra@logicblox.com","name":"Eelco Dolstra"}]},"hash":"ZRRPBEI4ZSISCMWV62JGB35QNRJVA7SZUR4F52WTQRECCG2GCEAQC","authors":[],"deps":{"hashes":[["ZRRPBEI4ZSISCMWV62JGB35QNRJVA7SZUR4F52WTQRECCG2GCEAQC","Make jobset deletion consistent with project deletion"],["AA",null],["TNMOG2ZQTXJJ6TEPEDB6D4XPIIGMAV3DUDWO33WD23CGDVT4LO2QC","Indentation"],["OX6NYJDVCDX2UCJ4QQMTRJVZ535NOMCJGYCHDLCADJPQI7RMCXPQC","Split viewing and editing a jobset"],["7ZQAHJQMEEREYP3PZAPO5JUMEDX4CNNJCCHTFQNEPOZZUJCIOVHQC","Fix indentation"],["UMFB2767NMAG46NAG3XHMYQMCLF5TMVN46SST4AM2CFUEMNZH3WQC","Hydra/64: Leaving number of builds empty gives DBIx error"],["FPK5LF53CFUEKFYJ3IYXT4UTVC6IITWJOCFATMC4PLHEUP5SIEAAC","* Put the project-related actions in a separate controller. Put the"],["QTFVCDIFHTF36AGU4UGNCTWSHQYTM2KERXS26TPAJK7IDJHL7BVAC","added hide feature for project/jobset"],["JARRBLZDQ2JZWY7IUVPTOT7WJMBPMLFLF2MGLVGOYROAAISYGLSAC","Bootstrapify the Hydra forms (except the project and jobset edit pages)"],["YG6VGK4F7YIQYXUFQQZYPXS4ABL2X47FTPB5RNIIP4BCWM3UHOBAC","\"Evaluate\" command: push the jobset to the front of the eval queue"],["PVIRRARJJC2Z3PYC6XPHJUZPT5IS4IKXUUDGMXXV57PFVVFCUUMAC","Turn hiding/unhiding a jobset into a checkbox"],["OEPUOUNBNTHTFZVDXREGBQCKFRCWMVP2MDVK4OA47VK2DBKEWVYAC","Using twitter bootstrap for more consistent looks for Hydra"],["I4K2UPCWTK4EEPPQYBZ6UEGLF2HIUR5X6GJH34JEKPVKRBVWFCVAC","Tweaks"],["ODNCGFQ5FPKFI624BVMLW7PJ2EFJOR3TY66OCZM42UNNTWBCF2TQC","* Improved the navigation bar: don't include all projects (since that"],["OOQ2D3KCLFPYNAN253PHWLBQMB6OMO2KYQWQXLTP65SQAYZWQ5LAC","* Refactoring: move fetchInput out of hydra_scheduler into a separate"],["3PNG7NIBQQURUUPRVQXYL342OT7JUUYOMY2JJNP6YDX7SYJDZMYAC","Remove trailing whitespace"],["LZO3C2KIACZ3HN72RBGWWIT5ED4RJMYKI3SAHXT6RIUPHDFL3STQC","* Hack around those SQLite timeouts: just retry the transaction."],["TLJC6BJ3W4IGAKOG65VHAR2YICD63W3VELJBBWTIKDJ7FCMFAUPAC","Add a menu item for deleting jobsets"],["3HZY24CX4U2TO74HOY4YX3LBJIYF4DLXHCIY7J2RASAC4COMSMZAC","* Make jobsets viewable under"],["QL55ECJ6KMMBUOWQ6LKSOVN7L43CH4S6SPE2AQ3VX3KSGC32RP4AC","- adapted ui for hydra, more in line with nixos.org website"]],"deps":["TNMOG2ZQTXJJ6TEPEDB6D4XPIIGMAV3DUDWO33WD23CGDVT4LO2QC","OX6NYJDVCDX2UCJ4QQMTRJVZ535NOMCJGYCHDLCADJPQI7RMCXPQC"],"known":["FPK5LF53CFUEKFYJ3IYXT4UTVC6IITWJOCFATMC4PLHEUP5SIEAAC","ODNCGFQ5FPKFI624BVMLW7PJ2EFJOR3TY66OCZM42UNNTWBCF2TQC","LZO3C2KIACZ3HN72RBGWWIT5ED4RJMYKI3SAHXT6RIUPHDFL3STQC","OOQ2D3KCLFPYNAN253PHWLBQMB6OMO2KYQWQXLTP65SQAYZWQ5LAC","QTFVCDIFHTF36AGU4UGNCTWSHQYTM2KERXS26TPAJK7IDJHL7BVAC","UMFB2767NMAG46NAG3XHMYQMCLF5TMVN46SST4AM2CFUEMNZH3WQC","OEPUOUNBNTHTFZVDXREGBQCKFRCWMVP2MDVK4OA47VK2DBKEWVYAC","JARRBLZDQ2JZWY7IUVPTOT7WJMBPMLFLF2MGLVGOYROAAISYGLSAC","3PNG7NIBQQURUUPRVQXYL342OT7JUUYOMY2JJNP6YDX7SYJDZMYAC","7ZQAHJQMEEREYP3PZAPO5JUMEDX4CNNJCCHTFQNEPOZZUJCIOVHQC","TLJC6BJ3W4IGAKOG65VHAR2YICD63W3VELJBBWTIKDJ7FCMFAUPAC","I4K2UPCWTK4EEPPQYBZ6UEGLF2HIUR5X6GJH34JEKPVKRBVWFCVAC","PVIRRARJJC2Z3PYC6XPHJUZPT5IS4IKXUUDGMXXV57PFVVFCUUMAC","YG6VGK4F7YIQYXUFQQZYPXS4ABL2X47FTPB5RNIIP4BCWM3UHOBAC"]},"hunks":[{"Edit":{"inode":{"change":19,"pos":104},"path":"src/lib/Hydra/Controller/Jobset.pm","line":133,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":861}],"down_context":[{"change":4,"pos":16}],"flag":"BLOCK","start":0,"end":229,"inode":{"change":19,"pos":104}}},"contents":[{"Add":{"text":"","pos":"ZRRPBEI4ZSISCMWV62JGB35QNRJVA7SZUR4F52WTQRECCG2GCEAQC:0"}},{"Add":{"text":" if (($c->request->params->{submit} // \"\") eq \"delete\") {","pos":"ZRRPBEI4ZSISCMWV62JGB35QNRJVA7SZUR4F52WTQRECCG2GCEAQC:61"}},{"Add":{"text":" $c->stash->{jobset}->delete;","pos":"ZRRPBEI4ZSISCMWV62JGB35QNRJVA7SZUR4F52WTQRECCG2GCEAQC:98"}},{"Add":{"text":" return $c->res->redirect($c->uri_for($c->controller('Project')->action_for(\"view\"), [$c->stash->{project}->name]));","pos":"ZRRPBEI4ZSISCMWV62JGB35QNRJVA7SZUR4F52WTQRECCG2GCEAQC:222"}},{"Add":{"text":" }","pos":"ZRRPBEI4ZSISCMWV62JGB35QNRJVA7SZUR4F52WTQRECCG2GCEAQC:228"}}]}},{"Edit":{"inode":{"change":19,"pos":104},"path":"src/lib/Hydra/Controller/Jobset.pm","line":145,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":1093},"to":{"change":4,"start":0,"end":2},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":77},"to":{"change":4,"start":77,"end":78},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":129},"to":{"change":4,"start":18,"end":19},"introduced_by":4},{"previous":"","flag":"DELETED","from":{"change":2,"pos":137},"to":{"change":4,"start":1097,"end":1245},"introduced_by":2},{"previous":"","flag":"DELETED","from":{"change":4,"pos":744},"to":{"change":4,"start":1097,"end":1245},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":1097},"to":{"change":4,"start":1097,"end":1245},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":1245},"to":{"change":4,"start":26,"end":27},"introduced_by":4},{"previous":"","flag":"DELETED","from":{"change":4,"pos":27},"to":{"change":4,"start":172,"end":214},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":1250},"to":{"change":4,"start":172,"end":214},"introduced_by":4},{"previous":"","flag":"DELETED","from":{"change":4,"pos":214},"to":{"change":4,"start":1292,"end":1337},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":1292},"to":{"change":4,"start":1292,"end":1337},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":1337},"to":{"change":4,"start":28,"end":29},"introduced_by":4},{"previous":"","flag":"DELETED","from":{"change":4,"pos":29},"to":{"change":4,"start":1342,"end":1463},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":1342},"to":{"change":4,"start":1342,"end":1463},"introduced_by":4}],"inode":{"change":19,"pos":104}}},"contents":[{"Del":{"text":"}","pos":"QTFVCDIFHTF36AGU4UGNCTWSHQYTM2KERXS26TPAJK7IDJHL7BVAC:1"}},{"Del":{"text":"","pos":"QTFVCDIFHTF36AGU4UGNCTWSHQYTM2KERXS26TPAJK7IDJHL7BVAC:77"}},{"Del":{"text":"","pos":"UMFB2767NMAG46NAG3XHMYQMCLF5TMVN46SST4AM2CFUEMNZH3WQC:18"}},{"Del":{"text":"sub delete : Chained('jobset') PathPart Args(0) {","pos":"ODNCGFQ5FPKFI624BVMLW7PJ2EFJOR3TY66OCZM42UNNTWBCF2TQC:1146"}},{"Del":{"text":" my ($self, $c) = @_;","pos":"ODNCGFQ5FPKFI624BVMLW7PJ2EFJOR3TY66OCZM42UNNTWBCF2TQC:1171"}},{"Del":{"text":"","pos":"ODNCGFQ5FPKFI624BVMLW7PJ2EFJOR3TY66OCZM42UNNTWBCF2TQC:1172"}},{"Del":{"text":" requireProjectOwner($c, $c->stash->{project});","pos":"ODNCGFQ5FPKFI624BVMLW7PJ2EFJOR3TY66OCZM42UNNTWBCF2TQC:1223"}},{"Del":{"text":" requirePost($c);","pos":"ODNCGFQ5FPKFI624BVMLW7PJ2EFJOR3TY66OCZM42UNNTWBCF2TQC:1244"}},{"Del":{"text":"","pos":"UMFB2767NMAG46NAG3XHMYQMCLF5TMVN46SST4AM2CFUEMNZH3WQC:26"}},{"Del":{"text":" txn_do($c->model('DB')->schema, sub {","pos":"LZO3C2KIACZ3HN72RBGWWIT5ED4RJMYKI3SAHXT6RIUPHDFL3STQC:213"}},{"Del":{"text":" $c->stash->{jobset}->delete;","pos":"ODNCGFQ5FPKFI624BVMLW7PJ2EFJOR3TY66OCZM42UNNTWBCF2TQC:1328"}},{"Del":{"text":" });","pos":"ODNCGFQ5FPKFI624BVMLW7PJ2EFJOR3TY66OCZM42UNNTWBCF2TQC:1336"}},{"Del":{"text":"","pos":"UMFB2767NMAG46NAG3XHMYQMCLF5TMVN46SST4AM2CFUEMNZH3WQC:28"}},{"Del":{"text":" $c->res->redirect($c->uri_for($c->controller('Project')->action_for(\"view\"),","pos":"ODNCGFQ5FPKFI624BVMLW7PJ2EFJOR3TY66OCZM42UNNTWBCF2TQC:1422"}},{"Del":{"text":" [$c->stash->{project}->name]));","pos":"ODNCGFQ5FPKFI624BVMLW7PJ2EFJOR3TY66OCZM42UNNTWBCF2TQC:1462"}}]}},{"Replacement":{"inode":{"change":4,"pos":1245},"path":"src/lib/Hydra/Controller/Project.pm","line":48,"ins":{"up_context":[{"change":4,"pos":2217}],"down_context":[{"change":4,"pos":702}],"flag":"BLOCK","start":230,"end":291,"inode":{"change":4,"pos":1245}},"del":{"edges":[{"previous":"","flag":"DELETED","from":{"change":4,"pos":2217},"to":{"change":4,"start":641,"end":702},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":2361},"to":{"change":4,"start":641,"end":702},"introduced_by":4}],"inode":{"change":4,"pos":1245}},"ins_contents":[{"Add":{"text":" if (($c->request->params->{submit} // \"\") eq \"delete\") {","pos":"ZRRPBEI4ZSISCMWV62JGB35QNRJVA7SZUR4F52WTQRECCG2GCEAQC:290"}}],"del_contents":[{"Del":{"text":" if (($c->request->params->{submit} || \"\") eq \"delete\") {","pos":"JARRBLZDQ2JZWY7IUVPTOT7WJMBPMLFLF2MGLVGOYROAAISYGLSAC:701"}}]}},{"Replacement":{"inode":{"change":4,"pos":1245},"path":"src/lib/Hydra/Controller/Project.pm","line":50,"ins":{"up_context":[{"change":4,"pos":740}],"down_context":[{"change":4,"pos":785}],"flag":"BLOCK","start":292,"end":344,"inode":{"change":4,"pos":1245}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":740},"to":{"change":4,"start":740,"end":785},"introduced_by":4}],"inode":{"change":4,"pos":1245}},"ins_contents":[{"Add":{"text":" return $c->res->redirect($c->uri_for(\"/\"));","pos":"ZRRPBEI4ZSISCMWV62JGB35QNRJVA7SZUR4F52WTQRECCG2GCEAQC:343"}}],"del_contents":[{"Del":{"text":" $c->res->redirect($c->uri_for(\"/\"));","pos":"JARRBLZDQ2JZWY7IUVPTOT7WJMBPMLFLF2MGLVGOYROAAISYGLSAC:784"}}]}},{"Edit":{"inode":{"change":3,"pos":367},"path":"src/root/edit-jobset.tt","line":112,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":4659}],"down_context":[{"change":3,"pos":4659}],"flag":"BLOCK","start":345,"end":779,"inode":{"change":3,"pos":367}}},"contents":[{"Add":{"text":"","pos":"ZRRPBEI4ZSISCMWV62JGB35QNRJVA7SZUR4F52WTQRECCG2GCEAQC:345"}},{"Add":{"text":" [% IF !create %]","pos":"ZRRPBEI4ZSISCMWV62JGB35QNRJVA7SZUR4F52WTQRECCG2GCEAQC:368"}},{"Add":{"text":" ","pos":"ZRRPBEI4ZSISCMWV62JGB35QNRJVA7SZUR4F52WTQRECCG2GCEAQC:565"}},{"Add":{"text":" ","pos":"ZRRPBEI4ZSISCMWV62JGB35QNRJVA7SZUR4F52WTQRECCG2GCEAQC:762"}},{"Add":{"text":" [% END %]","pos":"ZRRPBEI4ZSISCMWV62JGB35QNRJVA7SZUR4F52WTQRECCG2GCEAQC:778"}}]}},{"Edit":{"inode":{"change":20,"pos":6671},"path":"src/root/topbar.tt","line":85,"atom":{"EdgeMap":{"edges":[{"previous":"","flag":"DELETED","from":{"change":4,"pos":427},"to":{"change":4,"start":6049,"end":6553},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":6049},"to":{"change":4,"start":6049,"end":6553},"introduced_by":4}],"inode":{"change":20,"pos":6671}}},"contents":[{"Del":{"text":"","pos":"TLJC6BJ3W4IGAKOG65VHAR2YICD63W3VELJBBWTIKDJ7FCMFAUPAC:6049"}},{"Del":{"text":" ","pos":"TLJC6BJ3W4IGAKOG65VHAR2YICD63W3VELJBBWTIKDJ7FCMFAUPAC:6189"}},{"Del":{"text":" ","pos":"TLJC6BJ3W4IGAKOG65VHAR2YICD63W3VELJBBWTIKDJ7FCMFAUPAC:6464"}},{"Del":{"text":" [% INCLUDE menuItem title=\"Delete\" uri = \"javascript:confirmDeleteJobset()\" %]","pos":"TLJC6BJ3W4IGAKOG65VHAR2YICD63W3VELJBBWTIKDJ7FCMFAUPAC:6551"}},{"Del":{"text":"","pos":"TLJC6BJ3W4IGAKOG65VHAR2YICD63W3VELJBBWTIKDJ7FCMFAUPAC:6552"}}]}}],"owner":"grahamc","repo":"hydra","token":"LrI1kBZQcQdCW3XzIDz3lqM2YOe0k3F9F44dc5JAlkA=","login":null}

…

Dependencies

Change contents

Review