grahamc/hydra - Change 37R34XJOGMP3E3DD4RGGRX5LBW2LGB6J3E6XOXLWSU2QEIWBEM4QC

* Negative caching: don't perform a build if a dependency already

failed in a previous build. This is essential for Nixpkgs: we don't want to keep doing the same failed dependency (say, Glibc) over and over again for a few hundred jobs.

Created by Eelco Dolstra on March 9, 2009

37R34XJOGMP3E3DD4RGGRX5LBW2LGB6J3E6XOXLWSU2QEIWBEM4QC

Dependencies

In channels

main

upstream

Change contents

Replacement in src/lib/Hydra/Schema/BuildInputs.pm at line 39 [5.1]

B:BD[5.782] → [6.295:437]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-06 14:20:12
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:H25BhHe9wbU6nj6fSKjZnw

[5.782]

[5.924]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-09 18:05:06
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:L6NP/+9zhMg4TRw3w911rg

Replacement in src/lib/Hydra/Schema/BuildProducts.pm at line 38 [7.4268]

B:BD[7.4922] → [6.516:658]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-06 14:20:12
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:rfkj/A+Li7Q0hWydqtJHAw

[7.4922]

[7.5064]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-09 18:05:06
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:yTJRsclWIpHApRSLqyR06Q

Insertion in src/lib/Hydra/Schema/BuildResultInfo.pm at line 28 [9.1594]

[8.883]

  { data_type => "integer", is_nullable => 0, size => undef },
  "faileddepbuild",
  { data_type => "integer", is_nullable => 0, size => undef },
  "faileddepstepnr",

Replacement in src/lib/Hydra/Schema/BuildResultInfo.pm at line 38 [9.1594]

B:BD[9.2382] → [6.659:801]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-06 14:20:12
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:wmL9881G+dZrgHKM83dHXw

[9.2382]

[9.2524]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-09 18:05:06
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:o1XAUgKd15pN76Rs8aX+IA

Insertion in src/lib/Hydra/Schema/BuildResultInfo.pm at line 41 [9.1594]

[9.2525]

__PACKAGE__->belongs_to(
  "failedDep",
  "Hydra::Schema::BuildSteps",
  { id => "faileddepbuild", stepnr => "faileddepstepnr" },
);

Deletion in src/lib/Hydra/Schema/BuildResultInfo.pm at line 47 [9.1594]
B:BD[9.2526] → [9.2526:2616]
```
# You can replace this text with custom content, and it will be preserved on regeneration
```

Replacement in src/lib/Hydra/Schema/BuildSchedulingInfo.pm at line 30 [9.3773]

B:BD[9.4473] → [6.802:944]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-06 14:20:12
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:6cTj5JovtTmtemvQjWtucQ

[9.4473]

[9.4615]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-09 18:05:06
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:MeS9DLCs3kuhS4pTqfl4Lg

Deletion in src/lib/Hydra/Schema/BuildSteps.pm at line 36 [11.1675]
∅:D[10.2498] → [11.2814:2815]
B:BD[11.2814] → [11.2814:2815]

Deletion in src/lib/Hydra/Schema/BuildSteps.pm at line 37 [11.1675]

B:BD[11.2816] → [6.945:1087]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-06 14:20:12
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:LyNlkn5XjBnLp7M4ipB/ZQ

Insertion in src/lib/Hydra/Schema/BuildSteps.pm at line 38 [11.1675]

[11.2959]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-09 18:05:06
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:nFSksz60oxcM1+nYqAdjzw

Deletion in src/lib/Hydra/Schema/BuildSteps.pm at line 41 [11.1675]
B:BD[11.2960] → [11.2960:3050]
```
# You can replace this text with custom content, and it will be preserved on regeneration
```

Replacement in src/lib/Hydra/Schema/Builds.pm at line 79 [7.5202]

B:BD[7.6194] → [6.1088:1230]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-06 14:20:12
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:8U9CmcfeowLJVViKiR3n1g

[7.6194]

[9.3377]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-09 18:05:06
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:p9SIzdyW9p4+eqwKwXzAdQ

Replacement in src/lib/Hydra/Schema/CachedPathInputs.pm at line 25 [12.859]

B:BD[12.1497] → [6.1231:1373]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-06 14:20:12
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:+F3EiYsvXuOjnGDrkhLxng

[12.1497]

[12.1639]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-09 18:05:06
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:zvTGb3qhlacSWzc0H+7dfg

Replacement in src/lib/Hydra/Schema/CachedSubversionInputs.pm at line 23 [12.1780]

B:BD[12.2342] → [6.1374:1516]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-06 14:20:12
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:O0QvXjOulMVTjhW4rRHkmQ

[12.2342]

[12.2484]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-09 18:05:06
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:TY8SHfWiBibwiG3WPkP8Mg

Replacement in src/lib/Hydra/Schema/JobsetInputAlts.pm at line 34 [13.825]

B:BD[13.1831] → [6.1517:1659]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-06 14:20:12
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:qXh+0QbMUHIDmQCG9T5qdA

[13.1831]

[13.1973]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-09 18:05:06
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:4iKXGIdrm56xZeHFxa/K4A

Replacement in src/lib/Hydra/Schema/JobsetInputs.pm at line 46 [14.590]

B:BD[14.1681] → [6.1660:1802]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-06 14:20:12
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:TUTdwfhSsFMKBXa/wKenOQ

[14.1681]

[14.1823]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-09 18:05:06
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:rh03/olFXpMiTA+zhRYltg

Replacement in src/lib/Hydra/Schema/Jobsets.pm at line 53 [14.1960]

B:BD[14.2992] → [6.1803:1945]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-06 14:20:12
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:dVevQ8lPI2/IRpYoJgzLBA

[14.2992]

[14.3134]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-09 18:05:06
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:IfDpZfiD9haRHLXGdkapGg

Replacement in src/lib/Hydra/Schema/Projects.pm at line 48 [14.3266]

B:BD[14.3685] → [6.1946:2088]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-06 14:20:12
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:Q5mSKzMxB9px2ja8NjK/9Q

[14.3685]

[14.3827]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-09 18:05:06
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:7VRmssxrhgzfySJ6OGuhGg

Replacement in src/lib/Hydra/Schema/ReleaseSetJobs.pm at line 35 [15.5076]

B:BD[15.6070] → [6.2089:2231]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-06 14:20:12
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:+Ky8V3sZIgT22hgF27Y0cw

[15.6070]

[15.6212]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-09 18:05:06
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:GdOtS3nLs7dwpArSdGob0w

Replacement in src/lib/Hydra/Schema/ReleaseSets.pm at line 32 [15.6351]

B:BD[15.7142] → [6.2232:2374]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-06 14:20:12
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:f+4AnWTJsi4RDfxoJxECgw

[15.7142]

[15.7284]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-09 18:05:06
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:lQymTkBv/Av2y6iYjvP5PQ

Replacement in src/lib/Hydra/Schema/SystemTypes.pm at line 19 [16.1717]

B:BD[16.2105] → [6.2375:2517]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-06 14:20:12
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:Af/LU15/hpXngfrBrDMI/A

[16.2105]

[16.2247]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-09 18:05:06
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:KZzTedcMG8IxkLgEEkdn9A

Replacement in src/lib/Hydra/Schema/UserRoles.pm at line 20 [17.3263]

B:BD[17.3736] → [6.2518:2660]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-06 14:20:12
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:/yDlbFhRYDzf+0VHzygrhA

[17.3736]

[17.3878]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-09 18:05:06
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:9YGxnZD9hLoJJ8b1aejBuA

Replacement in src/lib/Hydra/Schema/Users.pm at line 33 [18.3258]

B:BD[18.3782] → [6.2661:2803]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-06 14:20:12
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:d7M/Q6OucU9NUCSB5zZK7Q

[18.3782]

[18.3924]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-09 18:05:06
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:HwKK4N8V5fzvR3XrKnrDEA

Replacement in src/lib/Hydra/Schema.pm at line 11 [7.6376]

B:BD[7.6498] → [6.2804:2946]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-06 14:20:12
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:hRwus0A1vxnFCzQxghFgTw

[7.6498]

[7.6640]

# Created by DBIx::Class::Schema::Loader v0.04005 @ 2009-03-09 18:05:06
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:DQAmauNODAxmM2mF/AE2aQ

Replacement in src/root/build.tt at line 39 [7.7350]

∅:D[3.132] → [19.1697:1780]

B:BD[20.602] → [19.1697:1780]

          <span class="error">Build returned a non-zero exit code</span>

[3.132]

[21.2176]

          <span class="error">Build returned a non-zero exit code</span>

Insertion in src/root/build.tt at line 46 [7.7350]

[22.1499]

[20.665]

        [% ELSIF build.resultInfo.buildstatus == 5 %]
          <img src="/static/images/failure.gif" alt="Failed" />
          <span class="error">Build inhibited because a dependency previously failed to build</span>
          [% failedDep = build.resultInfo.failedDep %]
          (namely, <a href="[% c.uri_for('/build' failedDep.id.id 'nixlog' failedDep.stepnr) %]"><tt>[% failedDep.outpath %]</tt></a>)

Replacement in src/root/build.tt at line 264 [7.7350]

B:BD[20.1108] → [21.3131:3166]

[% IF build.resultInfo.errormsg %]

[20.1108]

[% IF build.resultInfo.errormsg && build.resultInfo.buildstatus != 5 %]

Insertion in src/script/hydra_build.pl at line 27 [23.2912]
[21.3622]
[2.495]
```
    my $failedDepBuild;
    my $failedDepStepNr;
```

Insertion in src/script/hydra_build.pl at line 36 [23.2912]

[23.3533]

[4.443]

        # Check whether a dependency of this build has previously
        # failed.  If so, don't even bother to build, since it will
        # fail anyway.  !!! Once Nix has negative caching, this code
        # can go.
        my @drvDeps = split '\n', `nix-store --query --requisites --include-outputs $drvPath`;
        die "cannot query dependencies of `$drvPath': $?" if $? != 0;
        @drvDeps = grep { $_ =~ /.drv$/ } @drvDeps;
        my @drvOutputs = split '\n', `nix-store --query --outputs @drvDeps`;
        die "cannot query outputs of the dependencies of `$drvPath': $?" if $? != 0;
        foreach my $dep (@drvOutputs) {
            # !!! This checks more than it has to, namely
            # build-time-only dependencies of dependencies (which
            # don't need to be built).  However, it shouldn't matter:
            # if the dependency was built, then presumably *its*
            # dependencies were built as well.
            # !!! should disregard fixed-output derivations (?)
            if (!isValidPath($dep)) {
                my ($step) = $db->resultset('BuildSteps')->search(
                    {outPath => $dep}, {rows => 1, order_by => "stopTime DESC"});
                if (defined $step && $step->status != 0) {
                    $buildStatus = 5;
                    $failedDepBuild = $step->id->id;
                    $failedDepStepNr = $step->stepnr;
                    goto done;
                }
            }
        }

Insertion in src/script/hydra_build.pl at line 198 [23.2912]
[23.4020]
[23.4020]
```
  done:
```

Replacement in src/script/hydra_build.pl at line 202 [23.2912]

B:BD[23.4043] → [4.817:871]

        $build->({finished => 1, timestamp => time});

[23.4043]

[9.7526]

        $build->update({finished => 1, timestamp => time});

Insertion in src/script/hydra_build.pl at line 224 [23.2912]

[24.1954]

[23.4574]

            , faileddepbuild => $failedDepBuild
            , faileddepstepnr => $failedDepStepNr

Insertion in src/sql/hydra.sql at line 65 [25.1]

[22.3171]

[21.4847]

    --   5 = build not done because a dependency failed previously

Insertion in src/sql/hydra.sql at line 78 [25.1]

[26.2508]

[21.4926]


    -- If buildStatus == 5, the primary key of the failed build step.
    failedDepBuild  integer,
    failedDepStepNr integer,

Replacement in src/sql/hydra.sql at line 88 [25.1]

B:BD[11.7150] → [11.7150:7186]

    id            integer not null,

[11.7150]

[11.7186]

    id            integer not null, -- !!! rename to "build"

Replacement in src/sql/hydra.sql at line 93 [25.1]
B:BD[11.7291] → [11.7291:7316]
```
    drvPath       text, 
```
[11.7291]
[11.7316]
```
    drvPath       text,
```