grahamc/hydra - Change 66MEE6QG53NOOFIMZZE7R4TL5SA32V2547ZD3LDT2NPLFNR6Q7CAC

hydra-build: Don't send a giant query to the database

We had Postgres barfing with this error:

DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute failed: ERROR: stack depth limit exceeded

because the ‘drvpath => [ @dependentDrvs ]’ in failDependents can cause a query of unbounded size. (In this specific case there was a failure of Bison, which has > 10000 dependent derivations.) So now we just get all scheduled builds from the DB.

Created by Eelco Dolstra on September 10, 2013

66MEE6QG53NOOFIMZZE7R4TL5SA32V2547ZD3LDT2NPLFNR6Q7CAC

Dependencies

In channels

upstream

main

Change contents

Insertion in release.nix at line 95 [4.1]
[3.910]
[3.910]
```
            SetScalar
```
Insertion in src/script/hydra-build at line 14 [6.2912]
[5.30]
[6.2987]
```
use Set::Scalar;
```

Replacement in src/script/hydra-build at line 45 [6.2912]

B:BD[2.346] → [2.346:404]

    my @dependentDrvs = computeFSClosure(1, 0, $drvPath);

[2.346]

[2.404]

    my $dependentDrvs = Set::Scalar->new(computeFSClosure(1, 0, $drvPath));

Replacement in src/script/hydra-build at line 52 [6.2912]

B:BD[2.516] → [2.516:590]

            { drvpath => [ @dependentDrvs ], finished => 0, busy => 0 });

[2.516]

[7.15982]

            { finished => 0, busy => 0 },
            { columns => ["id", "project", "jobset", "job", "drvpath"] });

Insertion in src/script/hydra-build at line 56 [6.2912]

[2.630]

            next unless $dependentDrvs->has($d->drvpath);