grahamc/hydra - Change OEQQ6CVTBZBTSCU6IT7ZRIPRTYUJLM7BT435EL5TGBVBEA5AT7PQC

Set notificationpendingsince for dependent builds

build_finished Postgres event will never be fired for the dependent builds.

For example, on our Hydra, the following query always returns increasing numbers, even though all notifications have been delivered:

hydra=&gt; select count(1) from builds where notificationpendingsince is not null;
 count
-------
  4583
(1 row)

Thus, we have to iterate over all dependent builds and mark their notificationpendingsince as null, otherwise they will pile up until the next restart of hydra-notify, when they will get delivered.

Created by Nikola Knezevic on May 28, 2020

OEQQ6CVTBZBTSCU6IT7ZRIPRTYUJLM7BT435EL5TGBVBEA5AT7PQC

Dependencies

In channels

upstream

main

Change contents

Replacement in src/script/hydra-notify at line 66 [3.2994]

B:BD[2.2006] → [2.2006:2065]

    $build->update({ notificationpendingsince => undef });

[2.2006]

[4.4016]

    # We have to iterate through all dependents as well, and if they are finished
    # to mark their notificationpendingsince.
    # Otherwise, the dependent builds will remain with notificationpendingsince set
    # until hydra-notify is started, as buildFinished is never emitted for them.
    foreach my $b ($build, @dependents) {
        $b->update({ notificationpendingsince => undef }) if $b->finished;
    }