grahamc/hydra - Change SMM4HQTPAY45254O7GQOJVLHP5LZ6BXDKGNE7IKUJHB5XKH244ZAC

* Put actions related to builds under /build (e.g. /log/<buildid>

becomes /build/<buildid>/log).

Created by Eelco Dolstra on February 25, 2009

SMM4HQTPAY45254O7GQOJVLHP5LZ6BXDKGNE7IKUJHB5XKH244ZAC

Dependencies

In channels

main

upstream

Change contents

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 8 [7.804]

B:BD[7.909] → [7.909:1045]

#
# Sets the actions in this controller to be registered with no prefix
# so they function identically to actions created in MyApp.pm
#

[7.909]

[7.1045]


# Put this controller at top-level.

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 27 [7.804]

B:BD[7.1122] → [7.1122:1224]

    $c->stash->{template} = 'error.tt';
    $c->stash->{error} = $msg;
    $c->response->status(404);

[7.1122]

[7.1224]

    $c->error($msg);
    $c->detach;

Insertion in src/Hydra/lib/Hydra/Controller/Root.pm at line 572 [7.804]
[7.1592]
[7.1592]
```
    $c->response->status(404);
```
Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 576 [7.804]
B:BD[7.1596] → [7.1596:1615]
```
sub build :Local {
```
[7.1596]
[8.468]
```
sub build : Chained('/') PathPart CaptureArgs(1) {
```

Insertion in src/Hydra/lib/Hydra/Controller/Root.pm at line 578 [7.804]

[8.498]

[7.1647]

    
    $c->stash->{id} = $id;
    
    $c->stash->{build} = getBuild($c, $id);
    
    if (!defined $c->stash->{build}) {
        error($c, "Build with ID $id doesn't exist.");
        $c->response->status(404);
        return;
    }

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 589 [7.804]

∅:D[9.248] → [7.1648:1760]

B:BD[7.1648] → [7.1648:1760]

    my $build = getBuild($c, $id);
    return error($c, "Build with ID $id doesn't exist.") if !defined $build;

[7.1648]

[9.249]

    $c->stash->{curProject} = $c->stash->{build}->project;
}

Deletion in src/Hydra/lib/Hydra/Controller/Root.pm at line 592 [7.804]
B:BD[9.250] → [9.250:297]
```
    $c->stash->{curProject} = $build->project;
```

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 593 [7.804]

∅:D[10.399] → [7.1765:1865]

B:BD[7.1765] → [7.1765:1865]

    $c->stash->{template} = 'build.tt';
    $c->stash->{build} = $build;
    $c->stash->{id} = $id;

[10.399]

[11.0]

sub view_build : Chained('build') PathPart('') Args(0) {
    my ($self, $c) = @_;

Insertion in src/Hydra/lib/Hydra/Controller/Root.pm at line 596 [7.804]

[11.1]

[12.978]

    my $build = $c->stash->{build};
    
    $c->stash->{template} = 'build.tt';

Deletion in src/Hydra/lib/Hydra/Controller/Root.pm at line 600 [7.804]
B:BD[12.1011] → [5.0:1]

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 609 [7.804]

B:BD[7.1869] → [7.1869:1886]

B:BD[7.1886] → [8.499:529]

sub log :Local {
    my ($self, $c, $id) = @_;

[7.1869]

[7.1929]

sub view_nixlog : Chained('build') PathPart('nixlog') Args(1) {
    my ($self, $c, $stepnr) = @_;

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 612 [7.804]

B:BD[7.1930] → [7.1930:1965]

B:BD[7.1965] → [13.33:102]

∅:D[13.102] → [7.2042:2043]

B:BD[7.2042] → [7.2042:2043]

B:BD[7.2043] → [13.103:200]

    my $build = getBuild($c, $id);
    return error($c, "Build $id doesn't exist.") if !defined $build;
    return error($c, "Build $id didn't produce a log.") if !defined $build->resultInfo->logfile;

[7.1930]

[13.200]

    my $step = $c->stash->{build}->buildsteps->find({stepnr => $stepnr});
    return error($c, "Build doesn't have a build step $stepnr.") if !defined $step;

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 616 [7.804]
B:BD[7.2253] → [13.202:235]
```
    $c->stash->{build} = $build;
```
[7.2253]
[7.2309]
```
    $c->stash->{step} = $step;
```

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 619 [7.804]

B:BD[7.2365] → [4.0:69]

    $c->stash->{logtext} = loadLog($c, $build->resultInfo->logfile);

[7.2365]

[14.162]

    $c->stash->{logtext} = loadLog($c, $step->logfile);

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 623 [7.804]

B:BD[14.166] → [14.166:186]

B:BD[14.186] → [8.530:569]

∅:D[8.569] → [14.227:340]

B:BD[14.227] → [14.227:340]

sub nixlog :Local {
    my ($self, $c, $id, $stepnr) = @_;
    my $build = getBuild($c, $id);
    return error($c, "Build with ID $id doesn't exist.") if !defined $build;

[14.166]

[14.340]

sub view_log : Chained('build') PathPart('log') Args(0) {
    my ($self, $c) = @_;

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 626 [7.804]

B:BD[14.341] → [14.341:491]

    my $step = $build->buildsteps->find({stepnr => $stepnr});
    return error($c, "Build $id doesn't have a build step $stepnr.") if !defined $step;

[14.341]

[15.0]

    return error($c, "Build didn't produce a log.") if !defined $c->stash->{build}->resultInfo->logfile;

Deletion in src/Hydra/lib/Hydra/Controller/Root.pm at line 628 [7.804]
B:BD[15.1] → [15.1:108]
∅:D[15.108] → [14.491:496]
B:BD[14.491] → [14.491:496]
```
    return error($c, "Build step $stepnr of build $id does not have a log file.") if $step->logfile eq "";
    
```
Deletion in src/Hydra/lib/Hydra/Controller/Root.pm at line 629 [7.804]
B:BD[14.534] → [2.0:33]
∅:D[2.33] → [14.561:592]
B:BD[14.561] → [14.561:592]
```
    $c->stash->{build} = $build;
    $c->stash->{step} = $step;
```

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 631 [7.804]

B:BD[14.648] → [4.70:126]

    $c->stash->{logtext} = loadLog($c, $step->logfile);

[14.648]

[7.2413]

    $c->stash->{logtext} = loadLog($c, $c->stash->{build}->resultInfo->logfile);

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 649 [7.804]

B:BD[16.2] → [16.2:24]

B:BD[16.24] → [8.570:630]

sub download :Local {
    my ($self, $c, $id, $productnr, $filename, @path) = @_;

[16.2]

[7.2595]

sub download : Chained('build') PathPart('download') {
    my ($self, $c, $productnr, $filename, @path) = @_;

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 652 [7.804]

B:BD[7.2596] → [16.80:192]

∅:D[16.192] → [7.2596:2597]

B:BD[7.2596] → [7.2596:2597]

B:BD[7.2597] → [16.193:358]

    my $build = getBuild($c, $id);
    return error($c, "Build with ID $id doesn't exist.") if !defined $build;
    my $product = $build->buildproducts->find({productnr => $productnr});
    return error($c, "Build $id doesn't have a product $productnr.") if !defined $product;

[7.2596]

[16.358]

    my $product = $c->stash->{build}->buildproducts->find({productnr => $productnr});
    return error($c, "Build doesn't have a product $productnr.") if !defined $product;

Insertion in src/Hydra/lib/Hydra/Controller/Root.pm at line 745 [7.804]
[17.402]
[17.402]
```
sub end : ActionClass('RenderView') {
    my ($self, $c) = @_;
```
Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 749 [7.804]
∅:D[18.231] → [7.2597:2636]
∅:D[19.293] → [7.2597:2636]
∅:D[17.403] → [7.2597:2636]
∅:D[16.510] → [7.2597:2636]
B:BD[7.2597] → [7.2597:2636]
```
sub end : ActionClass('RenderView') {}
```
[17.403]
[7.2636]
```
    if (scalar @{$c->error}) {
        $c->stash->{template} = 'error.tt';
        $c->stash->{errors} = $c->error;
        $c->clear_errors;
    }
}
```

Replacement in src/Hydra/root/build.tt at line 124 [7.7350]

B:BD[13.2530] → [13.2530:2612]

        <a href="[% c.uri_for('/log' build.id) %]"><strong>Available</strong></a>

[13.2530]

[13.2612]

        <a href="[% c.uri_for('build' build.id 'log') %]"><strong>Available</strong></a>

Insertion in src/Hydra/root/build.tt at line 181 [7.7350]

[14.4155]

[3.0]

      [% log = c.uri_for('build' build.id 'nixlog' step.stepnr) %]

Replacement in src/Hydra/root/build.tt at line 183 [7.7350]

B:BD[3.58] → [3.58:179]

          [% IF step.logfile %] onclick="window.location = '[% c.uri_for('/nixlog' build.id step.stepnr) %]'" [% END %]>

[3.58]

[14.4166]

          [% IF step.logfile %] onclick="window.location = '[% log %]'" [% END %]>

Replacement in src/Hydra/root/build.tt at line 216 [7.7350]

B:BD[15.322] → [15.322:402]

            (<a href="[% c.uri_for('/nixlog' build.id step.stepnr) %]">log</a>)

[15.322]

[15.402]

            (<a href="[% log %]">log</a>)

Replacement in src/Hydra/root/error.tt at line 6 [7.8490]

B:BD[7.8555] → [20.2463:2565]

<p>I'm very sorry, but an error occurred: <span class="error-msg">[% HTML.escape(error) %]</span></p>

[7.8555]

[7.8645]

<p>I'm very sorry, but an error occurred: <span class="error-msg">[% FOREACH error IN errors %] [% HTML.escape(error) %] [% END %]</span></p>

Replacement in src/Hydra/root/product-list.tt at line 8 [21.3098]

B:BD[21.3209] → [6.911:916]

[21.3209]

[21.3234]


      [% uri = c.uri_for('build' build.id 'download' product.productnr product.name) %]

Replacement in src/Hydra/root/product-list.tt at line 16 [21.3098]

B:BD[6.951] → [6.951:1006]

        <a href="[% c.uri_for('/nixpkg' build.id) %]">

[6.951]

[6.1006]

        [% uri = c.uri_for('nixpkg' build.id) %]
        <a href="[% uri %]">

Replacement in src/Hydra/root/product-list.tt at line 31 [21.3098]

B:BD[6.1707] → [6.1707:1810]

          <pre>$ nix-install-package --non-interactive --url [% c.uri_for('/nixpkg' build.id) %]</pre>

[6.1707]

[6.1810]

          <pre>$ nix-install-package --non-interactive --url [% uri %]</pre>

Replacement in src/Hydra/root/product-list.tt at line 82 [21.3098]
∅:D[6.2529] → [21.4409:4497]
B:BD[21.4409] → [21.4409:4497]
```
        <a href="[% c.uri_for('/download' build.id product.productnr product.name) %]">
```
[6.2529]
[21.4497]
```
        <a href="[% uri %]">
```

Replacement in src/Hydra/root/product-list.tt at line 102 [21.3098]

B:BD[21.5285] → [21.5285:5477]

                <a href="[% c.uri_for('/download' build.id product.productnr product.name) %]">
                  <tt>[% c.uri_for('/download' build.id product.productnr product.name) %]</tt>

[21.5285]

[21.5477]

                <a href="[% uri %]">
                  <tt>[% uri %]</tt>

Replacement in src/Hydra/root/product-list.tt at line 118 [21.3098]
∅:D[6.2577] → [21.5954:6042]
B:BD[21.5954] → [21.5954:6042]
```
        <a href="[% c.uri_for('/download' build.id product.productnr product.name) %]">
```
[6.2577]
[21.6042]
```
        <a href="[% uri %]">
```
Replacement in src/Hydra/root/product-list.tt at line 132 [21.3098]
∅:D[6.2618] → [21.6363:6451]
B:BD[21.6363] → [21.6363:6451]
```
        <a href="[% c.uri_for('/download' build.id product.productnr product.name) %]">
```
[6.2618]
[21.6451]
```
        <a href="[% uri %]">
```

* Put actions related to builds under /build (e.g. /log/<buildid>

Dependencies

In channels

Change contents

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 8 [7.804]

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 27 [7.804]

Insertion in src/Hydra/lib/Hydra/Controller/Root.pm at line 572 [7.804]

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 576 [7.804]

Insertion in src/Hydra/lib/Hydra/Controller/Root.pm at line 578 [7.804]

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 589 [7.804]

Deletion in src/Hydra/lib/Hydra/Controller/Root.pm at line 592 [7.804]

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 593 [7.804]

Insertion in src/Hydra/lib/Hydra/Controller/Root.pm at line 596 [7.804]

Deletion in src/Hydra/lib/Hydra/Controller/Root.pm at line 600 [7.804]

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 609 [7.804]

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 612 [7.804]

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 616 [7.804]

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 619 [7.804]

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 623 [7.804]

Replacement in src/Hydra/lib/Hydra/Controller/Root.pm at line 626 [7.804]

Deletion in src/Hydra/lib/Hydra/Controller/Root.pm at line 628 [7.804]

Deletion in src/Hydra/lib/Hydra/Controller/Root.pm at line 629 [7.804]