{"header":{"message":"Implement DELETE for jobsets and use it in the web interface","description":null,"timestamp":"2013-10-03T15:54:40Z","authors":[{"email":"eelco.dolstra@logicblox.com","name":"Eelco Dolstra"}]},"hash":"4NTIBJ74F2QUMISJPB4DGM7VPYFVZDS6ZDITVIAQCSWO6C3UIQ6QC","authors":[],"deps":{"hashes":[["4NTIBJ74F2QUMISJPB4DGM7VPYFVZDS6ZDITVIAQCSWO6C3UIQ6QC","Implement DELETE for jobsets and use it in the web interface"],["AA",null],["DAPOSS44WRFQZ7XUWSMYCCORY4POKD42DGAIXMGP4ZRBOEPNNRGAC","Use the REST API in the web interface for editing projects"],["MJ4RWQ3TN7LXANZXJLG6DWHAWH3FQRVWGATAKEFPFPIIBDW4ZJ3QC","Add links to the project/jobset edit pages in the logical place"],["225GEK4NN53NJ6EBDAJNECR76FILAHV7KNEG23TDQ2KYMG7NFEUAC","After editing a project/jobset, redirect back to the config tab"],["VJFLX7B6DEYXQRS3T5LHOM4POSGMEBQSJJVBHAQV3U4LRPF4KVBAC","Fix rendering of jobset inputs"],["M6UBWKN23RAUWXCHSZOUL3YBBZWBB5II3N56CLGWRVRYVFGN3QVAC","Fix project/jobset deletion"],["JIJDYWPYMZZNFBCWYSYR72RNEW5MSI26MJ5UXXIU7DDX25IBR3CQC","Remove the Build menu from the top bar"],["OIBSCXGIVF2MKTICVICURPOH63D5I5KHNCUD76KA33A6JYGDPJUAC","Use a popover to show how to use the build reproduction script"],["UMFB2767NMAG46NAG3XHMYQMCLF5TMVN46SST4AM2CFUEMNZH3WQC","Hydra/64: Leaving number of builds empty gives DBIx error"],["3PNG7NIBQQURUUPRVQXYL342OT7JUUYOMY2JJNP6YDX7SYJDZMYAC","Remove trailing whitespace"],["OX6NYJDVCDX2UCJ4QQMTRJVZ535NOMCJGYCHDLCADJPQI7RMCXPQC","Split viewing and editing a jobset"],["ZRRPBEI4ZSISCMWV62JGB35QNRJVA7SZUR4F52WTQRECCG2GCEAQC","Make jobset deletion consistent with project deletion"],["BV7V5RGN22P2Q4NB2B4AFGEG2KUERCJQYPVOPMUTBA7VBRLHNDFQC","Allow only project owners to delete projects / jobsets"],["TFK74CQRYCOR2RAUZ6LATA3IJVR7QCWSPCMTXCJPPDPIRS7D5UTQC","Put job status on a separate tab"],["JY7BXXOP3EZCDT5RSMVE4Y6IECXGYL4GEBJOZHR7H3Z35XZ3NIVQC","Split viewing and editing a project"],["ODNCGFQ5FPKFI624BVMLW7PJ2EFJOR3TY66OCZM42UNNTWBCF2TQC","* Improved the navigation bar: don't include all projects (since that"],["D7PL2VWUCRIFGFPFXTB466NIUYU4FECAQPHF4TDFVMOK23VEHDEAC","Move more actions from the top bar"],["LZVO64YG43JD7YMZSCTZNOBS5ROZA4FMPKJW2YOMHX2V5PTGBVWQC","Merge in the first bits of the API work"],["3HZY24CX4U2TO74HOY4YX3LBJIYF4DLXHCIY7J2RASAC4COMSMZAC","* Make jobsets viewable under"],["IK53RV4VGOHLCZGQCCIKPB45M3C7M7YMNBOJFBGZJ4LWIZNU4QNQC",""],["7YBYT2LQML2PKEO6UO4444AGSASS664UCDXW2YO3ALB7THQHCEBQC",""]],"deps":["DAPOSS44WRFQZ7XUWSMYCCORY4POKD42DGAIXMGP4ZRBOEPNNRGAC"],"known":["ODNCGFQ5FPKFI624BVMLW7PJ2EFJOR3TY66OCZM42UNNTWBCF2TQC","UMFB2767NMAG46NAG3XHMYQMCLF5TMVN46SST4AM2CFUEMNZH3WQC","3PNG7NIBQQURUUPRVQXYL342OT7JUUYOMY2JJNP6YDX7SYJDZMYAC","JY7BXXOP3EZCDT5RSMVE4Y6IECXGYL4GEBJOZHR7H3Z35XZ3NIVQC","OX6NYJDVCDX2UCJ4QQMTRJVZ535NOMCJGYCHDLCADJPQI7RMCXPQC","TFK74CQRYCOR2RAUZ6LATA3IJVR7QCWSPCMTXCJPPDPIRS7D5UTQC","MJ4RWQ3TN7LXANZXJLG6DWHAWH3FQRVWGATAKEFPFPIIBDW4ZJ3QC","ZRRPBEI4ZSISCMWV62JGB35QNRJVA7SZUR4F52WTQRECCG2GCEAQC","VJFLX7B6DEYXQRS3T5LHOM4POSGMEBQSJJVBHAQV3U4LRPF4KVBAC","OIBSCXGIVF2MKTICVICURPOH63D5I5KHNCUD76KA33A6JYGDPJUAC","M6UBWKN23RAUWXCHSZOUL3YBBZWBB5II3N56CLGWRVRYVFGN3QVAC","225GEK4NN53NJ6EBDAJNECR76FILAHV7KNEG23TDQ2KYMG7NFEUAC","LZVO64YG43JD7YMZSCTZNOBS5ROZA4FMPKJW2YOMHX2V5PTGBVWQC","JIJDYWPYMZZNFBCWYSYR72RNEW5MSI26MJ5UXXIU7DDX25IBR3CQC","D7PL2VWUCRIFGFPFXTB466NIUYU4FECAQPHF4TDFVMOK23VEHDEAC","BV7V5RGN22P2Q4NB2B4AFGEG2KUERCJQYPVOPMUTBA7VBRLHNDFQC"]},"hunks":[{"Edit":{"inode":{"change":20,"pos":104},"path":"src/lib/Hydra/Controller/Jobset.pm","line":3,"atom":{"NewVertex":{"up_context":[{"change":20,"pos":141}],"down_context":[{"change":20,"pos":141}],"flag":"BLOCK","start":0,"end":10,"inode":{"change":20,"pos":104}}},"contents":[{"Add":"use utf8;"}]}},{"Edit":{"inode":{"change":20,"pos":104},"path":"src/lib/Hydra/Controller/Jobset.pm","line":139,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":10668}],"down_context":[{"change":3,"pos":10668}],"flag":"BLOCK","start":11,"end":56,"inode":{"change":20,"pos":104}}},"contents":[{"Add":"sub jobset_DELETE {"},{"Add":" my ($self, $c) = @_;"}]}},{"Edit":{"inode":{"change":20,"pos":104},"path":"src/lib/Hydra/Controller/Jobset.pm","line":142,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":10669}],"down_context":[{"change":3,"pos":10669}],"flag":"BLOCK","start":57,"end":471,"inode":{"change":20,"pos":104}}},"contents":[{"Add":" requireProjectOwner($c, $c->stash->{project});"},{"Add":""},{"Add":" txn_do($c->model('DB')->schema, sub {"},{"Add":" $c->stash->{jobset}->jobsetevals->delete_all;"},{"Add":" $c->stash->{jobset}->builds->delete_all;"},{"Add":" $c->stash->{jobset}->delete;"},{"Add":" });"},{"Add":""},{"Add":" my $uri = $c->uri_for($c->controller('Project')->action_for(\"project\"), [$c->stash->{project}->name]);"},{"Add":" $self->status_ok($c, entity => { redirect => \"$uri\" });"},{"Add":"}"},{"Add":""},{"Add":""}]}},{"Edit":{"inode":{"change":20,"pos":104},"path":"src/lib/Hydra/Controller/Jobset.pm","line":225,"atom":{"EdgeMap":{"edges":[{"previous":"","flag":"DELETED","from":{"change":3,"pos":51},"to":{"change":3,"start":0,"end":62},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":861},"to":{"change":3,"start":0,"end":62},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":62},"to":{"change":3,"start":0,"end":210},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":210},"to":{"change":3,"start":10994,"end":11121},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":11121},"to":{"change":3,"start":223,"end":229},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":223},"to":{"change":3,"start":223,"end":229},"introduced_by":3}],"inode":{"change":20,"pos":104}}},"contents":[{"Del":"\n if (($c->request->params->{submit} // \"\") eq \"delete\") {\n"},{"Del":" txn_do($c->model('DB')->schema, sub {\n $c->stash->{jobset}->jobsetevals->delete_all;\n $c->stash->{jobset}->builds->delete_all;\n $c->stash->{jobset}->delete;\n });\n"},{"Del":" return $c->res->redirect($c->uri_for($c->controller('Project')->action_for(\"project\"), [$c->stash->{project}->name]));\n"},{"Del":" }\n"}]}},{"Replacement":{"inode":{"change":21,"pos":2803},"path":"src/root/common.tt","line":455,"ins":{"up_context":[{"change":3,"pos":2374}],"down_context":[{"change":3,"pos":2457}],"flag":"BLOCK","start":472,"end":635,"inode":{"change":21,"pos":2803}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":2374},"to":{"change":3,"start":2374,"end":2457},"introduced_by":3}],"inode":{"change":21,"pos":2803}},"ins_contents":[{"Add":" "},{"Add":" [% IF icon %] [%+ END %]"},{"Add":" [% title %]"},{"Add":" "}],"del_contents":[{"Del":" [% title %]\n"}]}},{"Edit":{"inode":{"change":3,"pos":367},"path":"src/root/edit-jobset.tt","line":136,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4659},"to":{"change":3,"start":345,"end":779},"introduced_by":3}],"inode":{"change":3,"pos":367}}},"contents":[{"Del":"\n [% IF !create %]\n \n \n [% END %]\n"}]}},{"Replacement":{"inode":{"change":3,"pos":8409},"path":"src/root/jobset.tt","line":52,"ins":{"up_context":[{"change":3,"pos":283}],"down_context":[{"change":3,"pos":620}],"flag":"BLOCK","start":636,"end":1121,"inode":{"change":3,"pos":8409}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":283},"to":{"change":3,"start":283,"end":620},"introduced_by":3}],"inode":{"change":3,"pos":8409}},"ins_contents":[{"Add":" [% INCLUDE menuItem title=\"Edit configuration\" icon=\"icon-edit\" uri=c.uri_for(c.controller('Jobset').action_for('edit'), [project.name, jobset.name]) %]"},{"Add":" [% INCLUDE menuItem title=\"Delete this jobset\" icon=\"icon-trash\" uri=\"javascript:deleteJobset()\" %]"},{"Add":" [% INCLUDE menuItem title=\"Clone this jobset\" uri=c.uri_for('/jobset' project.name jobset.name 'clone') %]"},{"Add":" [% INCLUDE menuItem title=\"Evaluate this jobset\" uri=\"javascript:confirmEvaluateJobset()\" %]"}],"del_contents":[{"Del":" [% INCLUDE menuItem uri = c.uri_for('/jobset' project.name jobset.name 'edit') title=\"Edit configuration\" %]\n [% INCLUDE menuItem uri = c.uri_for('/jobset' project.name jobset.name 'clone') title=\"Clone this jobset\" %]\n [% INCLUDE menuItem uri = \"javascript:confirmEvaluateJobset()\" title=\"Evaluate this jobset\" %]\n"}]}},{"Edit":{"inode":{"change":3,"pos":8409},"path":"src/root/jobset.tt","line":117,"atom":{"EdgeMap":{"edges":[{"previous":"","flag":"DELETED","from":{"change":3,"pos":337},"to":{"change":3,"start":0,"end":132},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":8848},"to":{"change":3,"start":0,"end":132},"introduced_by":3}],"inode":{"change":3,"pos":8409}}},"contents":[{"Del":"\n Edit\n"}]}},{"Replacement":{"inode":{"change":3,"pos":8409},"path":"src/root/jobset.tt","line":169,"ins":{"up_context":[{"change":3,"pos":834}],"down_context":[{"change":3,"pos":1290}],"flag":"BLOCK","start":1122,"end":1401,"inode":{"change":3,"pos":8409}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":834},"to":{"change":3,"start":834,"end":1290},"introduced_by":3}],"inode":{"change":3,"pos":8409}},"ins_contents":[{"Add":" requestJSON({"},{"Add":" url: \"[% HTML.escape(c.uri_for('/api/push', { jobsets = project.name _ ':' _ jobset.name, force = \"1\" })) %]\","},{"Add":" success: function(data) {"},{"Add":" bootbox.alert(\"The jobset has been scheduled for evaluation.\");"},{"Add":" }"},{"Add":" });"}],"del_contents":[{"Del":" $.post(\"[% HTML.escape(c.uri_for('/api/push', { jobsets = project.name _ ':' _ jobset.name, force = \"1\" })) %]\")\n .done(function(data) {\n if (data.error)\n bootbox.alert(\"Unable to schedule the jobset for evaluation: \" + data.error);\n else\n bootbox.alert(\"The jobset has been scheduled for evaluation.\");\n })\n .fail(function() { bootbox.alert(\"Server request failed!\"); });\n"}]}},{"Replacement":{"inode":{"change":3,"pos":8409},"path":"src/root/jobset.tt","line":176,"ins":{"up_context":[{"change":3,"pos":1300}],"down_context":[{"change":3,"pos":1312}],"flag":"BLOCK","start":1402,"end":1733,"inode":{"change":3,"pos":8409}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1300},"to":{"change":3,"start":1300,"end":1312},"introduced_by":3}],"inode":{"change":3,"pos":8409}},"ins_contents":[{"Add":" };"},{"Add":""},{"Add":" function deleteJobset() {"},{"Add":" bootbox.confirm("},{"Add":" 'Are you sure you want to delete this jobset?',"},{"Add":" function(c) {"},{"Add":" if (!c) return;"},{"Add":" redirectJSON({"},{"Add":" url: \"[% c.uri_for(c.controller('Jobset').action_for('jobset'), [project.name, jobset.name]) %]\","},{"Add":" type: 'DELETE'"},{"Add":" });"},{"Add":" });"}],"del_contents":[{"Del":" return;\n"}]}},{"Replacement":{"inode":{"change":22,"pos":1667},"path":"src/root/project.tt","line":12,"ins":{"up_context":[{"change":3,"pos":1536}],"down_context":[{"change":3,"pos":1896}],"flag":"BLOCK","start":1734,"end":2301,"inode":{"change":22,"pos":1667}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1536},"to":{"change":2,"start":1738,"end":1989},"introduced_by":2},{"previous":"","flag":"DELETED","from":{"change":2,"pos":1989},"to":{"change":3,"start":1642,"end":1896},"introduced_by":2},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1642},"to":{"change":3,"start":1642,"end":1896},"introduced_by":3}],"inode":{"change":22,"pos":1667}},"ins_contents":[{"Add":" [% INCLUDE menuItem title=\"Edit configuration\" icon=\"icon-edit\" uri=c.uri_for(c.controller('Project').action_for('edit'), [project.name]) %]"},{"Add":" [% INCLUDE menuItem title=\"Delete this project\" icon=\"icon-trash\" uri=\"javascript:deleteProject()\" %]"},{"Add":" [% INCLUDE menuItem title=\"Create jobset\" icon=\"icon-plus\" uri=c.uri_for(c.controller('Project').action_for('create_jobset'), [project.name]) %]"},{"Add":" [% INCLUDE menuItem title=\"Create release\" icon=\"icon-plus\" uri=c.uri_for(c.controller('Project').action_for('create_release'), [project.name]) %]"}],"del_contents":[{"Del":"

\n"},{"Del":" [% INCLUDE menuItem uri = c.uri_for(c.controller('Project').action_for('create_jobset'), [project.name]) title = \"Create jobset\" %]\n [% INCLUDE menuItem uri = c.uri_for('/project' project.name 'create-release') title = \"Create release\" %]\n"}]}}],"owner":"grahamc","repo":"hydra2","token":"a2W5d5QCJ2NT91Sma+uMQEPGQdIULCDEihHlte3scgA=","login":null}

…

Dependencies

Change contents