qualify ordery_by clauses when necessary, remove unnecessary order_by's, reported by Ludo, resulted in errors in sqlite

[?]

Apr 1, 2011, 7:40 AM

6KJXJB7NZ5XJ3WGUWKFNT6LMBNYJN3IPHZ7B7H654D5B6LPOL5QAC

Dependencies

[2] 4XVMHKBK
[3] AWZPRK2O first try for timeline of last 24 hours in hydra
[4] D5ZR3ZY6 hydra: missing property
[5] PP4LPADG hydra: buildmachine disabled by default, add some default constraints
[6] Q5WS4WKQ hydra: add comment that file is generated by hydra to /etc/nix.machines
[7] NVEFBXAM hydra: order machines by enabled/disabled, add green and red color for enabled/disabled
[8] ONAQU4BR hydra: handle case where build to keep set to 0
[9] I2WEO2VS fixed bug when updating user when no roles were selected, changed change-password link
[10] FXW2UR7F initial bzr support
[11] AEFNBIIW * Merge the GC branch.
[12] F7S2EGV2 hydra: cannot change username, also update fullname
[13] JLDUSNUO * Unify rendering of finished and scheduled builds.
[14] S66BOMVU * Added authentication.
[15] MVB7RRLT * Move NARs from the NixChannel controller to the Root controller and
[16] J5UVLXOK * Start of a basic Catalyst web interface.
[17] QNYIOH25 * Generate a robots.txt.
[18] K42RSSSI
[19] AKAZKCR6 * At top-level and for each project, provide two channels: "latest"
[20] T2232OBS * Add some DB indices to make the /releases page much faster.
[21] 6FRLEP4P first try for timeline of last 24 hours in hydra
[22] ZWCTAZGL added newsitems, added some admin options to clear various caches.
[23] PBFZEQLZ
[24] QT4FO2HP refactored admin controller, using chains, to avoid using requireadmin on each endpoint
[25] 5IK6NYKF
[26] 4X6NS66Q * Keep the most recent builds for each job.
[27] FPK5LF53 * Put the project-related actions in a separate controller. Put the
[28] A52HEFHQ * Allow builds to be restarted (if they failed with a transient error,
[29] 5EV65EDZ * Generate robots.txt in a more Catalystic way.
[30] SMCOU72F hydra: add some admin for adding/enabling/etc build machines
[31] IN272KZW * Automatically keep all builds in the latest successful release in
[32] SZYDW2DG hydra: added some user admin
[33] SGNXIOI4 Hydra/32: Add option to force evaluation of a certain jobset via web interface (for admins only)
[34] FAZIT7T5 do not check username, as you are not allowed to change it
[35] RU7AQO7U * Role-based access control. Only admins can create projects. Only
[36] VHYWSRIS * Add nix version to footer of hydra pages
[37] EFWN7JBV * Added a status page that shows all the currently executing build steps.
[*] WZ3AEJ67 * hydra_update_gc_roots.pl registers build outputs that should be kept

Change contents

replacement in src/lib/Hydra/Controller/Admin.pm at line 20

[6.43]→[10.83:85](∅→∅),[10.83]→[10.83:85](∅→∅)

[6.43]

[10.85]
replacement in src/lib/Hydra/Controller/Admin.pm at line 41

[10.849]→[10.849:879](∅→∅)

close (NIXMACHINES);

[10.849]

[10.879]

close (NIXMACHINES);
replacement in src/lib/Hydra/Controller/Admin.pm at line 53

[10.981]→[10.981:994](∅→∅)

{},

[10.981]

[7.0]

{},
replacement in src/lib/Hydra/Controller/Admin.pm at line 60

[10.1376]→[10.1376:1472](∅→∅)

{ join => [ 'schedulingInfo', 'build' ]
, order_by => [ 'machine', 'outpath' ]

[10.1376]

[10.1472]

{ join => [ 'schedulingInfo', 'build' ]
, order_by => [ 'machine' ]
replacement in src/lib/Hydra/Controller/Admin.pm at line 65

[10.1491]→[10.233:235](∅→∅)

[10.1491]

[10.235]
replacement in src/lib/Hydra/Controller/Admin.pm at line 73

[10.538]→[10.538:601](∅→∅)

my $roles = $c->request->params->{"roles"} ;

[10.538]

[10.674]

my $roles = $c->request->params->{"roles"} ;
replacement in src/lib/Hydra/Controller/Admin.pm at line 84

[10.1005]→[10.1005:1022](∅→∅)

}

[10.1005]

[10.1022]

}
replacement in src/lib/Hydra/Controller/Admin.pm at line 87

[9.72]→[10.1089:1098](∅→∅),[10.1089]→[10.1089:1098](∅→∅)

}

[9.72]

[10.1098]

}
replacement in src/lib/Hydra/Controller/Admin.pm at line 126

[10.2007]→[10.2007:2047](∅→∅)

my ($to, $subject, $body) = @_;

[10.2007]

[10.2047]

my ($to, $subject, $body) = @_;
replacement in src/lib/Hydra/Controller/Admin.pm at line 130

[10.2132]→[10.2132:2136](∅→∅)

[10.2132]

[10.2136]
replacement in src/lib/Hydra/Controller/Admin.pm at line 148

[10.2536]→[10.2536:2541](∅→∅)

[10.2536]

[10.2541]
replacement in src/lib/Hydra/Controller/Admin.pm at line 157

[10.2692]→[10.2692:2725](∅→∅)

$c->user->emailaddress,

[10.2692]

[10.2725]

$c->user->emailaddress,
replacement in src/lib/Hydra/Controller/Admin.pm at line 216

[4.63]→[10.3210:3272](∅→∅),[10.3210]→[10.3210:3272](∅→∅)

my $systems = $c->request->params->{"systems"} ;

[4.63]

[10.3272]

my $systems = $c->request->params->{"systems"} ;
replacement in src/lib/Hydra/Controller/Admin.pm at line 222

[10.3631]→[10.3631:3637](∅→∅)

[10.3631]

[10.3637]
replacement in src/lib/Hydra/Controller/Admin.pm at line 234

[10.3998]→[10.3998:4012](∅→∅)

}

[10.3998]

[10.4012]

}
replacement in src/lib/Hydra/Controller/Admin.pm at line 237

[10.4100]→[10.4100:4109](∅→∅)

}

[10.4100]

[10.4109]

}
replacement in src/lib/Hydra/Controller/Admin.pm at line 244

[10.4235]→[10.4235:4240](∅→∅)

[10.4235]

[10.4240]
replacement in src/lib/Hydra/Controller/Admin.pm at line 256

[10.4578]→[10.4578:4583](∅→∅)

[10.4578]

[5.0]
replacement in src/lib/Hydra/Controller/Admin.pm at line 259

[10.4711]→[10.4711:4716](∅→∅)

[10.4711]

[10.4716]
replacement in src/lib/Hydra/Controller/Admin.pm at line 275

[10.5157]→[10.5157:5169](∅→∅)

});

[10.5157]

[10.5169]

});
replacement in src/lib/Hydra/Controller/Admin.pm at line 307

[10.921]→[10.921:926](∅→∅)

[10.921]

[10.926]
replacement in src/lib/Hydra/Controller/Admin.pm at line 325

[10.1346]→[10.1346:1389](∅→∅)

$c->stash->{template} = 'news.tt';

[10.1346]

[10.1389]

$c->stash->{template} = 'news.tt';
replacement in src/lib/Hydra/Controller/Admin.pm at line 332

[10.1516]→[10.1516:1521](∅→∅)

[10.1516]

[10.1521]
replacement in src/lib/Hydra/Controller/Admin.pm at line 335

[10.1607]→[10.1607:1612](∅→∅)

[10.1607]

[10.1612]
replacement in src/lib/Hydra/Controller/Admin.pm at line 353

[10.2123]→[10.2123:2132](∅→∅)

[10.2123]

[10.2132]
replacement in src/lib/Hydra/Controller/Admin.pm at line 359

[10.143]→[10.143:148](∅→∅)

[10.143]

[10.148]
replacement in src/lib/Hydra/Controller/Admin.pm at line 367

[10.508]→[10.508:513](∅→∅)

[10.508]

[10.513]
replacement in src/lib/Hydra/Controller/Admin.pm at line 369

[10.629]→[10.629:642](∅→∅)

[10.629]

[10.642]
replacement in src/lib/Hydra/Controller/Root.pm at line 18

[10.464]→[10.33:101](∅→∅)

$c->stash->{nixVersion} = $ENV{"NIX_RELEASE"} || "<devel>";

[10.464]

[10.101]

$c->stash->{nixVersion} = $ENV{"NIX_RELEASE"} || "<devel>";
replacement in src/lib/Hydra/Controller/Root.pm at line 40

[10.476]→[10.476:481](∅→∅)

[10.476]

[10.481]
replacement in src/lib/Hydra/Controller/Root.pm at line 61

[10.1022]→[10.1022:1027](∅→∅)

[10.1022]

[10.1027]
replacement in src/lib/Hydra/Controller/Root.pm at line 85

[3.22]→[3.22:52](∅→∅)

$c->stash->{pit} = $pit;

[3.22]

[3.52]

$c->stash->{pit} = $pit;
replacement in src/lib/Hydra/Controller/Root.pm at line 93

[10.375]→[10.375:542](∅→∅)

, '+select' => [ 'resultInfo.starttime', 'resultInfo.stoptime', 'resultInfo.buildstatus' ]
, '+as' => [ 'starttime', 'stoptime', 'buildstatus' ]

[10.375]

[10.542]

, '+select' => [ 'resultInfo.starttime', 'resultInfo.stoptime', 'resultInfo.buildstatus' ]
, '+as' => [ 'starttime', 'stoptime', 'buildstatus' ]
replacement in src/lib/Hydra/Controller/Root.pm at line 103

[10.544]→[10.5705:5754](∅→∅),[10.5754]→[10.584:631](∅→∅),[10.584]→[10.584:631](∅→∅)

{ join => [ 'schedulingInfo', 'build' ]
, order_by => [ 'machine', 'outpath' ]

[10.544]

[10.631]

{ join => [ 'schedulingInfo', 'build' ]
, order_by => [ 'machine' ]
replacement in src/lib/Hydra/Controller/Root.pm at line 161

[10.603]→[10.603:608](∅→∅)

[10.603]

[2.455]
replacement in src/lib/Hydra/Controller/Root.pm at line 166

[10.9653]→[10.9653:9658](∅→∅)

[10.9653]

[10.1511]
replacement in src/lib/Hydra/Controller/Root.pm at line 204

[10.3125]→[10.3125:3130](∅→∅)

[10.3125]

[10.3130]
replacement in src/lib/Hydra/Controller/Root.pm at line 206

[10.3172]→[10.3172:3230](∅→∅)

$c->stash->{template} = 'change-password.tt';

[10.3172]

[10.3230]

$c->stash->{template} = 'change-password.tt';
replacement in src/lib/Hydra/Controller/Root.pm at line 212

[10.3330]→[10.3330:3335](∅→∅)

[10.3330]

[10.3335]
replacement in src/lib/Hydra/Controller/Root.pm at line 214

[10.3377]→[10.3377:3437](∅→∅)

my $password = $c->request->params->{"password"};

[10.3377]

[10.3437]

my $password = $c->request->params->{"password"};
replacement in src/lib/Hydra/Controller/Root.pm at line 220

[10.3673]→[10.3673:3678](∅→∅)

[10.3673]

[10.3678]
replacement in src/lib/Hydra/Controller/Root.pm at line 223

[10.3763]→[10.3763:3800](∅→∅)

$c->res->redirect("/");

[10.3763]

[10.3800]

$c->res->redirect("/");
replacement in src/script/hydra_update_gc_roots.pl.in at line 49

[8.334]→[8.334:343](∅→∅)

[8.334]

[8.343]
replacement in src/script/hydra_update_gc_roots.pl.in at line 54

[8.503]→[10.1761:1770](∅→∅),[10.1761]→[10.1761:1770](∅→∅)

[8.503]

[10.1770]
replacement in src/script/hydra_update_gc_roots.pl.in at line 72

[10.2617]→[10.2617:2661](∅→∅)

, order_by => 'id DESC'

[10.2617]

[10.2661]

, order_by => 'me.id DESC'