hydra-evaluator: Fix error handling in fetching inputs

[?]
Sep 11, 2015, 11:49 AM
7OBWA6AZZ4THWIIJE5HZUPDFZ3Z5XKE6BSQ3I623PJVN6ZTKIAYQC

Dependencies

  • [2] NS7SND6R hydra-evaluator: Send statistics to statsd
  • [3] 7ZYBTNJJ revert unmeant previous change which caused errors to stay, even after successful evaluation of jobs
  • [4] RFE6T5LG * Store jobset evaluations in the database explicitly. This includes
  • [5] SS4TZXNU Distinguish between permanent evaluation errors and transient input errors
  • [6] 53PW36WS hydra-evaluator: When evaluating a single jobset, exit with a failure code if evaluation fails
  • [7] WQXF2T3D hydra-evaluator: Don't require $HYDRA_CONFIG
  • [8] LZO3C2KI * Hack around those SQLite timeouts: just retry the transaction.
  • [9] FYO6NECE hydra
  • [10] PCKLFRT5 Support push notification of repository changes
  • [11] NI5BVF2V * In job inputs of type "build", allow the project and jobset names of
  • [12] RXVJFQ5A Evaluator cleanups
  • [13] WVD3YYON hydra-evaluator: Add some debug code
  • [*] N22GPKYT * Put info about logs / build products in the DB.

Change contents

  • edit in src/script/hydra-evaluator at line 111
    [3.940]
    [2.124]
    my $fetchError = $@;
  • replacement in src/script/hydra-evaluator at line 117
    [2.341][3.940:954](),[3.940][3.940:954]()
    if ($@) {
    [2.341]
    [2.342]
    if ($fetchError) {
  • replacement in src/script/hydra-evaluator at line 119
    [2.410][3.954:1003](),[3.954][3.954:1003]()
    my $msg = $@;
    print STDERR $msg;
    [2.410]
    [3.1003]
    print STDERR $fetchError;
  • replacement in src/script/hydra-evaluator at line 121
    [3.1029][3.501:594]()
    $jobset->update({ lastcheckedtime => time, fetcherrormsg => $msg }) if !$dryRun;
    [3.1029]
    [3.1110]
    $jobset->update({ lastcheckedtime => time, fetcherrormsg => $fetchError }) if !$dryRun;
  • edit in src/script/hydra-evaluator at line 293
    [3.2247]
    [2.1239]
    my $checkError = $@;
  • replacement in src/script/hydra-evaluator at line 299
    [3.20][3.2252:2288](),[3.1454][3.2252:2288](),[3.2252][3.2252:2288](),[3.2288][3.1273:1300]()
    if ($@) {
    my $msg = $@;
    print STDERR $msg;
    [3.20]
    [3.1624]
    if ($checkError) {
    print STDERR $checkError;
  • replacement in src/script/hydra-evaluator at line 303
    [3.2437][3.135:178]()
    setJobsetError($jobset, $msg);
    [3.2437]
    [3.1013]
    setJobsetError($jobset, $checkError);