Fix Changes section on build page. Now shows the changes of the first evaluation a build was part of compared to the previous one. Also separated previous builds from the changes section, as that was confusing sometimes.

[?]
Nov 18, 2014, 10:00 AM
BYGDNBDF4BTA5YLCEKNDBMDZT5G5VNMW5LJHLB2CBHYH3TVJC7XQC

Dependencies

  • [2] UYWFRWQ6 Sort constituents by job name
  • [3] BW2MGEXM build.tt: Show jobset eval inputs instead of build inputs
  • [4] W74RIXTJ Show inputs and input changes on the jobset eval page
  • [5] R7MDDCB2 Some unnecessary job names
  • [6] 2GUAKGTB Fix indentation of build.tt
  • [7] XHK7IGYI * hdyra: show last succeeded build and changes since on build status summary if build has failed
  • [8] OIBSCXGI Use a popover to show how to use the build reproduction script
  • [9] TW5ZQX5Z * Move up the build products in the builds page, since they're more
  • [*] LBNVQXUB * Build the /build stuff in a separate controller.
  • [*] J5UVLXOK * Start of a basic Catalyst web interface.

Change contents

  • edit in src/lib/Hydra/Controller/Build.pm at line 110
    [2.1]
    [2.1]
    my ($eval2) = $c->stash->{eval}->jobset->jobsetevals->search(
    { hasnewbuilds => 1, id => { '<', $c->stash->{eval}->id } },
    { order_by => "id DESC", rows => 1 });
    $c->stash->{otherEval} = $eval2 if defined $eval2;
  • edit in src/root/build.tt at line 227
    [4.127]
    [4.5291]
    [% IF otherEval %]
    <h3>Changes</h3>
    [% INCLUDE renderInputDiff inputs2=eval.jobsetevalinputs inputs1=otherEval.jobsetevalinputs %]
    [% END %]
  • replacement in src/root/build.tt at line 233
    [4.5326][4.5326:5351]()
    <h3>Changes</h3>
    [4.5326]
    [4.5351]
    <h3>Previous builds</h3>
  • edit in src/root/build.tt at line 258
    [4.853][4.121:228]()
    <td>[% INCLUDE renderInputDiff inputs1=prevSuccessfulBuild.inputs inputs2=build.inputs %]</td>
  • edit in src/root/build.tt at line 386
    [3.89][3.89:301]()
    [% IF prevBuild %]
    <h3>Changes since previous [% INCLUDE renderBuildLink build=prevBuild %]</h3>
    [% INCLUDE renderInputDiff inputs2=build.inputs inputs1=prevBuild.inputs %]
    [% END %]