{"header":{"message":"Allow comparing an evaluation with an arbitrary other evaluation","description":"The URI parameter \"compare=...\" can denote either an arbitrary\nevaluation ID, or the name of a jobset in the same project. In the\nlatter case, the comparison is made against the latest completed\nevaluation of the specified jobset.","timestamp":"2012-04-02T18:40:59Z","authors":[{"email":"eelco.dolstra@logicblox.com","name":"Eelco Dolstra"}]},"hash":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC","authors":[],"deps":{"hashes":[["DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC","Allow comparing an evaluation with an arbitrary other evaluation"],["AA",null],["WZZOOYCHQJJ6BWQPJFXULOBVSLZXPMOKM2YNA7TPEXUINLXFVI5AC","Show queued builds in jobset evaluation pages"],["75XUS62YF7OK4S45RCZ5OOASXEBIEDNDBYEEMOCBDHVXV4GA3NLQC","* Added a page to quickly see all failed builds and failed evaluations"],["U4TD3AIQXBJFFUORTMIC4IHZTVBORRKL2TZ2FSP4G665ECZOEMNAC","Add support for viewing jobset evaluations"],["RSEGBU6CIEDRNTL7R6Q7RF2IZGCN3HH6VTPGFBKD77LSHEUD6EKAC","Hydra/20: Jobset clone feature"],["L7NUCXKSELV2XQBSETAN2KSXN5ONX3ESJDHZL6737LMK4KPGQANQC","Show new and removed jobs"],["GNIEG2GCT6BUYHY2WXUAQVKHSYB6TVQT52O5GEY6COLKFK4ODCCQC","* Disambiguate jobs by jobset name. I.e. jobs with the same name in"],["3HZY24CX4U2TO74HOY4YX3LBJIYF4DLXHCIY7J2RASAC4COMSMZAC","* Make jobsets viewable under"],["E5DMQRPO5BQ6KNA3C34U5JQQ5ZAZOJE2HTWM3JUVIG42LAVHPHFQC","Remove unnecessary whitespace in the HTML output"],["IK53RV4VGOHLCZGQCCIKPB45M3C7M7YMNBOJFBGZJ4LWIZNU4QNQC",""]],"deps":["WZZOOYCHQJJ6BWQPJFXULOBVSLZXPMOKM2YNA7TPEXUINLXFVI5AC"],"known":["GNIEG2GCT6BUYHY2WXUAQVKHSYB6TVQT52O5GEY6COLKFK4ODCCQC","3HZY24CX4U2TO74HOY4YX3LBJIYF4DLXHCIY7J2RASAC4COMSMZAC","75XUS62YF7OK4S45RCZ5OOASXEBIEDNDBYEEMOCBDHVXV4GA3NLQC","RSEGBU6CIEDRNTL7R6Q7RF2IZGCN3HH6VTPGFBKD77LSHEUD6EKAC","E5DMQRPO5BQ6KNA3C34U5JQQ5ZAZOJE2HTWM3JUVIG42LAVHPHFQC","U4TD3AIQXBJFFUORTMIC4IHZTVBORRKL2TZ2FSP4G665ECZOEMNAC","L7NUCXKSELV2XQBSETAN2KSXN5ONX3ESJDHZL6737LMK4KPGQANQC"]},"hunks":[{"Replacement":{"inode":{"change":3,"pos":104},"path":"src/lib/Hydra/Controller/Jobset.pm","line":354,"ins":{"up_context":[{"change":3,"pos":1155}],"down_context":[{"change":3,"pos":1277}],"flag":"BLOCK","start":0,"end":166,"inode":{"change":3,"pos":104}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1155},"to":{"change":3,"start":1155,"end":1277},"introduced_by":3}],"inode":{"change":3,"pos":104}},"ins_contents":[{"Add":{"text":" , '+as' => [ \"nrBuilds\", \"nrScheduled\", \"nrFinished\", \"nrSucceeded\" ]","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:77"}},{"Add":{"text":" , rows => $resultsPerPage + 1","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:115"}},{"Add":{"text":" , offset => ($page - 1) * $resultsPerPage","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:165"}}],"del_contents":[{"Del":{"text":"\t, '+as' => [ \"nrBuilds\", \"nrScheduled\", \"nrFinished\", \"nrSucceeded\" ]","pos":"U4TD3AIQXBJFFUORTMIC4IHZTVBORRKL2TZ2FSP4G665ECZOEMNAC:1225"}},{"Del":{"text":" , rows => $resultsPerPage","pos":"U4TD3AIQXBJFFUORTMIC4IHZTVBORRKL2TZ2FSP4G665ECZOEMNAC:1259"}},{"Del":{"text":"\t, page => $page","pos":"U4TD3AIQXBJFFUORTMIC4IHZTVBORRKL2TZ2FSP4G665ECZOEMNAC:1276"}}]}},{"Replacement":{"inode":{"change":3,"pos":1302},"path":"src/lib/Hydra/Controller/JobsetEval.pm","line":29,"ins":{"up_context":[{"change":3,"pos":1951}],"down_context":[{"change":3,"pos":2109}],"flag":"BLOCK","start":167,"end":1255,"inode":{"change":3,"pos":1302}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1951},"to":{"change":3,"start":1951,"end":2109},"introduced_by":3}],"inode":{"change":3,"pos":1302}},"ins_contents":[{"Add":{"text":" my $compare = $c->req->params->{compare};","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:212"}},{"Add":{"text":" my $eval2;","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:227"}},{"Add":{"text":"","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:228"}},{"Add":{"text":" # Allow comparing this evaluation against the previous evaluation","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:298"}},{"Add":{"text":" # (default), an arbitrary evaluation, or the latest completed","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:364"}},{"Add":{"text":" # evaluation of another jobset.","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:400"}},{"Add":{"text":" if (defined $compare && $compare =~ /^\\d+$/) {","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:451"}},{"Add":{"text":" $eval2 = $c->model('DB::JobsetEvals')->find($compare)","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:513"}},{"Add":{"text":" or notFound($c, \"Evaluation $compare doesn't exist.\");","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:580"}},{"Add":{"text":" } elsif (defined $compare && $compare =~ /^($jobNameRE)$/) {","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:645"}},{"Add":{"text":" my $j = $c->stash->{project}->jobsets->find({name => $compare})","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:717"}},{"Add":{"text":" or notFound($c, \"Jobset $compare doesn't exist.\");","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:780"}},{"Add":{"text":" ($eval2) = $j->jobsetevals->search(","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:824"}},{"Add":{"text":" { hasnewbuilds => 1 },","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:859"}},{"Add":{"text":" { order_by => \"id DESC\", rows => 1","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:906"}},{"Add":{"text":" , where => \\ \"not exists (select 1 from JobsetEvalMembers m join Builds b on m.build = b.id where m.eval = me.id and b.finished = 0)\"","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1052"}},{"Add":{"text":" });","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1068"}},{"Add":{"text":" } else {","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1081"}},{"Add":{"text":" ($eval2) = $eval->jobset->jobsetevals->search(","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1136"}},{"Add":{"text":" { hasnewbuilds => 1, id => { '<', $eval->id } },","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1197"}},{"Add":{"text":" { order_by => \"id DESC\", rows => 1 });","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1248"}},{"Add":{"text":" }","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1254"}}],"del_contents":[{"Del":{"text":" my ($eval2) = $eval->jobset->jobsetevals->search(","pos":"U4TD3AIQXBJFFUORTMIC4IHZTVBORRKL2TZ2FSP4G665ECZOEMNAC:2004"}},{"Del":{"text":" { hasnewbuilds => 1, id => { '<', $eval->id } },","pos":"U4TD3AIQXBJFFUORTMIC4IHZTVBORRKL2TZ2FSP4G665ECZOEMNAC:2061"}},{"Del":{"text":" { order_by => \"id DESC\", rows => 1 });","pos":"U4TD3AIQXBJFFUORTMIC4IHZTVBORRKL2TZ2FSP4G665ECZOEMNAC:2108"}}]}},{"Edit":{"inode":{"change":3,"pos":1302},"path":"src/lib/Hydra/Controller/JobsetEval.pm","line":52,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":2110}],"down_context":[{"change":3,"pos":2110}],"flag":"BLOCK","start":1256,"end":1316,"inode":{"change":3,"pos":1302}}},"contents":[{"Add":{"text":" $c->stash->{otherEval} = $eval2 if defined $eval2;","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1310"}},{"Add":{"text":" ","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1315"}}]}},{"Replacement":{"inode":{"change":3,"pos":1302},"path":"src/lib/Hydra/Controller/JobsetEval.pm","line":55,"ins":{"up_context":[{"change":3,"pos":2227}],"down_context":[{"change":3,"pos":2346}],"flag":"BLOCK","start":1317,"end":1474,"inode":{"change":3,"pos":1302}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":2227},"to":{"change":3,"start":2227,"end":2346},"introduced_by":3}],"inode":{"change":3,"pos":1302}},"ins_contents":[{"Add":{"text":" my @builds2 = defined $eval2","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1349"}},{"Add":{"text":" ? $eval2->builds->search({}, { order_by => [\"job\", \"system\", \"id\"], columns => [@buildListColumns] })","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1459"}},{"Add":{"text":" : ();","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1473"}}],"del_contents":[{"Del":{"text":" my @builds2 = $eval2->builds->search({}, { order_by => [\"job\", \"system\", \"id\"], columns => [@buildListColumns] });","pos":"U4TD3AIQXBJFFUORTMIC4IHZTVBORRKL2TZ2FSP4G665ECZOEMNAC:2345"}}]}},{"Edit":{"inode":{"change":3,"pos":1302},"path":"src/lib/Hydra/Controller/JobsetEval.pm","line":70,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":2675}],"down_context":[{"change":3,"pos":2675}],"flag":"BLOCK","start":1475,"end":1498,"inode":{"change":3,"pos":1302}}},"contents":[{"Add":{"text":" my $found = 0;","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1497"}}]}},{"Edit":{"inode":{"change":3,"pos":1302},"path":"src/lib/Hydra/Controller/JobsetEval.pm","line":75,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":2914}],"down_context":[{"change":3,"pos":3051}],"flag":"BLOCK","start":1499,"end":1529,"inode":{"change":3,"pos":1302}}},"contents":[{"Add":{"text":" last if $d == -1;","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1528"}}]}},{"Edit":{"inode":{"change":3,"pos":1302},"path":"src/lib/Hydra/Controller/JobsetEval.pm","line":78,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":81}],"down_context":[{"change":2,"pos":35}],"flag":"BLOCK","start":1530,"end":1558,"inode":{"change":3,"pos":1302}}},"contents":[{"Add":{"text":" $found = 1;","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1557"}}]}},{"Edit":{"inode":{"change":3,"pos":1302},"path":"src/lib/Hydra/Controller/JobsetEval.pm","line":91,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":136},"to":{"change":3,"start":136,"end":219},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":219},"to":{"change":3,"start":3776,"end":3798},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":3776},"to":{"change":3,"start":3776,"end":3798},"introduced_by":3}],"inode":{"change":3,"pos":1302}}},"contents":[{"Del":{"text":" } elsif ($d == -1) {","pos":"L7NUCXKSELV2XQBSETAN2KSXN5ONX3ESJDHZL6737LMK4KPGQANQC:168"}},{"Del":{"text":" push @{$c->stash->{new}}, $build;","pos":"L7NUCXKSELV2XQBSETAN2KSXN5ONX3ESJDHZL6737LMK4KPGQANQC:218"}},{"Del":{"text":" last;","pos":"U4TD3AIQXBJFFUORTMIC4IHZTVBORRKL2TZ2FSP4G665ECZOEMNAC:3797"}}]}},{"Edit":{"inode":{"change":3,"pos":1302},"path":"src/lib/Hydra/Controller/JobsetEval.pm","line":95,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":3840}],"down_context":[{"change":3,"pos":3840}],"flag":"BLOCK","start":1559,"end":1612,"inode":{"change":3,"pos":1302}}},"contents":[{"Add":{"text":" push @{$c->stash->{new}}, $build if !$found;","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1611"}}]}},{"Replacement":{"inode":{"change":11,"pos":2803},"path":"src/root/common.tt","line":41,"ins":{"up_context":[{"change":3,"pos":249}],"down_context":[{"change":3,"pos":1438}],"flag":"BLOCK","start":1613,"end":1697,"inode":{"change":11,"pos":2803}},"del":{"edges":[{"previous":"","flag":"DELETED","from":{"change":3,"pos":249},"to":{"change":3,"start":1348,"end":1438},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1348},"to":{"change":3,"start":1348,"end":1438},"introduced_by":3}],"inode":{"change":11,"pos":2803}},"ins_contents":[{"Add":{"text":"[% INCLUDE renderProjectName %]:[% INCLUDE renderJobsetName %]","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1684"}},{"Add":{"text":"[%- END -%]","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1696"}}],"del_contents":[{"Del":{"text":" ","pos":"75XUS62YF7OK4S45RCZ5OOASXEBIEDNDBYEEMOCBDHVXV4GA3NLQC:1354"}},{"Del":{"text":" [% INCLUDE renderProjectName %]:[% INCLUDE renderJobsetName %]","pos":"75XUS62YF7OK4S45RCZ5OOASXEBIEDNDBYEEMOCBDHVXV4GA3NLQC:1419"}},{"Del":{"text":" ","pos":"75XUS62YF7OK4S45RCZ5OOASXEBIEDNDBYEEMOCBDHVXV4GA3NLQC:1427"}},{"Del":{"text":"[% END %]","pos":"75XUS62YF7OK4S45RCZ5OOASXEBIEDNDBYEEMOCBDHVXV4GA3NLQC:1437"}}]}},{"Replacement":{"inode":{"change":3,"pos":4844},"path":"src/root/jobset-eval.tt","line":6,"ins":{"up_context":[{"change":3,"pos":4994}],"down_context":[{"change":3,"pos":5045}],"flag":"BLOCK","start":1698,"end":1992,"inode":{"change":3,"pos":4844}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4994},"to":{"change":3,"start":4994,"end":5045},"introduced_by":3}],"inode":{"change":3,"pos":4844}},"ins_contents":[{"Add":{"text":"[%- IF otherEval -%]","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1718"}},{"Add":{"text":"

Comparisons are relative to [% INCLUDE renderFullJobsetName","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1781"}},{"Add":{"text":"project=otherEval.jobset.project.name jobset=otherEval.jobset.name %]","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1851"}},{"Add":{"text":"evaluation [% otherEval.id %].

","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1979"}},{"Add":{"text":"[%- END -%]","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1991"}}],"del_contents":[{"Del":{"text":"","pos":"U4TD3AIQXBJFFUORTMIC4IHZTVBORRKL2TZ2FSP4G665ECZOEMNAC:5044"}}]}},{"Edit":{"inode":{"change":3,"pos":6334},"path":"src/root/jobset-evals.tt","line":7,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":6628}],"down_context":[{"change":3,"pos":6628}],"flag":"BLOCK","start":1993,"end":2068,"inode":{"change":3,"pos":6334}}},"contents":[{"Add":{"text":"","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:1993"}},{"Add":{"text":"[% nrShown = evals.size > resultsPerPage ? resultsPerPage : evals.size %]","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:2067"}}]}},{"Replacement":{"inode":{"change":3,"pos":6334},"path":"src/root/jobset-evals.tt","line":11,"ins":{"up_context":[{"change":3,"pos":6697}],"down_context":[{"change":3,"pos":6765}],"flag":"BLOCK","start":2069,"end":2134,"inode":{"change":3,"pos":6334}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":6697},"to":{"change":3,"start":6697,"end":6765},"introduced_by":3}],"inode":{"change":3,"pos":6334}},"ins_contents":[{"Add":{"text":"(page - 1) * resultsPerPage + nrShown %] out of [% total %].

","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:2133"}}],"del_contents":[{"Del":{"text":"(page - 1) * resultsPerPage + evals.size %] out of [% total %].

","pos":"U4TD3AIQXBJFFUORTMIC4IHZTVBORRKL2TZ2FSP4G665ECZOEMNAC:6764"}}]}},{"Replacement":{"inode":{"change":3,"pos":6334},"path":"src/root/jobset-evals.tt","line":24,"ins":{"up_context":[{"change":3,"pos":6943}],"down_context":[{"change":3,"pos":7045}],"flag":"BLOCK","start":2135,"end":2234,"inode":{"change":3,"pos":6334}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":6943},"to":{"change":3,"start":6943,"end":7045},"introduced_by":3}],"inode":{"change":3,"pos":6334}},"ins_contents":[{"Add":{"text":" [% last = nrShown - 1; FOREACH n IN [0..last]; eval = evals.$n; m = n + 1; next = evals.$m; %]","pos":"DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC:2233"}}],"del_contents":[{"Del":{"text":" [% last = evals.size - 2; FOREACH n IN [0..last]; eval = evals.$n; m = n + 1; next = evals.$m; %]","pos":"U4TD3AIQXBJFFUORTMIC4IHZTVBORRKL2TZ2FSP4G665ECZOEMNAC:7044"}}]}}],"owner":"grahamc","repo":"hydra2","token":"5UH6BQ/qvsSEc7P+kNpXzUpd5LpO9eh1jrGiqZJtnjg=","login":null}

…

Dependencies

Change contents

Review