Refactor code

[?]
Mar 26, 2020, 9:42 AM
F6UHDFJXXDNY5MHXOTH6S33MCSE7RXMQI3ZYJESK4QESFDT4FLLQC

Dependencies

  • [2] KUORZDSR Add slack plugin.
  • [3] MCMDIMNF SlackNotification: Use bigger images
  • [4] PM3ZQ36V Add documentation for SlackNotification plugin
  • [5] 6F3IODIR Add duration to Slack notification.

Change contents

  • edit in src/lib/Hydra/Plugin/SlackNotification.pm at line 90
    [2.668]
    [2.668]
    my $jobName = showJobName $b;
    my $buildStatus = $b->buildstatus;
    my $cancelledOrAborted = $buildStatus == 4 || $buildStatus == 3;
  • replacement in src/lib/Hydra/Plugin/SlackNotification.pm at line 95
    [2.714][2.714:752]()
    my $jobName = showJobName $b;
    [2.714]
    [2.752]
    my $sameAsPrevious = defined $prevBuild && ($buildStatus == $prevBuild->buildstatus);
  • replacement in src/lib/Hydra/Plugin/SlackNotification.pm at line 102
    [2.895][2.895:1042]()
    # If build is cancelled or aborted, do not send email.
    next if ! $force && ($b->buildstatus == 4 || $b->buildstatus == 3);
    [2.895]
    [2.1042]
    # If build is cancelled or aborted, do not send Slack notification.
    next if ! $force && $cancelledOrAborted;
  • replacement in src/lib/Hydra/Plugin/SlackNotification.pm at line 106
    [2.1121][2.1121:1277]()
    # with same buildstatus, do not send email.
    next if ! $force && defined $prevBuild && ($b->buildstatus == $prevBuild->buildstatus);
    [2.1121]
    [2.1277]
    # with same buildstatus, do not send Slack notification.
    next if ! $force && $sameAsPrevious;