{"header":{"message":"Output evaluation errors without crashing if aggregate job is broken.","description":"At the moment, aggregate jobs can easily break and cause the entire\nevaluation to fail, which is not ideal. For Nixpkgs, we do have some\nimportant aggregate jobs (like `tested`), but for debugging and building\npurposes it's still useful to get a partial result even if the channel\nwon't actually advance.\n\nThis commit changes the behaviour of hydra-eval-jobs such that it\naggregates any errors found during the construction of an aggregate, and\nwill instead annotate the job with the evaluation failure such that it\nshows up in a \"cleaner\" way.\n\nThere are really two types of failure that we care about: one is where\nthe attribute just ends up missing altogether in the final output, and\nalso where the attribute is in the output but fails to evaluate. Both\nare handled here.\n\nNote that this does mean that the same error message may be output\nmultiple times, but this aids debuggability because it'll be much\nclearer what's blocking the job from being created.","timestamp":"2021-09-22T20:54:58Z","authors":[{"email":"git@lukegb.com","name":"Luke Granger-Brown"}]},"hash":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC","authors":[],"deps":{"hashes":[["GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC","Output evaluation errors without crashing if aggregate job is broken."],["AA",null],["W7OCNTLFXNRGEHMQ5WBX4Z2Q6II3APKTLNWH76ZYZNRZDEVQACLAC","Fix build with latest Nix"],["HWGFAF2BD5TWDFUHWUYVNW4IEH3FNTZJEEN6MABYSHWO5ZBEZYVAC","queue runner: test notifications"],["VA3Z62HQORGCVMKEDRX7CDC3RE7ZCEUOD5F3GVJDIF2SG2TXTJ4QC","Revert \"Fix unhelpful error messages in aggregate jobs.\""],["VUYJ47EV5POBIZXKE37GNTS2OBHT7VDQLG7T7VAOMXBFXB2GWRGAC","hydra-eval-jobs: Parallelize"],["NQPGIRXXVS356MRCPVTV4LCCMUEOVHGCQGXJNPJTSK6HGLYZJKEQC","Revert \"hydra-eval-jobs -> nix eval-hydra-jobs\""],["6NUK6AZAZLOKFHXPS74YV52B63Z4BYQMPY42VAU5ZEACMZ663M2QC","Fix build"],["D4G756UKRXYU6QEKD6TGN2VAL7PDJMLBMQALHKDPZU3I6U5KVTYQC","hydra-eval-jobs: Identify unexpected errors in handling aggregate jobs"],["4DHGJ2FLM2QZTDKOYCXJQV4EDLRPOAOT7P7RGACCM5NFRRDX3AZAC","Fix build"],["2JJP76737U2JWJWQ6UDFEAQCGWRAQH46HC6OCIKWMB5QYRXF6DQQC","tests: move to t, allow `yath test` from root"]],"deps":["W7OCNTLFXNRGEHMQ5WBX4Z2Q6II3APKTLNWH76ZYZNRZDEVQACLAC","HWGFAF2BD5TWDFUHWUYVNW4IEH3FNTZJEEN6MABYSHWO5ZBEZYVAC","VA3Z62HQORGCVMKEDRX7CDC3RE7ZCEUOD5F3GVJDIF2SG2TXTJ4QC"],"known":["NQPGIRXXVS356MRCPVTV4LCCMUEOVHGCQGXJNPJTSK6HGLYZJKEQC","VUYJ47EV5POBIZXKE37GNTS2OBHT7VDQLG7T7VAOMXBFXB2GWRGAC","6NUK6AZAZLOKFHXPS74YV52B63Z4BYQMPY42VAU5ZEACMZ663M2QC","4DHGJ2FLM2QZTDKOYCXJQV4EDLRPOAOT7P7RGACCM5NFRRDX3AZAC","D4G756UKRXYU6QEKD6TGN2VAL7PDJMLBMQALHKDPZU3I6U5KVTYQC"]},"hunks":[{"Edit":{"inode":{"change":5,"pos":530},"path":"src/hydra-eval-jobs/hydra-eval-jobs.cc","line":1,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":530},"to":{"change":5,"start":531,"end":546},"introduced_by":5}],"inode":{"change":5,"pos":530}}},"contents":[{"Del":{"text":"#include ","pos":"NQPGIRXXVS356MRCPVTV4LCCMUEOVHGCQGXJNPJTSK6HGLYZJKEQC:545"}}]}},{"Edit":{"inode":{"change":5,"pos":530},"path":"src/hydra-eval-jobs/hydra-eval-jobs.cc","line":3,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":18}],"down_context":[{"change":5,"pos":623}],"flag":"BLOCK","start":0,"end":45,"inode":{"change":5,"pos":530}}},"contents":[{"Add":{"text":"#include ","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:19"}},{"Add":{"text":"#include ","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:44"}}]}},{"Edit":{"inode":{"change":5,"pos":530},"path":"src/hydra-eval-jobs/hydra-eval-jobs.cc","line":445,"atom":{"NewVertex":{"up_context":[{"change":5,"pos":12789}],"down_context":[{"change":5,"pos":12789}],"flag":"BLOCK","start":46,"end":1042,"inode":{"change":5,"pos":530}}},"contents":[{"Add":{"text":"","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:46"}},{"Add":{"text":" std::unordered_map brokenJobs;","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:115"}},{"Add":{"text":" auto getNonBrokenJobOrRecordError = [&brokenJobs, &jobName, &state](","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:196"}},{"Add":{"text":" const std::string & childJobName) -> std::optional {","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:285"}},{"Add":{"text":" auto childJob = state->jobs.find(childJobName);","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:349"}},{"Add":{"text":" if (childJob == state->jobs.end()) {","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:402"}},{"Add":{"text":" printError(\"aggregate job '%s' references non-existent job '%s'\", jobName, childJobName);","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:512"}},{"Add":{"text":" brokenJobs[childJobName] = \"does not exist\";","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:577"}},{"Add":{"text":" return std::nullopt;","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:618"}},{"Add":{"text":" }","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:636"}},{"Add":{"text":" if (childJob->find(\"error\") != childJob->end()) {","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:702"}},{"Add":{"text":" std::string error = (*childJob)[\"error\"];","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:764"}},{"Add":{"text":" printError(\"aggregate job '%s' references broken job '%s': %s\", jobName, childJobName, error);","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:879"}},{"Add":{"text":" brokenJobs[childJobName] = error;","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:933"}},{"Add":{"text":" return std::nullopt;","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:974"}},{"Add":{"text":" }","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:992"}},{"Add":{"text":" return *childJob;","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:1026"}},{"Add":{"text":" };","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:1041"}}]}},{"Replacement":{"inode":{"change":5,"pos":530},"path":"src/hydra-eval-jobs/hydra-eval-jobs.cc","line":466,"ins":{"up_context":[{"change":4,"pos":87}],"down_context":[{"change":4,"pos":309}],"flag":"BLOCK","start":1043,"end":1204,"inode":{"change":5,"pos":530}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":87},"to":{"change":4,"start":87,"end":309},"introduced_by":4}],"inode":{"change":5,"pos":530}},"ins_contents":[{"Add":{"text":" auto job2 = getNonBrokenJobOrRecordError(jobName2);","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:1114"}},{"Add":{"text":" if (!job2) {","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:1147"}},{"Add":{"text":" continue;","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:1181"}},{"Add":{"text":" }","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:1203"}}],"del_contents":[{"Del":{"text":" auto job2 = state->jobs.find(jobName2);","pos":"VA3Z62HQORGCVMKEDRX7CDC3RE7ZCEUOD5F3GVJDIF2SG2TXTJ4QC:146"}},{"Del":{"text":" if (job2 == state->jobs.end())","pos":"VA3Z62HQORGCVMKEDRX7CDC3RE7ZCEUOD5F3GVJDIF2SG2TXTJ4QC:197"}},{"Del":{"text":" throw Error(\"aggregate job '%s' references non-existent job '%s'\", jobName, jobName2);","pos":"VA3Z62HQORGCVMKEDRX7CDC3RE7ZCEUOD5F3GVJDIF2SG2TXTJ4QC:308"}}]}},{"Replacement":{"inode":{"change":5,"pos":530},"path":"src/hydra-eval-jobs/hydra-eval-jobs.cc","line":478,"ins":{"up_context":[{"change":4,"pos":670}],"down_context":[{"change":4,"pos":892}],"flag":"BLOCK","start":1205,"end":1366,"inode":{"change":5,"pos":530}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":670},"to":{"change":4,"start":670,"end":892},"introduced_by":4}],"inode":{"change":5,"pos":530}},"ins_contents":[{"Add":{"text":" auto job2 = getNonBrokenJobOrRecordError(jobName2);","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:1276"}},{"Add":{"text":" if (!job2) {","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:1309"}},{"Add":{"text":" continue;","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:1343"}},{"Add":{"text":" }","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:1365"}}],"del_contents":[{"Del":{"text":" auto job2 = state->jobs.find(jobName2);","pos":"VA3Z62HQORGCVMKEDRX7CDC3RE7ZCEUOD5F3GVJDIF2SG2TXTJ4QC:729"}},{"Del":{"text":" if (job2 == state->jobs.end())","pos":"VA3Z62HQORGCVMKEDRX7CDC3RE7ZCEUOD5F3GVJDIF2SG2TXTJ4QC:780"}},{"Del":{"text":" throw Error(\"aggregate job '%s' references non-existent job '%s'\", jobName, jobName2);","pos":"VA3Z62HQORGCVMKEDRX7CDC3RE7ZCEUOD5F3GVJDIF2SG2TXTJ4QC:891"}}]}},{"Replacement":{"inode":{"change":5,"pos":530},"path":"src/hydra-eval-jobs/hydra-eval-jobs.cc","line":488,"ins":{"up_context":[{"change":5,"pos":2181}],"down_context":[{"change":5,"pos":14561}],"flag":"BLOCK","start":1367,"end":2065,"inode":{"change":5,"pos":530}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":2181},"to":{"change":4,"start":1230,"end":1854},"introduced_by":4}],"inode":{"change":5,"pos":530}},"ins_contents":[{"Add":{"text":" if (brokenJobs.empty()) {","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:1408"}},{"Add":{"text":" std::string drvName(drvPath.name());","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:1465"}},{"Add":{"text":" assert(hasSuffix(drvName, drvExtension));","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:1527"}},{"Add":{"text":" drvName.resize(drvName.size() - drvExtension.size());","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:1601"}},{"Add":{"text":" auto h = std::get(hashDerivationModulo(*store, drv, true));","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:1687"}},{"Add":{"text":" auto outPath = store->makeOutputPath(\"out\", h, drvName);","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:1764"}},{"Add":{"text":" drv.env[\"out\"] = store->printStorePath(outPath);","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:1833"}},{"Add":{"text":" drv.outputs.insert_or_assign(\"out\", DerivationOutput { .output = DerivationOutputInputAddressed { .path = outPath } });","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:1973"}},{"Add":{"text":" auto newDrvPath = store->printStorePath(writeDerivation(*store, drv));","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2064"}}],"del_contents":[{"Del":{"text":" std::string drvName(drvPath.name());","pos":"VA3Z62HQORGCVMKEDRX7CDC3RE7ZCEUOD5F3GVJDIF2SG2TXTJ4QC:1282"}},{"Del":{"text":" assert(hasSuffix(drvName, drvExtension));","pos":"VA3Z62HQORGCVMKEDRX7CDC3RE7ZCEUOD5F3GVJDIF2SG2TXTJ4QC:1340"}},{"Del":{"text":" drvName.resize(drvName.size() - drvExtension.size());","pos":"VA3Z62HQORGCVMKEDRX7CDC3RE7ZCEUOD5F3GVJDIF2SG2TXTJ4QC:1410"}},{"Del":{"text":" auto h = std::get(hashDerivationModulo(*store, drv, true));","pos":"VA3Z62HQORGCVMKEDRX7CDC3RE7ZCEUOD5F3GVJDIF2SG2TXTJ4QC:1492"}},{"Del":{"text":" auto outPath = store->makeOutputPath(\"out\", h, drvName);","pos":"VA3Z62HQORGCVMKEDRX7CDC3RE7ZCEUOD5F3GVJDIF2SG2TXTJ4QC:1565"}},{"Del":{"text":" drv.env[\"out\"] = store->printStorePath(outPath);","pos":"VA3Z62HQORGCVMKEDRX7CDC3RE7ZCEUOD5F3GVJDIF2SG2TXTJ4QC:1630"}},{"Del":{"text":" drv.outputs.insert_or_assign(\"out\", DerivationOutput { .output = DerivationOutputInputAddressed { .path = outPath } });","pos":"VA3Z62HQORGCVMKEDRX7CDC3RE7ZCEUOD5F3GVJDIF2SG2TXTJ4QC:1766"}},{"Del":{"text":" auto newDrvPath = store->printStorePath(writeDerivation(*store, drv));","pos":"VA3Z62HQORGCVMKEDRX7CDC3RE7ZCEUOD5F3GVJDIF2SG2TXTJ4QC:1853"}}]}},{"Replacement":{"inode":{"change":5,"pos":530},"path":"src/hydra-eval-jobs/hydra-eval-jobs.cc","line":498,"ins":{"up_context":[{"change":5,"pos":14562}],"down_context":[{"change":5,"pos":14647}],"flag":"BLOCK","start":2066,"end":2178,"inode":{"change":5,"pos":530}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":14562},"to":{"change":4,"start":1855,"end":1963},"introduced_by":4}],"inode":{"change":5,"pos":530}},"ins_contents":[{"Add":{"text":" debug(\"rewrote aggregate derivation %s -> %s\", store->printStorePath(drvPath), newDrvPath);","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2177"}}],"del_contents":[{"Del":{"text":" debug(\"rewrote aggregate derivation %s -> %s\", store->printStorePath(drvPath), newDrvPath);","pos":"VA3Z62HQORGCVMKEDRX7CDC3RE7ZCEUOD5F3GVJDIF2SG2TXTJ4QC:1962"}}]}},{"Replacement":{"inode":{"change":5,"pos":530},"path":"src/hydra-eval-jobs/hydra-eval-jobs.cc","line":500,"ins":{"up_context":[{"change":5,"pos":14648}],"down_context":[{"change":5,"pos":14765}],"flag":"BLOCK","start":2179,"end":2322,"inode":{"change":5,"pos":530}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":14648},"to":{"change":4,"start":1964,"end":2081},"introduced_by":4}],"inode":{"change":5,"pos":530}},"ins_contents":[{"Add":{"text":" job[\"drvPath\"] = newDrvPath;","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2227"}},{"Add":{"text":" job[\"outputs\"][\"out\"] = store->printStorePath(outPath);","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2303"}},{"Add":{"text":" }","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2321"}}],"del_contents":[{"Del":{"text":" job[\"drvPath\"] = newDrvPath;","pos":"VA3Z62HQORGCVMKEDRX7CDC3RE7ZCEUOD5F3GVJDIF2SG2TXTJ4QC:2008"}},{"Del":{"text":" job[\"outputs\"][\"out\"] = store->printStorePath(outPath);","pos":"VA3Z62HQORGCVMKEDRX7CDC3RE7ZCEUOD5F3GVJDIF2SG2TXTJ4QC:2080"}}]}},{"Edit":{"inode":{"change":5,"pos":530},"path":"src/hydra-eval-jobs/hydra-eval-jobs.cc","line":506,"atom":{"NewVertex":{"up_context":[{"change":5,"pos":14824}],"down_context":[{"change":5,"pos":9592}],"flag":"BLOCK","start":2323,"end":2600,"inode":{"change":5,"pos":530}}},"contents":[{"Add":{"text":"","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2323"}},{"Add":{"text":" if (!brokenJobs.empty()) {","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2362"}},{"Add":{"text":" std::stringstream ss;","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2400"}},{"Add":{"text":" for (const auto& [jobName, error] : brokenJobs) {","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2466"}},{"Add":{"text":" ss << jobName << \": \" << error << \"\\n\";","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2526"}},{"Add":{"text":" }","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2544"}},{"Add":{"text":" job[\"error\"] = ss.str();","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2585"}},{"Add":{"text":" }","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2599"}}]}},{"FileAdd":{"meta":{"basename":"broken-constituent.nix","metadata":0},"context":[{"change":11,"pos":1263}],"contents":[{"Add":{"text":"with import ./config.nix;","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2628"}},{"Add":{"text":"{","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2630"}},{"Add":{"text":" broken = mkDerivation {","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2656"}},{"Add":{"text":" name = \"broken\";","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2677"}},{"Add":{"text":" _hydraAggregate = true;","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2705"}},{"Add":{"text":" constituents = [","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2726"}},{"Add":{"text":" \"does-not-exist\"","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2749"}},{"Add":{"text":" \"does-not-evaluate\"","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2775"}},{"Add":{"text":" ];","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2782"}},{"Add":{"text":" builder = ./fail.sh;","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2807"}},{"Add":{"text":" };","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2812"}},{"Add":{"text":"","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2813"}},{"Add":{"text":" # does-not-exist doesn't exist.","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2847"}},{"Add":{"text":"","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2848"}},{"Add":{"text":" does-not-evaluate = assert false; {};","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2888"}},{"Add":{"text":"}","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2890"}}]}},{"FileAdd":{"meta":{"basename":"constituents.t","metadata":0},"context":[{"change":3,"pos":321}],"contents":[{"Add":{"text":"use feature 'unicode_strings';","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2971"}},{"Add":{"text":"use strict;","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2983"}},{"Add":{"text":"use warnings;","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:2997"}},{"Add":{"text":"use Setup;","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3008"}},{"Add":{"text":"","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3009"}},{"Add":{"text":"my %ctx = test_init();","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3032"}},{"Add":{"text":"","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3033"}},{"Add":{"text":"require Hydra::Schema;","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3056"}},{"Add":{"text":"require Hydra::Model::DB;","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3082"}},{"Add":{"text":"","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3083"}},{"Add":{"text":"use Test2::V0;","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3098"}},{"Add":{"text":"","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3099"}},{"Add":{"text":"my $db = Hydra::Model::DB->new;","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3131"}},{"Add":{"text":"hydra_setup($db);","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3149"}},{"Add":{"text":"","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3150"}},{"Add":{"text":"my $project = $db->resultset('Projects')->create({name => \"tests\", displayname => \"\", owner => \"root\"});","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3255"}},{"Add":{"text":"","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3256"}},{"Add":{"text":"my $jobset = createBaseJobset(\"broken-constituent\", \"broken-constituent.nix\", $ctx{jobsdir});","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3350"}},{"Add":{"text":"","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3351"}},{"Add":{"text":"ok(evalSucceeds($jobset), \"Evaluating jobs/broken-constituent.nix should exit with return code 0\");","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3465"}},{"Add":{"text":"is(nrQueuedBuildsForJobset($jobset), 0, \"Evaluating jobs/broken-constituent.nix should not queue any builds\");","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3576"}},{"Add":{"text":"","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3577"}},{"Add":{"text":"like(","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3583"}},{"Add":{"text":" $jobset->errormsg,","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3606"}},{"Add":{"text":" qr/^does-not-exist: does not exist$/m,","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3649"}},{"Add":{"text":" \"Evaluating jobs/broken-constituent.nix should log an error for does-not-exist\");","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3735"}},{"Add":{"text":"like(","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3741"}},{"Add":{"text":" $jobset->errormsg,","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3764"}},{"Add":{"text":" qr/^does-not-evaluate: error: assertion 'false' failed$/m,","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3827"}},{"Add":{"text":" \"Evaluating jobs/broken-constituent.nix should log an error for does-not-evaluate\");","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3916"}},{"Add":{"text":"","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3917"}},{"Add":{"text":"done_testing;","pos":"GOVMQVEDNIXFRAIBG5T2HGYSSHMFH542W5H67PFVG74L5T2JABIQC:3931"}}]}}],"owner":"grahamc","repo":"hydra2","token":"2OvIEVa6Hhm6WRQaMSwtwUpN0Db4tZO1NUcQjnv7IFA=","login":null}

…

Dependencies

Change contents

Review