{"header":{"message":"Re-implement log size limits","description":"The old queue runner already had this. However, we now store \"log\nlimit exceeded\" as a separate status code in the database.","timestamp":"2015-10-06T15:35:08Z","authors":[{"email":"eelco.dolstra@logicblox.com","name":"Eelco Dolstra"}]},"hash":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC","authors":[],"deps":{"hashes":[["HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC","Re-implement log size limits"],["AA",null],["MHVIT4JYWUYD4UCGB2AHLXWLX6B5SYE22BREERNGANT7RGGDUFOAC","Split hydra-queue-runner.cc more"],["AUMIJSEOUDEGOCN3YSBD7KXOWE2CD2HN2VHS54FWUBMGRUBJHDXQC","Fix remote building on Nix 1.10"],["AF74AH2SUN3FKWNP6ZMAL7Q5T6R5WJDWOPQFZA6SS52L7PWPCWNAC","Remove localhost hack"],["IK2UBDAU6QKUXHJG3SXJKYGIIXRDKI6UVRTFC6ZVDXDCGNCMEWVAC","Revive jobset scheduling"],["NAYQT2GTCJPBFRSK7CBFX655F2NGTBPICJSCYG2CSCQ5NRDHZG6QC","hydra-queue-runner: Use cmdBuildDerivation"],["N4IROACVZ4MU73J5SM6WXJMKQSFR3VN5SOKENNNZNEGMTGB2Q3HAC","Move buildRemote() into State"],["VZKB5CIEW7Z5YBRYFKIFBQODBCG2NPGGXU3F3VQ3BNKGP5WYCPBQC","Workaround for RemoteStore not supporting cmdBuildDerivation yet"],["5AIYUMTBY6TFQTBRP3MJ2PYWUMRF57I77NIVWYE74UMEVQMBWZVQC","Basic remote building"],["OCZ4LSGGSCMSLGC3C32D5JUYYHS5CIPOKOAMADEFAFZOFXJ3YY3AC","Automatically retry aborted builds"],["HJOEIMLRDVQ2KZI5HGL2HKGBM3AHP7YIKGKDAGFUNKRUXVRB24NAC","Refactor"],["J5UVLXOK6EDIL5I7VKWH4V2QDS4DPD7FHRK6XBWSXFRQS4JKXFZQC","* Start of a basic Catalyst web interface."],["UQQ4IL55WHYMXNSPOXEFBTZAPMP7LQ726THOR7INRCJDSYVOP3ZAC","Add a error type for \"unsupported system type\""],["24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC","Start of single-process hydra-queue-runner"],["IK53RV4VGOHLCZGQCCIKPB45M3C7M7YMNBOJFBGZJ4LWIZNU4QNQC",""],["HHOMBU7GGRAEXODSDY3WUHQGOSQ35OTGRNBWKKAS2D4YEIZTTNUAC","hydra-queue-runner: Implement timeouts"],["6KIJX24R5RRDR2UQMUAWHF3N6V6DKKL5URYSLB7IT4J5C3RO4G2AC","Get rid of unnecessary [%- and -%] tags"],["T6KISLR63EHMQ4QQI3Z46PSVQITCYNZL32K3AR2LKQ3K6ESOW3QQC","Fix indentation"],["N22GPKYTOLZLBGTGDATQDVZ4R5APZEAOIA7L32X4UXBH4XNI7MWAC","* Put info about logs / build products in the DB."],["BD3GRK4BQUGRQGTAILUITIH3RRSVUH6AKINVMMKYLBAAHAAUSB4AC","* Get rid of \"positive failures\" and separate log phases."],["JGLE5BRNJTMCZFZ33G2SGOQ4F3CIZAPMU3IXCNMR5NNSG5EJLX6QC","Add separate build step status codes for cached failures and timeouts"]],"deps":["MHVIT4JYWUYD4UCGB2AHLXWLX6B5SYE22BREERNGANT7RGGDUFOAC","AUMIJSEOUDEGOCN3YSBD7KXOWE2CD2HN2VHS54FWUBMGRUBJHDXQC","AF74AH2SUN3FKWNP6ZMAL7Q5T6R5WJDWOPQFZA6SS52L7PWPCWNAC"],"known":["5AIYUMTBY6TFQTBRP3MJ2PYWUMRF57I77NIVWYE74UMEVQMBWZVQC","OCZ4LSGGSCMSLGC3C32D5JUYYHS5CIPOKOAMADEFAFZOFXJ3YY3AC","N4IROACVZ4MU73J5SM6WXJMKQSFR3VN5SOKENNNZNEGMTGB2Q3HAC","NAYQT2GTCJPBFRSK7CBFX655F2NGTBPICJSCYG2CSCQ5NRDHZG6QC","VZKB5CIEW7Z5YBRYFKIFBQODBCG2NPGGXU3F3VQ3BNKGP5WYCPBQC","IK2UBDAU6QKUXHJG3SXJKYGIIXRDKI6UVRTFC6ZVDXDCGNCMEWVAC"]},"hunks":[{"Edit":{"inode":{"change":5,"pos":85},"path":"src/hydra-queue-runner/build-remote.cc","line":158,"atom":{"NewVertex":{"up_context":[{"change":5,"pos":165}],"down_context":[{"change":5,"pos":79}],"flag":"BLOCK","start":0,"end":33,"inode":{"change":5,"pos":85}}},"contents":[{"Add":{"text":" unsigned int remoteVersion;","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:31"}},{"Add":{"text":"","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:32"}}]}},{"Replacement":{"inode":{"change":5,"pos":85},"path":"src/hydra-queue-runner/build-remote.cc","line":161,"ins":{"up_context":[{"change":5,"pos":89}],"down_context":[{"change":5,"pos":172}],"flag":"BLOCK","start":34,"end":72,"inode":{"change":5,"pos":85}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":89},"to":{"change":5,"start":166,"end":221},"introduced_by":5}],"inode":{"change":5,"pos":85}},"ins_contents":[{"Add":{"text":" to << SERVE_MAGIC_1 << 0x202;","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:71"}}],"del_contents":[{"Del":{"text":" to << SERVE_MAGIC_1 << SERVE_PROTOCOL_VERSION;","pos":"NAYQT2GTCJPBFRSK7CBFX655F2NGTBPICJSCYG2CSCQ5NRDHZG6QC:220"}}]}},{"Replacement":{"inode":{"change":5,"pos":85},"path":"src/hydra-queue-runner/build-remote.cc","line":167,"ins":{"up_context":[{"change":5,"pos":533}],"down_context":[{"change":5,"pos":534}],"flag":"BLOCK","start":73,"end":168,"inode":{"change":5,"pos":85}},"del":{"edges":[{"previous":"","flag":"DELETED","from":{"change":5,"pos":533},"to":{"change":5,"start":379,"end":475},"introduced_by":5},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":379},"to":{"change":5,"start":379,"end":475},"introduced_by":5}],"inode":{"change":5,"pos":85}},"ins_contents":[{"Add":{"text":" remoteVersion = readInt(from);","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:111"}},{"Add":{"text":" if (GET_PROTOCOL_MAJOR(remoteVersion) != 0x200)","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:167"}}],"del_contents":[{"Del":{"text":" unsigned int version = readInt(from);","pos":"OCZ4LSGGSCMSLGC3C32D5JUYYHS5CIPOKOAMADEFAFZOFXJ3YY3AC:424"}},{"Del":{"text":" if (GET_PROTOCOL_MAJOR(version) != 0x200)","pos":"OCZ4LSGGSCMSLGC3C32D5JUYYHS5CIPOKOAMADEFAFZOFXJ3YY3AC:474"}}]}},{"Replacement":{"inode":{"change":5,"pos":85},"path":"src/hydra-queue-runner/build-remote.cc","line":170,"ins":{"up_context":[{"change":5,"pos":655}],"down_context":[{"change":5,"pos":268}],"flag":"BLOCK","start":169,"end":221,"inode":{"change":5,"pos":85}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":655},"to":{"change":4,"start":0,"end":46},"introduced_by":4}],"inode":{"change":5,"pos":85}},"ins_contents":[{"Add":{"text":" if (GET_PROTOCOL_MINOR(remoteVersion) >= 1)","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:220"}}],"del_contents":[{"Del":{"text":" if (GET_PROTOCOL_MINOR(version) >= 1)","pos":"AF74AH2SUN3FKWNP6ZMAL7Q5T6R5WJDWOPQFZA6SS52L7PWPCWNAC:45"}}]}},{"Replacement":{"inode":{"change":5,"pos":85},"path":"src/hydra-queue-runner/build-remote.cc","line":242,"ins":{"up_context":[{"change":5,"pos":919}],"down_context":[{"change":5,"pos":1009}],"flag":"BLOCK","start":222,"end":279,"inode":{"change":5,"pos":85}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":919},"to":{"change":5,"start":919,"end":1009},"introduced_by":5}],"inode":{"change":5,"pos":85}},"ins_contents":[{"Add":{"text":" to << cmdBuildPaths << PathSet({step->drvPath});","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:278"}}],"del_contents":[{"Del":{"text":" to << cmdBuildPaths << PathSet({step->drvPath}) << maxSilentTime << buildTimeout;","pos":"NAYQT2GTCJPBFRSK7CBFX655F2NGTBPICJSCYG2CSCQ5NRDHZG6QC:1008"}}]}},{"Replacement":{"inode":{"change":5,"pos":85},"path":"src/hydra-queue-runner/build-remote.cc","line":244,"ins":{"up_context":[{"change":5,"pos":1018}],"down_context":[{"change":5,"pos":4352}],"flag":"BLOCK","start":280,"end":481,"inode":{"change":5,"pos":85}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":1018},"to":{"change":3,"start":172,"end":268},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":268},"to":{"change":5,"start":1115,"end":1150},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":1115},"to":{"change":5,"start":1115,"end":1150},"introduced_by":5}],"inode":{"change":5,"pos":85}},"ins_contents":[{"Add":{"text":" to << cmdBuildDerivation << step->drvPath << basicDrv;","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:342"}},{"Add":{"text":" to << maxSilentTime << buildTimeout;","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:383"}},{"Add":{"text":" if (GET_PROTOCOL_MINOR(remoteVersion) >= 2)","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:431"}},{"Add":{"text":" to << 64 * 1024 * 1024; // == maxLogSize","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:480"}}],"del_contents":[{"Del":{"text":" to << cmdBuildDerivation << step->drvPath << basicDrv << maxSilentTime << buildTimeout;","pos":"AUMIJSEOUDEGOCN3YSBD7KXOWE2CD2HN2VHS54FWUBMGRUBJHDXQC:267"}},{"Del":{"text":" // FIXME: send maxLogSize.","pos":"NAYQT2GTCJPBFRSK7CBFX655F2NGTBPICJSCYG2CSCQ5NRDHZG6QC:1149"}}]}},{"Edit":{"inode":{"change":2,"pos":133},"path":"src/hydra-queue-runner/builder.cc","line":303,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":10515}],"down_context":[{"change":2,"pos":10515}],"flag":"BLOCK","start":482,"end":572,"inode":{"change":2,"pos":133}}},"contents":[{"Add":{"text":" result.status == BuildResult::LogLimitExceeded ? bsLogLimitExceeded :","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:571"}}]}},{"Edit":{"inode":{"change":2,"pos":133},"path":"src/hydra-queue-runner/builder.cc","line":308,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":10722}],"down_context":[{"change":2,"pos":10722}],"flag":"BLOCK","start":573,"end":664,"inode":{"change":2,"pos":133}}},"contents":[{"Add":{"text":" result.status == BuildResult::LogLimitExceeded ? bssLogLimitExceeded :","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:663"}}]}},{"Replacement":{"inode":{"change":2,"pos":133},"path":"src/hydra-queue-runner/builder.cc","line":317,"ins":{"up_context":[{"change":2,"pos":11117}],"down_context":[{"change":2,"pos":11177}],"flag":"BLOCK","start":665,"end":795,"inode":{"change":2,"pos":133}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":11117},"to":{"change":2,"start":11117,"end":11177},"introduced_by":2}],"inode":{"change":2,"pos":133}},"ins_contents":[{"Add":{"text":" result.status == BuildResult::TimedOut ||","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:726"}},{"Add":{"text":" result.status == BuildResult::LogLimitExceeded)","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:794"}}],"del_contents":[{"Del":{"text":" result.status == BuildResult::TimedOut)","pos":"MHVIT4JYWUYD4UCGB2AHLXWLX6B5SYE22BREERNGANT7RGGDUFOAC:11176"}}]}},{"Edit":{"inode":{"change":12,"pos":1128},"path":"src/hydra-queue-runner/state.hh","line":33,"atom":{"NewVertex":{"up_context":[{"change":12,"pos":1731}],"down_context":[{"change":12,"pos":1731}],"flag":"BLOCK","start":796,"end":825,"inode":{"change":12,"pos":1128}}},"contents":[{"Add":{"text":" bsLogLimitExceeded = 10,","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:824"}}]}},{"Edit":{"inode":{"change":12,"pos":1128},"path":"src/hydra-queue-runner/state.hh","line":44,"atom":{"NewVertex":{"up_context":[{"change":12,"pos":1867}],"down_context":[{"change":12,"pos":1867}],"flag":"BLOCK","start":826,"end":856,"inode":{"change":12,"pos":1128}}},"contents":[{"Add":{"text":" bssLogLimitExceeded = 10,","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:855"}}]}},{"Edit":{"inode":{"change":13,"pos":7350},"path":"src/root/build.tt","line":62,"atom":{"NewVertex":{"up_context":[{"change":14,"pos":869}],"down_context":[{"change":15,"pos":20001}],"flag":"BLOCK","start":857,"end":963,"inode":{"change":13,"pos":7350}}},"contents":[{"Add":{"text":" [% ELSIF step.status == 10 %]","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:900"}},{"Add":{"text":" Log limit exceeded","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:962"}}]}},{"Edit":{"inode":{"change":16,"pos":2803},"path":"src/root/common.tt","line":209,"atom":{"NewVertex":{"up_context":[{"change":17,"pos":1761}],"down_context":[{"change":18,"pos":4181}],"flag":"BLOCK","start":964,"end":1118,"inode":{"change":16,"pos":2803}}},"contents":[{"Add":{"text":" [% ELSIF buildstatus == 10 %]","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:997"}},{"Add":{"text":" $\"Log$ ","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:1117"}}]}},{"Edit":{"inode":{"change":16,"pos":2803},"path":"src/root/common.tt","line":240,"atom":{"NewVertex":{"up_context":[{"change":14,"pos":1014}],"down_context":[{"change":19,"pos":2353}],"flag":"BLOCK","start":1119,"end":1205,"inode":{"change":16,"pos":2803}}},"contents":[{"Add":{"text":" [% ELSIF buildstatus == 10 %]","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:1152"}},{"Add":{"text":" Log limit exceeded","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:1204"}}]}},{"Edit":{"inode":{"change":20,"pos":1},"path":"src/sql/hydra.sql","line":198,"atom":{"NewVertex":{"up_context":[{"change":14,"pos":1052}],"down_context":[{"change":21,"pos":4847}],"flag":"BLOCK","start":1206,"end":1238,"inode":{"change":20,"pos":1}}},"contents":[{"Add":{"text":" -- 10 = log limit exceeded","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:1237"}}]}},{"Edit":{"inode":{"change":20,"pos":1},"path":"src/sql/hydra.sql","line":270,"atom":{"NewVertex":{"up_context":[{"change":14,"pos":1090}],"down_context":[{"change":22,"pos":1051}],"flag":"BLOCK","start":1239,"end":1271,"inode":{"change":20,"pos":1}}},"contents":[{"Add":{"text":" -- 10 = log limit exceeded","pos":"HH3LID6L4WJZV6NEDVCLPCO6KF2NLUUV3VJPFNJUQZCIESK3JYSQC:1270"}}]}}],"owner":"grahamc","repo":"hydra2","token":"b3ti6pbNjEACQFu9xirX96j4T8WhRJk6/WfO6i435S4=","login":null}

…

Dependencies

Change contents

Review