{"header":{"message":"hydra-queue-runner: Implement timeouts","description":"Also, keep track of timeouts in the database as a distinct build\nstatus.","timestamp":"2015-06-17T11:32:06Z","authors":[{"email":"eelco.dolstra@logicblox.com","name":"Eelco Dolstra"}]},"hash":"HHOMBU7GGRAEXODSDY3WUHQGOSQ35OTGRNBWKKAS2D4YEIZTTNUAC","authors":[],"deps":{"hashes":[["HHOMBU7GGRAEXODSDY3WUHQGOSQ35OTGRNBWKKAS2D4YEIZTTNUAC","hydra-queue-runner: Implement timeouts"],["AA",null],["WDNUKCTNTDUCQMZYHZIGKFGREVQPHW5DAZ5SASANIHBMFQF7GPQQC","Queue monitor: Get only the fields we need"],["OCZ4LSGGSCMSLGC3C32D5JUYYHS5CIPOKOAMADEFAFZOFXJ3YY3AC","Automatically retry aborted builds"],["6TY4LNHHAUSZNFDN34CHUWMZSQN5I3LNOOSV457M44FDGZB76X4AC","Finish copyClosure"],["RYTQLATYOZ6ODIKYVJ63TC4OIQBXHSCV3NA2YD4NFP7443GQVSRQC","Keep track of failed paths in the Hydra database"],["2IQRXLWETU2RLXPYKBSZIUULDHS346BAHE2NLOMOWXC6WDAX2BYQC","Support cancelling builds"],["LJILHOJ7QYXNTMKDQS6OU4PVCXPQ27C5KMQWHDBELCYP7FG3ZFYAC","Create BuildSteps race-free"],["24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC","Start of single-process hydra-queue-runner"],["ENXUSMSVOU3AZFMH2ZXR4ZVPV2LRRQYQJ6IFX33YN6IH2ORSNSAAC","Make concurrency more robust"],["YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC","Implement a database connection pool"],["GKZN4UV75GV7GEHQGBM2O6UHN6CVSHA7BMASCUQSDIDYVUKKZL7AC","Make the queue monitor more robust, and better debug output"],["5AIYUMTBY6TFQTBRP3MJ2PYWUMRF57I77NIVWYE74UMEVQMBWZVQC","Basic remote building"],["UQQ4IL55WHYMXNSPOXEFBTZAPMP7LQ726THOR7INRCJDSYVOP3ZAC","Add a error type for \"unsupported system type\""],["C6HOMHZWMSC7ORGFUF5YG2ACKV2SCP26HL3UH6VXH6RNDYRXH5DAC","Don't try to handle SIGINT"],["IK53RV4VGOHLCZGQCCIKPB45M3C7M7YMNBOJFBGZJ4LWIZNU4QNQC",""],["U2X3Y53G6QFZFTINMADCGBGKZY3A4J4XNR2R2STUBDUOBIQW6YCAC","make sure status images always display for a list of builds"],["6KIJX24R5RRDR2UQMUAWHF3N6V6DKKL5URYSLB7IT4J5C3RO4G2AC","Get rid of unnecessary [%- and -%] tags"],["T6KISLR63EHMQ4QQI3Z46PSVQITCYNZL32K3AR2LKQ3K6ESOW3QQC","Fix indentation"],["N22GPKYTOLZLBGTGDATQDVZ4R5APZEAOIA7L32X4UXBH4XNI7MWAC","* Put info about logs / build products in the DB."],["PMNWRTGJ4GVSMSSAWSUD57B26PCRAHMZIQ5SIWJIK7A74ENKEQLAC","Add multiple output support"]],"deps":["WDNUKCTNTDUCQMZYHZIGKFGREVQPHW5DAZ5SASANIHBMFQF7GPQQC","OCZ4LSGGSCMSLGC3C32D5JUYYHS5CIPOKOAMADEFAFZOFXJ3YY3AC"],"known":["24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC","ENXUSMSVOU3AZFMH2ZXR4ZVPV2LRRQYQJ6IFX33YN6IH2ORSNSAAC","YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC","5AIYUMTBY6TFQTBRP3MJ2PYWUMRF57I77NIVWYE74UMEVQMBWZVQC","LJILHOJ7QYXNTMKDQS6OU4PVCXPQ27C5KMQWHDBELCYP7FG3ZFYAC","6TY4LNHHAUSZNFDN34CHUWMZSQN5I3LNOOSV457M44FDGZB76X4AC","RYTQLATYOZ6ODIKYVJ63TC4OIQBXHSCV3NA2YD4NFP7443GQVSRQC","2IQRXLWETU2RLXPYKBSZIUULDHS346BAHE2NLOMOWXC6WDAX2BYQC","GKZN4UV75GV7GEHQGBM2O6UHN6CVSHA7BMASCUQSDIDYVUKKZL7AC"]},"hunks":[{"Replacement":{"inode":{"change":4,"pos":85},"path":"src/hydra-queue-runner/build-remote.cc","line":112,"ins":{"up_context":[{"change":4,"pos":2872}],"down_context":[{"change":4,"pos":2925}],"flag":"BLOCK","start":0,"end":112,"inode":{"change":4,"pos":85}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":2872},"to":{"change":4,"start":2872,"end":2925},"introduced_by":4}],"inode":{"change":4,"pos":85}},"ins_contents":[{"Add":" const nix::Path & logDir, unsigned int maxSilentTime, unsigned int buildTimeout,"},{"Add":" RemoteResult & result)"}],"del_contents":[{"Del":" const nix::Path & logDir, RemoteResult & result)\n"}]}},{"Replacement":{"inode":{"change":4,"pos":85},"path":"src/hydra-queue-runner/build-remote.cc","line":156,"ins":{"up_context":[{"change":4,"pos":4251}],"down_context":[{"change":4,"pos":4352}],"flag":"BLOCK","start":113,"end":209,"inode":{"change":4,"pos":85}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":4251},"to":{"change":4,"start":4251,"end":4352},"introduced_by":4}],"inode":{"change":4,"pos":85}},"ins_contents":[{"Add":" writeInt(maxSilentTime, to);"},{"Add":" writeInt(buildTimeout, to);"},{"Add":" // FIXME: send maxLogSize."}],"del_contents":[{"Del":" writeInt(3600, to); // == maxSilentTime, FIXME\n writeInt(7200, to); // == buildTimeout, FIXME\n"}]}},{"Replacement":{"inode":{"change":4,"pos":5249},"path":"src/hydra-queue-runner/build-remote.hh","line":21,"ins":{"up_context":[{"change":4,"pos":5729}],"down_context":[],"flag":"BLOCK","start":210,"end":323,"inode":{"change":4,"pos":5249}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":5729},"to":{"change":4,"start":5729,"end":5783},"introduced_by":4}],"inode":{"change":4,"pos":5249}},"ins_contents":[{"Add":" const nix::Path & logDir, unsigned int maxSilentTime, unsigned int buildTimeout,"},{"Add":" RemoteResult & result);"}],"del_contents":[{"Del":" const nix::Path & logDir, RemoteResult & result);\n"}]}},{"Edit":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":46,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":5180}],"down_context":[{"change":14,"pos":0}],"flag":"BLOCK","start":324,"end":344,"inode":{"change":4,"pos":4840}}},"contents":[{"Add":" bsTimedOut = 7,"}]}},{"Edit":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":55,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":5271}],"down_context":[{"change":14,"pos":24}],"flag":"BLOCK","start":345,"end":366,"inode":{"change":4,"pos":4840}}},"contents":[{"Add":" bssTimedOut = 7,"}]}},{"Edit":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":82,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":171}],"down_context":[{"change":4,"pos":171}],"flag":"BLOCK","start":367,"end":413,"inode":{"change":4,"pos":4840}}},"contents":[{"Add":" unsigned int maxSilentTime, buildTimeout;"}]}},{"Replacement":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":487,"ins":{"up_context":[{"change":4,"pos":1836}],"down_context":[{"change":4,"pos":9906}],"flag":"BLOCK","start":414,"end":591,"inode":{"change":4,"pos":4840}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":1836},"to":{"change":2,"start":0,"end":157},"introduced_by":2}],"inode":{"change":4,"pos":4840}},"ins_contents":[{"Add":" auto res = txn.parameterized(\"select id, project, jobset, job, drvPath, maxsilent, timeout from Builds where id > $1 and finished = 0 order by id\")(lastBuildId).exec();"}],"del_contents":[{"Del":" auto res = txn.parameterized(\"select id, project, jobset, job, drvPath from Builds where id > $1 and finished = 0 order by id\")(lastBuildId).exec();\n"}]}},{"Edit":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":499,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":2450}],"down_context":[{"change":4,"pos":10056}],"flag":"BLOCK","start":592,"end":795,"inode":{"change":4,"pos":4840}}},"contents":[{"Add":" build->maxSilentTime = row[\"maxsilent\"].as();"},{"Add":" build->buildTimeout = row[\"timeout\"].as();"},{"Add":" std::cerr << build->id << \" \" << build->buildTimeout << std::endl;"}]}},{"Replacement":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":984,"ins":{"up_context":[{"change":4,"pos":15294}],"down_context":[{"change":4,"pos":8135}],"flag":"BLOCK","start":796,"end":995,"inode":{"change":4,"pos":4840}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":15294},"to":{"change":4,"start":1843,"end":2010},"introduced_by":4}],"inode":{"change":4,"pos":4840}},"ins_contents":[{"Add":" printMsg(lvlInfo, format(\"performing step ‘%1%’ on ‘%2%’ (needed by build %3% and %4% others)\")"},{"Add":" % step->drvPath % machine->sshName % build->id % (dependents.size() - 1));"}],"del_contents":[{"Del":" printMsg(lvlInfo, format(\"performing step ‘%1%’ on ‘%2%’ (needed by %3% builds)\")\n % step->drvPath % machine->sshName % dependents.size());\n"}]}},{"Replacement":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":1014,"ins":{"up_context":[{"change":4,"pos":999}],"down_context":[{"change":4,"pos":1108}],"flag":"BLOCK","start":996,"end":1237,"inode":{"change":4,"pos":4840}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":999},"to":{"change":4,"start":999,"end":1108},"introduced_by":4}],"inode":{"change":4,"pos":4840}},"ins_contents":[{"Add":" /* FIXME: referring builds may have conflicting timeouts. */"},{"Add":" buildRemote(store, machine->sshName, machine->sshKey, step->drvPath, step->drv,"},{"Add":" logDir, build->maxSilentTime, build->buildTimeout, result);"}],"del_contents":[{"Del":" buildRemote(store, machine->sshName, machine->sshKey, step->drvPath, step->drv, logDir, result);\n"}]}},{"Replacement":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":1077,"ins":{"up_context":[{"change":3,"pos":4613}],"down_context":[{"change":3,"pos":4703}],"flag":"BLOCK","start":1238,"end":1417,"inode":{"change":4,"pos":4840}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4613},"to":{"change":3,"start":4613,"end":4703},"introduced_by":3}],"inode":{"change":4,"pos":4840}},"ins_contents":[{"Add":" result.status == RemoteResult::rrPermanentFailure ? bsFailed :"},{"Add":" result.status == RemoteResult::rrTimedOut ? bsTimedOut :"},{"Add":" bsAborted;"}],"del_contents":[{"Del":" result.status == RemoteResult::rrPermanentFailure ? bsFailed : bsAborted;\n"}]}},{"Replacement":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":1081,"ins":{"up_context":[{"change":3,"pos":4749}],"down_context":[{"change":3,"pos":4841}],"flag":"BLOCK","start":1418,"end":1600,"inode":{"change":4,"pos":4840}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4749},"to":{"change":3,"start":4749,"end":4841},"introduced_by":3}],"inode":{"change":4,"pos":4840}},"ins_contents":[{"Add":" result.status == RemoteResult::rrPermanentFailure ? bssFailed :"},{"Add":" result.status == RemoteResult::rrTimedOut ? bssTimedOut :"},{"Add":" bssAborted;"}],"del_contents":[{"Del":" result.status == RemoteResult::rrPermanentFailure ? bssFailed : bssAborted;\n"}]}},{"Edit":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":1238,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":14778}],"down_context":[{"change":15,"pos":40}],"flag":"BLOCK","start":1601,"end":1616,"inode":{"change":4,"pos":4840}}},"contents":[{"Add":" sleep(5);"},{"Add":""}]}},{"Edit":{"inode":{"change":16,"pos":2803},"path":"src/root/common.tt","line":207,"atom":{"NewVertex":{"up_context":[{"change":17,"pos":688}],"down_context":[{"change":18,"pos":4181}],"flag":"BLOCK","start":1617,"end":1761,"inode":{"change":16,"pos":2803}}},"contents":[{"Add":" [% ELSIF buildstatus == 7 %]"},{"Add":" $\"Timed$ "}]}},{"Edit":{"inode":{"change":16,"pos":2803},"path":"src/root/common.tt","line":234,"atom":{"NewVertex":{"up_context":[{"change":19,"pos":2353}],"down_context":[{"change":14,"pos":924}],"flag":"BLOCK","start":1762,"end":1838,"inode":{"change":16,"pos":2803}}},"contents":[{"Add":" [% ELSIF buildstatus == 7 %]"},{"Add":" Timed out"}]}},{"Edit":{"inode":{"change":20,"pos":1},"path":"src/sql/hydra.sql","line":183,"atom":{"NewVertex":{"up_context":[{"change":21,"pos":19738}],"down_context":[{"change":14,"pos":1015}],"flag":"BLOCK","start":1839,"end":1862,"inode":{"change":20,"pos":1}}},"contents":[{"Add":" -- 7 = timed out"}]}}],"owner":"grahamc","repo":"hydra2","token":"iDf8PJts1jKyJhyuo0aXl5eUiz/KexVZRNBwaL8jrxU=","login":null}

…

Dependencies

Change contents