input-types: use is() for test comparisons
[?]
Feb 23, 2021, 7:52 PM
HRBL4HYREOAGDMCUQQHTNL3BIKAUXDBIYUPX63SASSVGGXTOO3NACDependencies
- [2]
ZTYKNDOLMove tests for SCM inputs in to its own .t
Change contents
- edit in tests/input-types.t at line 86
my $nixexpr = $scm->{"nixexpr"};my $type = $scm->{"type"};my $uri = $scm->{"uri"};my $update = $scm->{"update"};my $jobset = createJobsetWithOneInput($scmName, $nixexpr, "src", $type, $uri); - replacement in tests/input-types.t at line 87
my $state = 0;my $q = 0;my ($loop, $updated) = updateRepository($scmName, $update);while($loop) {my $c = 0;subtest "With the SCM input named $scmName" => sub {my $nixexpr = $scm->{"nixexpr"};my $type = $scm->{"type"};my $uri = $scm->{"uri"};my $update = $scm->{"update"};my $jobset = createJobsetWithOneInput($scmName, $nixexpr, "src", $type, $uri); - replacement in tests/input-types.t at line 94
# Verify that it can be fetched and possibly queued.ok(evalSucceeds($jobset), "$scmName:$state.$c: Evaluating nix-expression."); $c++;my $state = 0;my $q = 0;my ($loop, $updated) = updateRepository($scmName, $update);while($loop) {subtest "Mutation number $state" => sub {# Verify that it can be fetched and possibly queued.ok(evalSucceeds($jobset), "Evaluating nix-expression."); - replacement in tests/input-types.t at line 102
# Verify that the evaluation has queued a new job and evaluate again to ...if ($updated) {$q++;ok(nrQueuedBuildsForJobset($jobset) == $q, "$scmName:$state.$c: Expect $q jobs in the queue."); $c++;ok(evalSucceeds($jobset), "$scmName:$state.$c: Evaluating nix-expression again."); $c++;}# Verify that the evaluation has queued a new job and evaluate again to ...if ($updated) {$q++;is(nrQueuedBuildsForJobset($jobset), $q, "Expect $q jobs in the queue.");ok(evalSucceeds($jobset), "Evaluating nix-expression again.");} - replacement in tests/input-types.t at line 109
# ... check that it is deterministic and not queued again.ok(nrQueuedBuildsForJobset($jobset) == $q, "$scmName:$state.$c: Expect $q jobs in the queue."); $c++;# ... check that it is deterministic and not queued again.is(nrQueuedBuildsForJobset($jobset), $q, "Expect deterministic evaluation."); - replacement in tests/input-types.t at line 112
$state++;($loop, $updated) = updateRepository($scmName, $update, getcwd . "/$scmName-repo/");}$state++;($loop, $updated) = updateRepository($scmName, $update, getcwd . "/$scmName-repo/");};}};