Use "can" to check whether a plugin supports buildFinished

[?]
May 8, 2013, 3:54 PM
IUCHXUJPTNTLOMKTLVDFUKFYLWZHE7MHRZWU3F35RNJR7XM4XJTAC

Dependencies

  • [2] MNZ67UXO If a build step fail, immediately fail all queued builds that depend on it
  • [3] 5EQYVRWE Add a plugin mechanism
  • [4] KA45EBF5 * Send email if a build fails.
  • [5] 7YBYT2LQ
  • [6] CXRCPDSQ * added support for twitter notification
  • [7] OG7BEM57
  • [*] L2E6EVE2 * Merged the Build and Job tables.

Change contents

  • edit in src/script/hydra-build at line 80
    [2.1577]
    [9.7330]
    sub notify {
    my ($build, $dependents) = @_;
    foreach my $plugin (Hydra::Plugin->plugins) {
    next unless $plugin->can('buildFinished');
    eval {
    $plugin->buildFinished($db, $config, $build, []);
    };
    if ($@) {
    print STDERR "$plugin->buildFinished: $@\n";
    }
    }
    }
  • replacement in src/script/hydra-build at line 305
    [4.874][3.6363:6592]()
    foreach my $plugin (Hydra::Plugin->plugins) {
    eval {
    $plugin->buildFinished($db, $config, $build, []);
    };
    if ($@) {
    print STDERR "$plugin->buildFinished: $@\n";
    }
    }
    [4.874]
    [4.6647]
    notify($build, []);
  • replacement in src/script/hydra-build at line 314
    [3.6651][3.6651:6731]()
    $_->buildFinished($db, $config, $build, []) foreach Hydra::Plugin->plugins;
    [3.6651]
    [4.1071]
    notify($build, []);