{"header":{"message":"Fix showing build steps in the machine status page","description":"This was broken because of the comparison\n\n step.machine.match('@(.*)').0 == m.key\n\nwhere m.key contains the SSH user.\n\nAlso some style tweaks.","timestamp":"2013-04-23T12:24:48Z","authors":[{"email":"eelco.dolstra@logicblox.com","name":"Eelco Dolstra"}]},"hash":"J4R2VCPPXW6QPVIDNXVHFRTDAZAPLAFBBBPIQZLZVPUHFXCO67TAC","authors":[],"deps":{"hashes":[["J4R2VCPPXW6QPVIDNXVHFRTDAZAPLAFBBBPIQZLZVPUHFXCO67TAC","Fix showing build steps in the machine status page"],["AA",null],["HTL6HIBMRGSX2H2H7KB4MC3H6UQ5C752VC3UHC43SRA7V66PQCRQC","machine-status: Read /etc/nix.machines instead of using the BuildMachines table"],["BOAFFKUX23KQE2TEM3525BLE52VQESGQOSV42VEIA4PAP37EHD3QC","Active build steps: Make the rows clickable"],["PZL3SZM3U3BYJX2RGYXC6NMBG7WQHFWHSYDYXZ7Q5VZA3EDYVPIQC","Give every page a consistent title"],["EFWN7JBV7YIHNMCA6ZGFRSHZIUQJ2EX57SWYGVT7ZRJCHPIM2R3QC","* Added a status page that shows all the currently executing build steps."],["ZWCTAZGLJZQNTYWTC2XQUKMILJF6JGDL5IND6QNYWK4FIGMLRFXAC","added newsitems, added some admin options to clear various caches."],["V6S6OYIAW3ZCBP6UHUYAZGG4P237WBB6HDG5NQIF3E5YFDTQRA4AC","Formatting tweaks"],["FFEH62DEVPZZXGRZR5IYOQIP7MZVGRMFAYCY7DDZCPOC7ZUL6D2QC","Machine status page now looks much better and more consistent with rest of Hydra"],["SMCOU72FKTPFNCDXFJAILVUWFE4DY33CJJE4436H5POKENFFDFFAC","hydra: add some admin for adding/enabling/etc build machines"]],"deps":["HTL6HIBMRGSX2H2H7KB4MC3H6UQ5C752VC3UHC43SRA7V66PQCRQC"],"known":["ZWCTAZGLJZQNTYWTC2XQUKMILJF6JGDL5IND6QNYWK4FIGMLRFXAC","EFWN7JBV7YIHNMCA6ZGFRSHZIUQJ2EX57SWYGVT7ZRJCHPIM2R3QC","SMCOU72FKTPFNCDXFJAILVUWFE4DY33CJJE4436H5POKENFFDFFAC","FFEH62DEVPZZXGRZR5IYOQIP7MZVGRMFAYCY7DDZCPOC7ZUL6D2QC","PZL3SZM3U3BYJX2RGYXC6NMBG7WQHFWHSYDYXZ7Q5VZA3EDYVPIQC","V6S6OYIAW3ZCBP6UHUYAZGG4P237WBB6HDG5NQIF3E5YFDTQRA4AC","BOAFFKUX23KQE2TEM3525BLE52VQESGQOSV42VEIA4PAP37EHD3QC"]},"hunks":[{"Edit":{"inode":{"change":3,"pos":8348},"path":"src/root/machine-status.tt","line":6,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":222}],"down_context":[{"change":3,"pos":9525}],"flag":"BLOCK","start":0,"end":62,"inode":{"change":3,"pos":8348}}},"contents":[{"Add":{"text":" [% name = m.key ? m.key.match('@(.*)').0 : \"localhost\" %]","pos":"J4R2VCPPXW6QPVIDNXVHFRTDAZAPLAFBBBPIQZLZVPUHFXCO67TAC:61"}}]}},{"Replacement":{"inode":{"change":3,"pos":8348},"path":"src/root/machine-status.tt","line":10,"ins":{"up_context":[{"change":3,"pos":259}],"down_context":[{"change":3,"pos":416}],"flag":"BLOCK","start":63,"end":129,"inode":{"change":3,"pos":8348}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":259},"to":{"change":2,"start":1400,"end":1459},"introduced_by":2}],"inode":{"change":3,"pos":8348}},"ins_contents":[{"Add":{"text":" [% IF !m.key || m.value.maxJobs %]","pos":"J4R2VCPPXW6QPVIDNXVHFRTDAZAPLAFBBBPIQZLZVPUHFXCO67TAC:107"}},{"Add":{"text":" Enabled:","pos":"J4R2VCPPXW6QPVIDNXVHFRTDAZAPLAFBBBPIQZLZVPUHFXCO67TAC:128"}}],"del_contents":[{"Del":{"text":" [% IF m.value.maxJobs > 0 %]","pos":"HTL6HIBMRGSX2H2H7KB4MC3H6UQ5C752VC3UHC43SRA7V66PQCRQC:1438"}},{"Del":{"text":" Running","pos":"HTL6HIBMRGSX2H2H7KB4MC3H6UQ5C752VC3UHC43SRA7V66PQCRQC:1458"}}]}},{"Replacement":{"inode":{"change":3,"pos":8348},"path":"src/root/machine-status.tt","line":13,"ins":{"up_context":[{"change":3,"pos":437}],"down_context":[{"change":3,"pos":729}],"flag":"BLOCK","start":130,"end":391,"inode":{"change":3,"pos":8348}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":437},"to":{"change":2,"start":1460,"end":1641},"introduced_by":2}],"inode":{"change":3,"pos":8348}},"ins_contents":[{"Add":{"text":" Disabled:","pos":"J4R2VCPPXW6QPVIDNXVHFRTDAZAPLAFBBBPIQZLZVPUHFXCO67TAC:151"}},{"Add":{"text":" [% END %] [% name %]","pos":"J4R2VCPPXW6QPVIDNXVHFRTDAZAPLAFBBBPIQZLZVPUHFXCO67TAC:191"}},{"Add":{"text":" [% IF m.value.systemTypes %]","pos":"J4R2VCPPXW6QPVIDNXVHFRTDAZAPLAFBBBPIQZLZVPUHFXCO67TAC:230"}},{"Add":{"text":" ([% comma=0; FOREACH system IN m.value.systemTypes %][% IF comma; %], [% ELSE; comma = 1; END %][% system %][% END %])","pos":"J4R2VCPPXW6QPVIDNXVHFRTDAZAPLAFBBBPIQZLZVPUHFXCO67TAC:370"}},{"Add":{"text":" [% END %]","pos":"J4R2VCPPXW6QPVIDNXVHFRTDAZAPLAFBBBPIQZLZVPUHFXCO67TAC:390"}}],"del_contents":[{"Del":{"text":" Stopped","pos":"HTL6HIBMRGSX2H2H7KB4MC3H6UQ5C752VC3UHC43SRA7V66PQCRQC:1479"}},{"Del":{"text":" [% END %] [% m.key %] ([% comma=0; FOREACH system IN m.value.systemTypes %][% IF comma; %], [% ELSE; comma = 1; END; system; END %])","pos":"HTL6HIBMRGSX2H2H7KB4MC3H6UQ5C752VC3UHC43SRA7V66PQCRQC:1640"}}]}},{"Replacement":{"inode":{"change":3,"pos":8348},"path":"src/root/machine-status.tt","line":24,"ins":{"up_context":[{"change":3,"pos":811}],"down_context":[{"change":3,"pos":812}],"flag":"BLOCK","start":392,"end":504,"inode":{"change":3,"pos":8348}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":811},"to":{"change":2,"start":1642,"end":1698},"introduced_by":2}],"inode":{"change":3,"pos":8348}},"ins_contents":[{"Add":{"text":" [% name2 = step.machine ? step.machine.match('@(.*)').0 : \"localhost\" %]","pos":"J4R2VCPPXW6QPVIDNXVHFRTDAZAPLAFBBBPIQZLZVPUHFXCO67TAC:472"}},{"Add":{"text":" [% IF name == name2 %]","pos":"J4R2VCPPXW6QPVIDNXVHFRTDAZAPLAFBBBPIQZLZVPUHFXCO67TAC:503"}}],"del_contents":[{"Del":{"text":" [% IF step.machine.match('@(.*)').0 == m.key %]","pos":"HTL6HIBMRGSX2H2H7KB4MC3H6UQ5C752VC3UHC43SRA7V66PQCRQC:1697"}}]}},{"Replacement":{"inode":{"change":3,"pos":8348},"path":"src/root/machine-status.tt","line":32,"ins":{"up_context":[{"change":3,"pos":1215}],"down_context":[{"change":3,"pos":1316}],"flag":"BLOCK","start":505,"end":612,"inode":{"change":3,"pos":8348}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1215},"to":{"change":3,"start":1215,"end":1316},"introduced_by":3}],"inode":{"change":3,"pos":8348}},"ins_contents":[{"Add":{"text":" [% INCLUDE renderDuration duration = curTime - step.starttime %] ","pos":"J4R2VCPPXW6QPVIDNXVHFRTDAZAPLAFBBBPIQZLZVPUHFXCO67TAC:611"}}],"del_contents":[{"Del":{"text":" [% INCLUDE renderDuration duration = curTime - step.starttime %] ","pos":"V6S6OYIAW3ZCBP6UHUYAZGG4P237WBB6HDG5NQIF3E5YFDTQRA4AC:1315"}}]}},{"Replacement":{"inode":{"change":3,"pos":8348},"path":"src/root/machine-status.tt","line":40,"ins":{"up_context":[{"change":2,"pos":1863}],"down_context":[{"change":2,"pos":1915}],"flag":"BLOCK","start":613,"end":664,"inode":{"change":3,"pos":8348}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":1863},"to":{"change":2,"start":1863,"end":1915},"introduced_by":2}],"inode":{"change":3,"pos":8348}},"ins_contents":[{"Add":{"text":" Never used","pos":"J4R2VCPPXW6QPVIDNXVHFRTDAZAPLAFBBBPIQZLZVPUHFXCO67TAC:663"}}],"del_contents":[{"Del":{"text":" Never built","pos":"HTL6HIBMRGSX2H2H7KB4MC3H6UQ5C752VC3UHC43SRA7V66PQCRQC:1914"}}]}},{"Edit":{"inode":{"change":3,"pos":8348},"path":"src/root/machine-status.tt","line":47,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":10946},"to":{"change":3,"start":10946,"end":10948},"introduced_by":3}],"inode":{"change":3,"pos":8348}}},"contents":[{"Del":{"text":"","pos":"SMCOU72FKTPFNCDXFJAILVUWFE4DY33CJJE4436H5POKENFFDFFAC:10946"}},{"Del":{"text":"","pos":"SMCOU72FKTPFNCDXFJAILVUWFE4DY33CJJE4436H5POKENFFDFFAC:10947"}}]}},{"Replacement":{"inode":{"change":3,"pos":1151},"path":"src/root/status.tt","line":17,"ins":{"up_context":[{"change":3,"pos":5271}],"down_context":[{"change":3,"pos":5368}],"flag":"BLOCK","start":665,"end":768,"inode":{"change":3,"pos":1151}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":5271},"to":{"change":3,"start":5271,"end":5368},"introduced_by":3}],"inode":{"change":3,"pos":1151}},"ins_contents":[{"Add":{"text":" [% INCLUDE renderDuration duration = curTime - step.starttime %] ","pos":"J4R2VCPPXW6QPVIDNXVHFRTDAZAPLAFBBBPIQZLZVPUHFXCO67TAC:767"}}],"del_contents":[{"Del":{"text":" [% INCLUDE renderDuration duration = curTime - step.starttime %] ","pos":"PZL3SZM3U3BYJX2RGYXC6NMBG7WQHFWHSYDYXZ7Q5VZA3EDYVPIQC:5367"}}]}}],"owner":"grahamc","repo":"hydra2","token":"oYsTz+SmjKyE79P3iwYhWHbM4UbNspF1xIxGA41+ud4=","login":null}

…

Dependencies

Change contents

Review