{"header":{"message":"Show whether a job still exists","description":"In the dashboard and on the job page, indicate whether the job appears\nin the latest jobset eval. That way, the user gets some indication if\na job has accidentally disappeared (e.g. due to an evaluation error).","timestamp":"2014-04-08T16:49:10Z","authors":[{"email":"eelco.dolstra@logicblox.com","name":"Eelco Dolstra"}]},"hash":"JPTXSWBOYRZMQDAYCJZBXVABO6GFQQ3CFSLX4FPXKLIWURPEWKMAC","authors":[],"deps":{"hashes":[["JPTXSWBOYRZMQDAYCJZBXVABO6GFQQ3CFSLX4FPXKLIWURPEWKMAC","Show whether a job still exists"],["AA",null],["O757ISIS3BDTQOGYCHQXY5V2OCGX3UFL75WUSF33AZI43AE3H75QC","Remove unused function"],["KSBB33RE2PK5SFN7ZMOTZJQHZB4JYIIUUKWDSD3LSZ5GD465AJHQC","Add a dashboard"],["Y6AHH4THYQA43V77L43YM42DYRPCMDSWLUV4NKWAQYMPL4NTUIPQC","Remove the logfile and logSize columns from the database"],["OZDDUMVPLAIDDD4H43JOP75WYF6XOXL737GEUIHVDTKQAGFHYTBAC","Automatically chomp all [%...%] directives"],["ZH6B56XRZON7AGKUPGKABU2SWOIQSYBTXVOMR66X6P6MG25Y4WZAC","Try harder to find build logs"],["ZB3JV52WEKVFX4XGSQUX6PCM4XGF62MCQRZAAOKNK4JNGYO2P7QAC","Add a \"My jobsets\" tab to the dashboard"],["XKXMU5PVXDNCWV6JDO2VWHB4HRAXI3H4ADRSTBJ227WIJBLHRFJAC","Ellipsize long jobset/job names to prevent bootstrap navbar breakage"],["PF72JKWQ2CLEQUNOSCKQ3ETVDOZ5VQBZEHVZU2YVZCS4WZX5DSTQC","Add a \"My jobs\" tab to the dashboard"],["J5UVLXOK6EDIL5I7VKWH4V2QDS4DPD7FHRK6XBWSXFRQS4JKXFZQC","* Start of a basic Catalyst web interface."],["ODNCGFQ5FPKFI624BVMLW7PJ2EFJOR3TY66OCZM42UNNTWBCF2TQC","* Improved the navigation bar: don't include all projects (since that"],["WGUKOIQZOQ64I6OJHGR4RSRI2HPH4RXADNSPFBWRETKO7OWCET4QC","Fix indentation"]],"deps":["O757ISIS3BDTQOGYCHQXY5V2OCGX3UFL75WUSF33AZI43AE3H75QC","KSBB33RE2PK5SFN7ZMOTZJQHZB4JYIIUUKWDSD3LSZ5GD465AJHQC"],"known":["Y6AHH4THYQA43V77L43YM42DYRPCMDSWLUV4NKWAQYMPL4NTUIPQC","OZDDUMVPLAIDDD4H43JOP75WYF6XOXL737GEUIHVDTKQAGFHYTBAC","XKXMU5PVXDNCWV6JDO2VWHB4HRAXI3H4ADRSTBJ227WIJBLHRFJAC","ZH6B56XRZON7AGKUPGKABU2SWOIQSYBTXVOMR66X6P6MG25Y4WZAC","PF72JKWQ2CLEQUNOSCKQ3ETVDOZ5VQBZEHVZU2YVZCS4WZX5DSTQC","ZB3JV52WEKVFX4XGSQUX6PCM4XGF62MCQRZAAOKNK4JNGYO2P7QAC"]},"hunks":[{"Replacement":{"inode":{"change":11,"pos":6789},"path":"src/lib/Hydra/View/TT.pm","line":11,"ins":{"up_context":[{"change":4,"pos":41}],"down_context":[{"change":4,"pos":2156}],"flag":"BLOCK","start":0,"end":74,"inode":{"change":11,"pos":6789}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":41},"to":{"change":2,"start":0,"end":64},"introduced_by":2}],"inode":{"change":11,"pos":6789}},"ins_contents":[{"Add":{"text":" expose_methods => [qw/buildLogExists buildStepLogExists jobExists/]);","pos":"JPTXSWBOYRZMQDAYCJZBXVABO6GFQQ3CFSLX4FPXKLIWURPEWKMAC:73"}}],"del_contents":[{"Del":{"text":" expose_methods => [qw/buildLogExists buildStepLogExists/]);","pos":"O757ISIS3BDTQOGYCHQXY5V2OCGX3UFL75WUSF33AZI43AE3H75QC:63"}}]}},{"Edit":{"inode":{"change":11,"pos":6789},"path":"src/lib/Hydra/View/TT.pm","line":25,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":169}],"down_context":[{"change":11,"pos":6919}],"flag":"BLOCK","start":75,"end":479,"inode":{"change":11,"pos":6789}}},"contents":[{"Add":{"text":"# Check whether the given job is a member of the most recent jobset","pos":"JPTXSWBOYRZMQDAYCJZBXVABO6GFQQ3CFSLX4FPXKLIWURPEWKMAC:142"}},{"Add":{"text":"# evaluation.","pos":"JPTXSWBOYRZMQDAYCJZBXVABO6GFQQ3CFSLX4FPXKLIWURPEWKMAC:156"}},{"Add":{"text":"sub jobExists {","pos":"JPTXSWBOYRZMQDAYCJZBXVABO6GFQQ3CFSLX4FPXKLIWURPEWKMAC:172"}},{"Add":{"text":" my ($self, $c, $job) = @_;","pos":"JPTXSWBOYRZMQDAYCJZBXVABO6GFQQ3CFSLX4FPXKLIWURPEWKMAC:203"}},{"Add":{"text":" my $latestEval = $job->jobset->jobsetevals->search(","pos":"JPTXSWBOYRZMQDAYCJZBXVABO6GFQQ3CFSLX4FPXKLIWURPEWKMAC:259"}},{"Add":{"text":" { hasnewbuilds => 1},","pos":"JPTXSWBOYRZMQDAYCJZBXVABO6GFQQ3CFSLX4FPXKLIWURPEWKMAC:289"}},{"Add":{"text":" { rows => 1, order_by => [\"id desc\"] })->single;","pos":"JPTXSWBOYRZMQDAYCJZBXVABO6GFQQ3CFSLX4FPXKLIWURPEWKMAC:346"}},{"Add":{"text":" return 0 if !defined $latestEval; # can't happen","pos":"JPTXSWBOYRZMQDAYCJZBXVABO6GFQQ3CFSLX4FPXKLIWURPEWKMAC:399"}},{"Add":{"text":" return scalar($latestEval->builds->search({ job => $job->name })) != 0;","pos":"JPTXSWBOYRZMQDAYCJZBXVABO6GFQQ3CFSLX4FPXKLIWURPEWKMAC:475"}},{"Add":{"text":"}","pos":"JPTXSWBOYRZMQDAYCJZBXVABO6GFQQ3CFSLX4FPXKLIWURPEWKMAC:477"}},{"Add":{"text":"","pos":"JPTXSWBOYRZMQDAYCJZBXVABO6GFQQ3CFSLX4FPXKLIWURPEWKMAC:478"}}]}},{"Replacement":{"inode":{"change":3,"pos":5624},"path":"src/root/dashboard.tt","line":25,"ins":{"up_context":[{"change":3,"pos":6220}],"down_context":[{"change":3,"pos":6360}],"flag":"BLOCK","start":480,"end":689,"inode":{"change":3,"pos":5624}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":6220},"to":{"change":3,"start":6220,"end":6360},"introduced_by":3}],"inode":{"change":3,"pos":5624}},"ins_contents":[{"Add":{"text":" [% INCLUDE renderFullJobName project=j.job.get_column('project') jobset=j.job.get_column('jobset') job=j.job.name %]","pos":"JPTXSWBOYRZMQDAYCJZBXVABO6GFQQ3CFSLX4FPXKLIWURPEWKMAC:688"}}],"del_contents":[{"Del":{"text":" [% INCLUDE renderFullJobName project=j.job.get_column('project') jobset=j.job.get_column('jobset') job=j.job.name %]","pos":"KSBB33RE2PK5SFN7ZMOTZJQHZB4JYIIUUKWDSD3LSZ5GD465AJHQC:6359"}}]}},{"Edit":{"inode":{"change":12,"pos":7675},"path":"src/root/job.tt","line":8,"atom":{"NewVertex":{"up_context":[{"change":13,"pos":1}],"down_context":[{"change":13,"pos":1}],"flag":"BLOCK","start":690,"end":956,"inode":{"change":12,"pos":7675}}},"contents":[{"Add":{"text":"[% IF !jobExists(job) %]","pos":"JPTXSWBOYRZMQDAYCJZBXVABO6GFQQ3CFSLX4FPXKLIWURPEWKMAC:714"}},{"Add":{"text":"

This job is not a member of the latest evaluation of its jobset. This means it was","pos":"JPTXSWBOYRZMQDAYCJZBXVABO6GFQQ3CFSLX4FPXKLIWURPEWKMAC:902"}},{"Add":{"text":"removed or had an evaluation error.

","pos":"JPTXSWBOYRZMQDAYCJZBXVABO6GFQQ3CFSLX4FPXKLIWURPEWKMAC:944"}},{"Add":{"text":"[% END %]","pos":"JPTXSWBOYRZMQDAYCJZBXVABO6GFQQ3CFSLX4FPXKLIWURPEWKMAC:954"}},{"Add":{"text":"","pos":"JPTXSWBOYRZMQDAYCJZBXVABO6GFQQ3CFSLX4FPXKLIWURPEWKMAC:955"}}]}}],"owner":"grahamc","repo":"hydra2","token":"ozSGGQ6oqBMsE3z6wJXdsvyfJjFi/MzRra6lDeVJ79Y=","login":null}

…

Dependencies

Change contents

Review