queue-runner-status: fixup from perlcritic-level-2

Dependencies

• [2] LQDK2TS5 Test that each page listing evals works
• [3] LZVO64YG Merge in the first bits of the API work
• [4] EFWN7JBV * Added a status page that shows all the currently executing build steps.
• [5] 3ECTCHKL Make queue runner internal status available under /queue-runner-status
• [*] J5UVLXOK * Start of a basic Catalyst web interface.

Change contents

• replacement in src/lib/Hydra/Controller/Root.pm at line 171
  [3.347]→[3.347:406](∅→∅)
  − my $status = from_json(`hydra-queue-runner --status`);
  [3.347]

  [3.406]
  + my $status = decode_json(`hydra-queue-runner --status`);
• file addition: queue-runner-status.t (----------)
  [2.2122]
  + use strict;

  + use warnings;

  + use Setup;

  + use Data::Dumper;

  + my %ctx = test_init();

  +

  + require Hydra::Schema;

  + require Hydra::Model::DB;

  + require Hydra::Helper::Nix;

  +

  + use Test2::V0;

  + require Catalyst::Test;

  + use HTTP::Request::Common;

  + Catalyst::Test->import('Hydra');

  +

  + my $db = Hydra::Model::DB->new;

  + hydra_setup($db);

  +

  + my $project = $db->resultset('Projects')->create({name => "tests", displayname => "", owner => "root"});

  +

  + my $jobset = createBaseJobset("basic", "basic.nix", $ctx{jobsdir});

  +

  + ok(evalSucceeds($jobset), "Evaluating jobs/basic.nix should exit with return code 0");

  +

  + subtest "/queue-runner-status" => sub {

  + my $global = request(GET '/queue-runner-status');

  + ok($global->is_success, "The page showing the the queue runner status 200's.");

  + };

  +

  + done_testing;