{"header":{"message":"Speed up the jobset eval list a bit","description":null,"timestamp":"2012-04-15T22:11:20Z","authors":[{"email":"eelco.dolstra@logicblox.com","name":"Eelco Dolstra"}]},"hash":"KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC","authors":[],"deps":{"hashes":[["KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC","Speed up the jobset eval list a bit"],["AA",null],["HFJPPMTU45LWGNLX2V3JXBP2VPK2W6PPONF4TUSQAAH7ARDAD5HAC","Cleanup"],["RWFCW6ZNIE24XTEQUK5Y37K42BQER7EDGSSD4GQNFTGO5V4TY72QC","In the jobset evals lists, show what inputs changed between consecutive evals"],["KG5AMUMGZA53FMA35K3KYOPJTNG3BKWDFWDPVXJ6XGG2GJJRI2LAC","Cleanup"],["RSEGBU6CIEDRNTL7R6Q7RF2IZGCN3HH6VTPGFBKD77LSHEUD6EKAC","Hydra/20: Jobset clone feature"],["Q4VDOA762MDHLJKNJMPLHFYRRACCT3DQXF66ZTVMETZCR52B72OQC","Replace last 5 builds on jobset page with last 5 evaluations. Moved hide/unhide and evaluate options to jobset topmenu."],["3HZY24CX4U2TO74HOY4YX3LBJIYF4DLXHCIY7J2RASAC4COMSMZAC","* Make jobsets viewable under"],["IK53RV4VGOHLCZGQCCIKPB45M3C7M7YMNBOJFBGZJ4LWIZNU4QNQC",""]],"deps":["HFJPPMTU45LWGNLX2V3JXBP2VPK2W6PPONF4TUSQAAH7ARDAD5HAC"],"known":["RSEGBU6CIEDRNTL7R6Q7RF2IZGCN3HH6VTPGFBKD77LSHEUD6EKAC","Q4VDOA762MDHLJKNJMPLHFYRRACCT3DQXF66ZTVMETZCR52B72OQC","KG5AMUMGZA53FMA35K3KYOPJTNG3BKWDFWDPVXJ6XGG2GJJRI2LAC","RWFCW6ZNIE24XTEQUK5Y37K42BQER7EDGSSD4GQNFTGO5V4TY72QC"]},"hunks":[{"Replacement":{"inode":{"change":8,"pos":104},"path":"src/lib/Hydra/Controller/Jobset.pm","line":333,"ins":{"up_context":[{"change":3,"pos":200}],"down_context":[{"change":3,"pos":158}],"flag":"BLOCK","start":0,"end":74,"inode":{"change":8,"pos":104}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":200},"to":{"change":3,"start":200,"end":896},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":896},"to":{"change":3,"start":117,"end":145},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":145},"to":{"change":3,"start":920,"end":948},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":920},"to":{"change":3,"start":920,"end":948},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":948},"to":{"change":3,"start":146,"end":158},"introduced_by":3}],"inode":{"change":8,"pos":104}},"ins_contents":[{"Add":{"text":" { order_by => \"id DESC\", rows => $rows + 1, offset => $offset });","pos":"KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC:73"}}],"del_contents":[{"Del":{"text":" { order_by => \"id DESC\"","pos":"KG5AMUMGZA53FMA35K3KYOPJTNG3BKWDFWDPVXJ6XGG2GJJRI2LAC:231"}},{"Del":{"text":" , '+select' => # !!! Slow - should precompute this.","pos":"KG5AMUMGZA53FMA35K3KYOPJTNG3BKWDFWDPVXJ6XGG2GJJRI2LAC:291"}},{"Del":{"text":"\t [ \"(select count(*) from JobsetEvalMembers where eval = me.id)\"","pos":"KG5AMUMGZA53FMA35K3KYOPJTNG3BKWDFWDPVXJ6XGG2GJJRI2LAC:360"}},{"Del":{"text":"\t , \"(select count(*) from JobsetEvalMembers where eval = me.id and exists(select 1 from Builds b where b.id = build and b.finished = 0))\" ","pos":"KG5AMUMGZA53FMA35K3KYOPJTNG3BKWDFWDPVXJ6XGG2GJJRI2LAC:503"}},{"Del":{"text":"\t , \"(select count(*) from JobsetEvalMembers where eval = me.id and exists(select 1 from Builds b where b.id = build and b.finished = 1))\"","pos":"KG5AMUMGZA53FMA35K3KYOPJTNG3BKWDFWDPVXJ6XGG2GJJRI2LAC:645"}},{"Del":{"text":"\t , \"(select count(*) from JobsetEvalMembers where eval = me.id and exists(select 1 from Builds b where b.id = build and b.finished = 1 and b.buildStatus = 0))\" ","pos":"KG5AMUMGZA53FMA35K3KYOPJTNG3BKWDFWDPVXJ6XGG2GJJRI2LAC:810"}},{"Del":{"text":"\t ]","pos":"KG5AMUMGZA53FMA35K3KYOPJTNG3BKWDFWDPVXJ6XGG2GJJRI2LAC:817"}},{"Del":{"text":" , '+as' => [ \"nrBuilds\", \"nrScheduled\", \"nrFinished\", \"nrSucceeded\" ]","pos":"KG5AMUMGZA53FMA35K3KYOPJTNG3BKWDFWDPVXJ6XGG2GJJRI2LAC:895"}},{"Del":{"text":" , rows => $rows + 1","pos":"RWFCW6ZNIE24XTEQUK5Y37K42BQER7EDGSSD4GQNFTGO5V4TY72QC:144"}},{"Del":{"text":" , offset => $offset","pos":"KG5AMUMGZA53FMA35K3KYOPJTNG3BKWDFWDPVXJ6XGG2GJJRI2LAC:947"}},{"Del":{"text":" });","pos":"RWFCW6ZNIE24XTEQUK5Y37K42BQER7EDGSSD4GQNFTGO5V4TY72QC:157"}}]}},{"Edit":{"inode":{"change":8,"pos":104},"path":"src/lib/Hydra/Controller/Jobset.pm","line":337,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":25}],"down_context":[{"change":2,"pos":25}],"flag":"BLOCK","start":75,"end":89,"inode":{"change":8,"pos":104}}},"contents":[{"Add":{"text":" my $prev;","pos":"KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC:88"}}]}},{"Replacement":{"inode":{"change":8,"pos":104},"path":"src/lib/Hydra/Controller/Jobset.pm","line":340,"ins":{"up_context":[{"change":3,"pos":288}],"down_context":[{"change":3,"pos":323}],"flag":"BLOCK","start":90,"end":343,"inode":{"change":8,"pos":104}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":288},"to":{"change":3,"start":288,"end":323},"introduced_by":3}],"inode":{"change":8,"pos":104}},"ins_contents":[{"Add":{"text":"","pos":"KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC:90"}},{"Add":{"text":" # Get stats for this eval.","pos":"KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC:125"}},{"Add":{"text":" my $nrBuilds = $cur->jobsetevalmembers->count;","pos":"KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC:180"}},{"Add":{"text":" my $nrScheduled = $cur->builds->search({finished => 0})->count;","pos":"KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC:252"}},{"Add":{"text":" my $nrSucceeded = $cur->builds->search({finished => 1, buildStatus => 0})->count;","pos":"KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC:342"}}],"del_contents":[{"Del":{"text":" my $prev = $evals[$n + 1];","pos":"RWFCW6ZNIE24XTEQUK5Y37K42BQER7EDGSSD4GQNFTGO5V4TY72QC:322"}}]}},{"Replacement":{"inode":{"change":8,"pos":104},"path":"src/lib/Hydra/Controller/Jobset.pm","line":359,"ins":{"up_context":[{"change":2,"pos":212}],"down_context":[{"change":2,"pos":232}],"flag":"BLOCK","start":344,"end":362,"inode":{"change":8,"pos":104}},"del":{"edges":[{"previous":"","flag":"DELETED","from":{"change":2,"pos":212},"to":{"change":3,"start":1367,"end":1376},"introduced_by":2},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1367},"to":{"change":3,"start":1367,"end":1376},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1376},"to":{"change":2,"start":213,"end":232},"introduced_by":2}],"inode":{"change":8,"pos":104}},"ins_contents":[{"Add":{"text":"","pos":"KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC:344"}},{"Add":{"text":" my $e = ","pos":"KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC:361"}}],"del_contents":[{"Del":{"text":" ","pos":"RWFCW6ZNIE24XTEQUK5Y37K42BQER7EDGSSD4GQNFTGO5V4TY72QC:1375"}},{"Del":{"text":" push @res,","pos":"HFJPPMTU45LWGNLX2V3JXBP2VPK2W6PPONF4TUSQAAH7ARDAD5HAC:231"}}]}},{"Replacement":{"inode":{"change":8,"pos":104},"path":"src/lib/Hydra/Controller/Jobset.pm","line":362,"ins":{"up_context":[{"change":2,"pos":259}],"down_context":[{"change":2,"pos":368}],"flag":"BLOCK","start":363,"end":627,"inode":{"change":8,"pos":104}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":259},"to":{"change":2,"start":259,"end":368},"introduced_by":2}],"inode":{"change":8,"pos":104}},"ins_contents":[{"Add":{"text":" , nrBuilds => $nrBuilds","pos":"KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC:398"}},{"Add":{"text":" , nrScheduled => $nrScheduled","pos":"KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC:440"}},{"Add":{"text":" , nrSucceeded => $nrSucceeded","pos":"KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC:482"}},{"Add":{"text":" , nrFailed => $nrBuilds - $nrSucceeded - $nrScheduled","pos":"KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC:548"}},{"Add":{"text":" , diff => defined $prev ? $nrSucceeded - $prev->{nrSucceeded} : 0","pos":"KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC:626"}}],"del_contents":[{"Del":{"text":" , diff => defined $prev ? $cur->get_column(\"nrSucceeded\") - $prev->get_column(\"nrSucceeded\") : 0","pos":"HFJPPMTU45LWGNLX2V3JXBP2VPK2W6PPONF4TUSQAAH7ARDAD5HAC:367"}}]}},{"Edit":{"inode":{"change":8,"pos":104},"path":"src/lib/Hydra/Controller/Jobset.pm","line":369,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":433}],"down_context":[{"change":3,"pos":1465}],"flag":"BLOCK","start":628,"end":685,"inode":{"change":8,"pos":104}}},"contents":[{"Add":{"text":" push @res, $e if $n < $rows;","pos":"KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC:664"}},{"Add":{"text":" $prev = $e;","pos":"KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC:684"}}]}},{"Replacement":{"inode":{"change":8,"pos":104},"path":"src/lib/Hydra/Controller/Jobset.pm","line":373,"ins":{"up_context":[{"change":3,"pos":1476}],"down_context":[{"change":3,"pos":1560}],"flag":"BLOCK","start":686,"end":713,"inode":{"change":8,"pos":104}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1476},"to":{"change":2,"start":434,"end":477},"introduced_by":2}],"inode":{"change":8,"pos":104}},"ins_contents":[{"Add":{"text":" return [reverse @res];","pos":"KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC:712"}}],"del_contents":[{"Del":{"text":" return [(reverse @res)[0..$rows - 1]];","pos":"HFJPPMTU45LWGNLX2V3JXBP2VPK2W6PPONF4TUSQAAH7ARDAD5HAC:476"}}]}},{"Replacement":{"inode":{"change":9,"pos":2803},"path":"src/root/common.tt","line":442,"ins":{"up_context":[{"change":3,"pos":1388}],"down_context":[{"change":3,"pos":1739}],"flag":"BLOCK","start":714,"end":931,"inode":{"change":9,"pos":2803}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1388},"to":{"change":3,"start":1388,"end":1739},"introduced_by":3}],"inode":{"change":9,"pos":2803}},"ins_contents":[{"Add":{"text":" [% e.nrSucceeded %]","pos":"KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC:783"}},{"Add":{"text":" [% e.nrFailed %]","pos":"KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC:852"}},{"Add":{"text":"\t [% IF e.nrScheduled > 0 %]","pos":"KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC:881"}},{"Add":{"text":"\t [% e.nrScheduled %]","pos":"KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC:930"}}],"del_contents":[{"Del":{"text":" [% eval.get_column('nrSucceeded') %]","pos":"Q4VDOA762MDHLJKNJMPLHFYRRACCT3DQXF66ZTVMETZCR52B72OQC:1474"}},{"Del":{"text":" [% eval.get_column('nrBuilds') - eval.get_column('nrSucceeded') - eval.get_column('nrScheduled') %]","pos":"Q4VDOA762MDHLJKNJMPLHFYRRACCT3DQXF66ZTVMETZCR52B72OQC:1626"}},{"Del":{"text":"\t [% IF eval.get_column('nrScheduled') > 0 %]","pos":"Q4VDOA762MDHLJKNJMPLHFYRRACCT3DQXF66ZTVMETZCR52B72OQC:1672"}},{"Del":{"text":"\t [% eval.get_column('nrScheduled') %]","pos":"Q4VDOA762MDHLJKNJMPLHFYRRACCT3DQXF66ZTVMETZCR52B72OQC:1738"}}]}},{"Replacement":{"inode":{"change":9,"pos":2803},"path":"src/root/common.tt","line":451,"ins":{"up_context":[{"change":3,"pos":2476}],"down_context":[{"change":3,"pos":2542}],"flag":"BLOCK","start":932,"end":981,"inode":{"change":9,"pos":2803}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":2476},"to":{"change":3,"start":2476,"end":2542},"introduced_by":3}],"inode":{"change":9,"pos":2803}},"ins_contents":[{"Add":{"text":"\t [%- ELSIF e.diff < 0 && e.nrScheduled == 0 -%]","pos":"KJC7RKIEGIR62HPUILVCORKOFYTIAVNPHU3U2CDS36ZEQA7T7UBAC:980"}}],"del_contents":[{"Del":{"text":"\t [%- ELSIF e.diff < 0 && eval.get_column('nrScheduled') == 0 -%]","pos":"RWFCW6ZNIE24XTEQUK5Y37K42BQER7EDGSSD4GQNFTGO5V4TY72QC:2541"}}]}}],"owner":"grahamc","repo":"hydra2","token":"K5CdMnMu2rxRMZvhkf1zQ23wqxz3pHBsDvUHDOlSs3o=","login":null}

…

Dependencies

Change contents

Review