Prevent orphaned build steps

[?]
Oct 26, 2016, 12:42 PM
OBOTGFG63VKMKWE7AGSTNPDCJ42FGFDIVY6XYLJLS275Y7OE3FSQC

Dependencies

  • [2] 7LWB2J2Z Periodically clear orphaned build steps
  • [3] MHVIT4JY Split hydra-queue-runner.cc more
  • [4] BRAESISH Warn if PostgreSQL appears stalled
  • [5] UNVMKJV5 Unify build and step status codes
  • [6] FITVNQ2S Keep track of the time we spend copying to/from build machines
  • [7] HH3LID6L Re-implement log size limits
  • [8] NTEDD7T4 Provide a plugin hook for when build steps finish
  • [9] BG6PEOB2 Make the output size limit configurable

Change contents

  • edit in src/hydra-queue-runner/builder.cc at line 111
    [2.124]
    [2.124]
    printError("marking step %d of build %d as orphaned", stepNr, build->id);
  • edit in src/hydra-queue-runner/builder.cc at line 180
    [3.5347]
    [3.5347]
    assert(stepNr);
  • edit in src/hydra-queue-runner/builder.cc at line 201
    [3.2664]
    [3.5814]
    assert(stepNr);
  • edit in src/hydra-queue-runner/builder.cc at line 300
    [3.9316]
    [3.9316]
    /* For standard failures, we don't care about the error
    message. */
    if (result.stepStatus != bsAborted)
    result.errorMsg = "";
  • edit in src/hydra-queue-runner/builder.cc at line 311
    [3.9513][3.9513:9514]()
  • edit in src/hydra-queue-runner/builder.cc at line 326
    [3.10246][3.10246:10273]()
    break;
  • edit in src/hydra-queue-runner/builder.cc at line 328
    [3.10305]
    [3.10305]
    if (indirect.empty() && stepFinished) break;
  • edit in src/hydra-queue-runner/builder.cc at line 337
    [3.10807][3.10807:10910](),[3.10910][3.2749:2801](),[3.795][3.11177:11220](),[3.2801][3.11177:11220](),[3.11177][3.11177:11220]()
    /* For standard failures, we don't care about the error
    message. */
    if (result.stepStatus != bsAborted)
    result.errorMsg = "";
  • replacement in src/hydra-queue-runner/builder.cc at line 350
    [3.12003][3.3362:3420]()
    if (result.stepStatus != bsCachedFailure)
    [3.12003]
    [3.691]
    if (result.stepStatus != bsCachedFailure && !stepFinished) {
    assert(stepNr);
  • edit in src/hydra-queue-runner/builder.cc at line 354
    [3.3519]
    [3.12211]
    }