{"header":{"message":"Machine status: Don't show removed machines anymore","description":"This requires a sequential scan on the BuildSteps table, which by now\ntakes > 8s.","timestamp":"2013-04-23T13:20:24Z","authors":[{"email":"eelco.dolstra@logicblox.com","name":"Eelco Dolstra"}]},"hash":"RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC","authors":[],"deps":{"hashes":[["RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC","Machine status: Don't show removed machines anymore"],["AA",null],["BZUB3ZSH7ZVUTNQYNQYZOCZQ5UIQKDNBC5BJU3T6ITHZ2CERJJ5AC","Use get_column for 'as' column (max_stoptime)."],["J4R2VCPPXW6QPVIDNXVHFRTDAZAPLAFBBBPIQZLZVPUHFXCO67TAC","Fix showing build steps in the machine status page"],["SMCOU72FKTPFNCDXFJAILVUWFE4DY33CJJE4436H5POKENFFDFFAC","hydra: add some admin for adding/enabling/etc build machines"],["V6S6OYIAW3ZCBP6UHUYAZGG4P237WBB6HDG5NQIF3E5YFDTQRA4AC","Formatting tweaks"],["HTL6HIBMRGSX2H2H7KB4MC3H6UQ5C752VC3UHC43SRA7V66PQCRQC","machine-status: Read /etc/nix.machines instead of using the BuildMachines table"],["R2PON6R7RJT63XVKGEXAIKB76RHIQL3WCDTZQM5JLKAZ7B5AZAFQC","Allow non-admin users to see the machine status page"],["J5UVLXOK6EDIL5I7VKWH4V2QDS4DPD7FHRK6XBWSXFRQS4JKXFZQC","* Start of a basic Catalyst web interface."],["ZWCTAZGLJZQNTYWTC2XQUKMILJF6JGDL5IND6QNYWK4FIGMLRFXAC","added newsitems, added some admin options to clear various caches."]],"deps":["BZUB3ZSH7ZVUTNQYNQYZOCZQ5UIQKDNBC5BJU3T6ITHZ2CERJJ5AC","J4R2VCPPXW6QPVIDNXVHFRTDAZAPLAFBBBPIQZLZVPUHFXCO67TAC"],"known":["SMCOU72FKTPFNCDXFJAILVUWFE4DY33CJJE4436H5POKENFFDFFAC","R2PON6R7RJT63XVKGEXAIKB76RHIQL3WCDTZQM5JLKAZ7B5AZAFQC","V6S6OYIAW3ZCBP6UHUYAZGG4P237WBB6HDG5NQIF3E5YFDTQRA4AC","HTL6HIBMRGSX2H2H7KB4MC3H6UQ5C752VC3UHC43SRA7V66PQCRQC"]},"hunks":[{"Replacement":{"inode":{"change":9,"pos":804},"path":"src/lib/Hydra/Controller/Root.pm","line":78,"ins":{"up_context":[{"change":4,"pos":32}],"down_context":[{"change":4,"pos":346}],"flag":"BLOCK","start":0,"end":396,"inode":{"change":9,"pos":804}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":32},"to":{"change":4,"start":32,"end":278},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":278},"to":{"change":2,"start":0,"end":82},"introduced_by":2}],"inode":{"change":9,"pos":804}},"ins_contents":[{"Add":{"text":"","pos":"RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC:0"}},{"Add":{"text":" # Add entry for localhost.","pos":"RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC:31"}},{"Add":{"text":" ${$machines}{''} //= {};","pos":"RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC:60"}},{"Add":{"text":"","pos":"RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC:61"}},{"Add":{"text":" # Get the last finished build step for each machine.","pos":"RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC:118"}},{"Add":{"text":" foreach my $m (keys %{$machines}) {","pos":"RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC:158"}},{"Add":{"text":" my $idle = $c->model('DB::BuildSteps')->find(","pos":"RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC:212"}},{"Add":{"text":" { machine => \"$m\", stoptime => { '!=', undef } },","pos":"RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC:274"}},{"Add":{"text":" { order_by => 'stoptime desc', rows => 1 });","pos":"RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC:331"}},{"Add":{"text":" ${$machines}{$m}{'idle'} = $idle ? $idle->stoptime : 0;","pos":"RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC:395"}}],"del_contents":[{"Del":{"text":" my $idles = $c->model('DB::BuildSteps')->search(","pos":"HTL6HIBMRGSX2H2H7KB4MC3H6UQ5C752VC3UHC43SRA7V66PQCRQC:84"}},{"Del":{"text":" { stoptime => { '!=', undef } },","pos":"HTL6HIBMRGSX2H2H7KB4MC3H6UQ5C752VC3UHC43SRA7V66PQCRQC:129"}},{"Del":{"text":" { select => [ 'machine', { max => 'stoptime', -as => 'max_stoptime' }], group_by => \"machine\" });","pos":"HTL6HIBMRGSX2H2H7KB4MC3H6UQ5C752VC3UHC43SRA7V66PQCRQC:239"}},{"Del":{"text":" while (my $idle = $idles->next) {","pos":"HTL6HIBMRGSX2H2H7KB4MC3H6UQ5C752VC3UHC43SRA7V66PQCRQC:277"}},{"Del":{"text":" ${$machines}{$idle->machine}{'idle'} = $idle->get_column('max_stoptime');","pos":"BZUB3ZSH7ZVUTNQYNQYZOCZQ5UIQKDNBC5BJU3T6ITHZ2CERJJ5AC:81"}}]}},{"Edit":{"inode":{"change":9,"pos":804},"path":"src/lib/Hydra/Controller/Root.pm","line":89,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":352}],"down_context":[{"change":4,"pos":352}],"flag":"BLOCK","start":397,"end":402,"inode":{"change":9,"pos":804}}},"contents":[{"Add":{"text":" ","pos":"RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC:401"}}]}},{"Replacement":{"inode":{"change":10,"pos":8348},"path":"src/root/machine-status.tt","line":10,"ins":{"up_context":[{"change":4,"pos":259}],"down_context":[{"change":3,"pos":192}],"flag":"BLOCK","start":403,"end":433,"inode":{"change":10,"pos":8348}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":259},"to":{"change":3,"start":63,"end":129},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":129},"to":{"change":4,"start":416,"end":437},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":4,"pos":1459},"to":{"change":4,"start":416,"end":437},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":416},"to":{"change":4,"start":416,"end":437},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":437},"to":{"change":3,"start":130,"end":192},"introduced_by":3}],"inode":{"change":10,"pos":8348}},"ins_contents":[{"Add":{"text":" [% name %]","pos":"RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC:432"}}],"del_contents":[{"Del":{"text":" [% IF !m.key || m.value.maxJobs %]","pos":"J4R2VCPPXW6QPVIDNXVHFRTDAZAPLAFBBBPIQZLZVPUHFXCO67TAC:107"}},{"Del":{"text":" Enabled:","pos":"J4R2VCPPXW6QPVIDNXVHFRTDAZAPLAFBBBPIQZLZVPUHFXCO67TAC:128"}},{"Del":{"text":" [% ELSE %]","pos":"V6S6OYIAW3ZCBP6UHUYAZGG4P237WBB6HDG5NQIF3E5YFDTQRA4AC:436"}},{"Del":{"text":" Disabled:","pos":"J4R2VCPPXW6QPVIDNXVHFRTDAZAPLAFBBBPIQZLZVPUHFXCO67TAC:151"}},{"Del":{"text":" [% END %] [% name %]","pos":"J4R2VCPPXW6QPVIDNXVHFRTDAZAPLAFBBBPIQZLZVPUHFXCO67TAC:191"}}]}},{"Replacement":{"inode":{"change":10,"pos":8348},"path":"src/root/machine-status.tt","line":34,"ins":{"up_context":[{"change":4,"pos":1730}],"down_context":[{"change":4,"pos":1844}],"flag":"BLOCK","start":434,"end":546,"inode":{"change":10,"pos":8348}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":1730},"to":{"change":4,"start":1730,"end":1844},"introduced_by":4}],"inode":{"change":10,"pos":8348}},"ins_contents":[{"Add":{"text":" Idle for [% INCLUDE renderDuration duration = curTime - m.value.idle %]","pos":"RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC:545"}}],"del_contents":[{"Del":{"text":" Idle since [% INCLUDE renderDuration duration = curTime - m.value.idle %]","pos":"HTL6HIBMRGSX2H2H7KB4MC3H6UQ5C752VC3UHC43SRA7V66PQCRQC:1843"}}]}}],"owner":"grahamc","repo":"hydra2","token":"aERY/eAYFhba5hM3LRRNHMcF8MKelTOM4uxqtrFY348=","login":null}

…

Dependencies

Change contents

Review