{"header":{"message":"Show aborted/cancelled builds separately in jobset eval pages","description":null,"timestamp":"2013-10-02T23:54:42Z","authors":[{"email":"eelco.dolstra@logicblox.com","name":"Eelco Dolstra"}]},"hash":"RHUAFTJAKUW654TNYHQYSSQ4PXFEEMDRRTLEPKCP3MOE7TWMTICQC","authors":[],"deps":{"hashes":[["RHUAFTJAKUW654TNYHQYSSQ4PXFEEMDRRTLEPKCP3MOE7TWMTICQC","Show aborted/cancelled builds separately in jobset eval pages"],["AA",null],["QD3NI3JYFYPWNKGNOFGHEARQ6TUYNANW4JCFNRKHJR753FII76GAC","Allow comparing an eval against the jobset one day/week/month before"],["6HWHYPSW4Y2QBY3OWAJYEOOVICFFIWSL5OEAU2ZMLD3H4NXXKBOAC","Add an action menu to evaluations"],["WZZOOYCHQJJ6BWQPJFXULOBVSLZXPMOKM2YNA7TPEXUINLXFVI5AC","Show queued builds in jobset evaluation pages"],["L7NUCXKSELV2XQBSETAN2KSXN5ONX3ESJDHZL6737LMK4KPGQANQC","Show new and removed jobs"],["U4TD3AIQXBJFFUORTMIC4IHZTVBORRKL2TZ2FSP4G665ECZOEMNAC","Add support for viewing jobset evaluations"],["DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC","Allow comparing an evaluation with an arbitrary other evaluation"],["HQGXL4MXGHICQ3IRRQUR6KQHS2RKVOTDKQ5ZETXHQ56DANR2YADQC","Add validation for project and jobset names"],["4QCXGR4WEQHBUNOKGLH7VOUF7RWGZJHVSQDZB3I7ZXQX2DRSHLGAC","Tabify the eval page"]],"deps":["QD3NI3JYFYPWNKGNOFGHEARQ6TUYNANW4JCFNRKHJR753FII76GAC","6HWHYPSW4Y2QBY3OWAJYEOOVICFFIWSL5OEAU2ZMLD3H4NXXKBOAC"],"known":["U4TD3AIQXBJFFUORTMIC4IHZTVBORRKL2TZ2FSP4G665ECZOEMNAC","L7NUCXKSELV2XQBSETAN2KSXN5ONX3ESJDHZL6737LMK4KPGQANQC","WZZOOYCHQJJ6BWQPJFXULOBVSLZXPMOKM2YNA7TPEXUINLXFVI5AC","DE2DNCOIEVRA6OOSOSXI2USRPOWL4SC6XPCJFOUM54BS2ESCEWOAC","HQGXL4MXGHICQ3IRRQUR6KQHS2RKVOTDKQ5ZETXHQ56DANR2YADQC"]},"hunks":[{"Replacement":{"inode":{"change":4,"pos":1302},"path":"src/lib/Hydra/Controller/JobsetEval.pm","line":42,"ins":{"up_context":[{"change":4,"pos":809}],"down_context":[{"change":2,"pos":58}],"flag":"BLOCK","start":0,"end":72,"inode":{"change":4,"pos":1302}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":809},"to":{"change":2,"start":0,"end":58},"introduced_by":2}],"inode":{"change":4,"pos":1302}},"ins_contents":[{"Add":{"text":" } elsif ($compare =~ /^-(\\d+)$/) {","pos":"RHUAFTJAKUW654TNYHQYSSQ4PXFEEMDRRTLEPKCP3MOE7TWMTICQC:42"}},{"Add":{"text":" my $t = int($1);","pos":"RHUAFTJAKUW654TNYHQYSSQ4PXFEEMDRRTLEPKCP3MOE7TWMTICQC:71"}}],"del_contents":[{"Del":{"text":"\t} elsif ($compare =~ /^-(\\d+)$/) {","pos":"QD3NI3JYFYPWNKGNOFGHEARQ6TUYNANW4JCFNRKHJR753FII76GAC:35"}},{"Del":{"text":"\t my $t = int($1);","pos":"QD3NI3JYFYPWNKGNOFGHEARQ6TUYNANW4JCFNRKHJR753FII76GAC:57"}}]}},{"Replacement":{"inode":{"change":4,"pos":1302},"path":"src/lib/Hydra/Controller/JobsetEval.pm","line":45,"ins":{"up_context":[{"change":2,"pos":119}],"down_context":[{"change":4,"pos":809}],"flag":"BLOCK","start":73,"end":217,"inode":{"change":4,"pos":1302}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":119},"to":{"change":2,"start":119,"end":235},"introduced_by":2}],"inode":{"change":4,"pos":1302}},"ins_contents":[{"Add":{"text":" { hasnewbuilds => 1, timestamp => {'<=', $eval->timestamp - $t} },","pos":"RHUAFTJAKUW654TNYHQYSSQ4PXFEEMDRRTLEPKCP3MOE7TWMTICQC:155"}},{"Add":{"text":" { order_by => \"timestamp desc\", rows => 1});","pos":"RHUAFTJAKUW654TNYHQYSSQ4PXFEEMDRRTLEPKCP3MOE7TWMTICQC:216"}}],"del_contents":[{"Del":{"text":"\t\t{ hasnewbuilds => 1, timestamp => {'<=', $eval->timestamp - $t} },","pos":"QD3NI3JYFYPWNKGNOFGHEARQ6TUYNANW4JCFNRKHJR753FII76GAC:187"}},{"Del":{"text":"\t\t{ order_by => \"timestamp desc\", rows => 1});","pos":"QD3NI3JYFYPWNKGNOFGHEARQ6TUYNANW4JCFNRKHJR753FII76GAC:234"}}]}},{"Edit":{"inode":{"change":4,"pos":1302},"path":"src/lib/Hydra/Controller/JobsetEval.pm","line":81,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":34}],"down_context":[{"change":4,"pos":2610}],"flag":"BLOCK","start":218,"end":249,"inode":{"change":4,"pos":1302}}},"contents":[{"Add":{"text":" $c->stash->{aborted} = [];","pos":"RHUAFTJAKUW654TNYHQYSSQ4PXFEEMDRRTLEPKCP3MOE7TWMTICQC:248"}}]}},{"Replacement":{"inode":{"change":4,"pos":1302},"path":"src/lib/Hydra/Controller/JobsetEval.pm","line":94,"ins":{"up_context":[{"change":4,"pos":1558}],"down_context":[{"change":4,"pos":106}],"flag":"BLOCK","start":250,"end":460,"inode":{"change":4,"pos":1302}},"del":{"edges":[{"previous":"","flag":"DELETED","from":{"change":4,"pos":1558},"to":{"change":4,"start":35,"end":106},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":81},"to":{"change":4,"start":35,"end":106},"introduced_by":4}],"inode":{"change":4,"pos":1302}},"ins_contents":[{"Add":{"text":" if ($build->buildstatus == 3 || $build->buildstatus == 4) {","pos":"RHUAFTJAKUW654TNYHQYSSQ4PXFEEMDRRTLEPKCP3MOE7TWMTICQC:325"}},{"Add":{"text":" push @{$c->stash->{aborted}}, $build;","pos":"RHUAFTJAKUW654TNYHQYSSQ4PXFEEMDRRTLEPKCP3MOE7TWMTICQC:383"}},{"Add":{"text":" } elsif ($build->finished == 0 || $build2->finished == 0) {","pos":"RHUAFTJAKUW654TNYHQYSSQ4PXFEEMDRRTLEPKCP3MOE7TWMTICQC:459"}}],"del_contents":[{"Del":{"text":" if ($build->finished == 0 || $build2->finished == 0) {","pos":"WZZOOYCHQJJ6BWQPJFXULOBVSLZXPMOKM2YNA7TPEXUINLXFVI5AC:105"}}]}},{"Edit":{"inode":{"change":4,"pos":4844},"path":"src/root/jobset-eval.tt","line":49,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":388}],"down_context":[{"change":10,"pos":342}],"flag":"BLOCK","start":461,"end":607,"inode":{"change":4,"pos":4844}}},"contents":[{"Add":{"text":" [% IF aborted.size > 0 %]","pos":"RHUAFTJAKUW654TNYHQYSSQ4PXFEEMDRRTLEPKCP3MOE7TWMTICQC:488"}},{"Add":{"text":"

","pos":"RHUAFTJAKUW654TNYHQYSSQ4PXFEEMDRRTLEPKCP3MOE7TWMTICQC:594"}},{"Add":{"text":" [% END %]","pos":"RHUAFTJAKUW654TNYHQYSSQ4PXFEEMDRRTLEPKCP3MOE7TWMTICQC:606"}}]}},{"Edit":{"inode":{"change":4,"pos":4844},"path":"src/root/jobset-eval.tt","line":89,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":251}],"down_context":[{"change":10,"pos":1818}],"flag":"BLOCK","start":608,"end":705,"inode":{"change":4,"pos":4844}}},"contents":[{"Add":{"text":"

","pos":"RHUAFTJAKUW654TNYHQYSSQ4PXFEEMDRRTLEPKCP3MOE7TWMTICQC:650"}},{"Add":{"text":" [% INCLUDE renderSome builds=aborted %]","pos":"RHUAFTJAKUW654TNYHQYSSQ4PXFEEMDRRTLEPKCP3MOE7TWMTICQC:694"}},{"Add":{"text":"

","pos":"RHUAFTJAKUW654TNYHQYSSQ4PXFEEMDRRTLEPKCP3MOE7TWMTICQC:703"}},{"Add":{"text":"","pos":"RHUAFTJAKUW654TNYHQYSSQ4PXFEEMDRRTLEPKCP3MOE7TWMTICQC:704"}}]}}],"owner":"grahamc","repo":"hydra2","token":"KqOWEFByclqbxNc82FBQ9YLUjxgpsRvsM1ybjMH1Oh8=","login":null}

…

Dependencies

Change contents

Review