Warn against multiple jobs with the same name

[?]
Sep 25, 2013, 1:30 PM
SRBU2RAEHX4NRDIE7IYFUHJQWJF7A547AXFDOOUEZ2YOCXCQVLJQC

Dependencies

  • [2] QMW24O5S Add support for Guile & Guix.
  • [3] 3XTHEUMP * Implemented the clone feature.
  • [4] IJSJLRZH Disallow build products that are symlinks
  • [5] POPU2ATH * hydra_scheduler: use eval-jobs.
  • [6] GA6XIXAN * Show the input bindings in evaluation error messages.
  • [7] S6OISBQ3 * Mark the "current" builds in a jobset, i.e. those corresponding to
  • [8] S5PV6IIM * Represent jobs explicitly in the DB.
  • [9] SHZLOM5M * eval-jobs -> hydra_eval_jobs.
  • [10] WQXF2T3D hydra-evaluator: Don't require $HYDRA_CONFIG
  • [11] QE253KG4 * Option to show the tail of a log.
  • [12] YFPZ46YK * hydra: added variant of build input type, 'build output (same system)' to allow better continous integration in one jobset for multiple system. it makes sure that the system of the build that is passed as input for a job has the same system as the job.
  • [13] FM4O2L4M hydra: if evaluator sees cached build, also add the buildproducts
  • [14] D7GTR6PP Remove wacky "sysbuild" filtering
  • [15] INNOEHO6 * Fix getBuildLog for bzip2'd files.
  • [16] RFE6T5LG * Store jobset evaluations in the database explicitly. This includes
  • [17] RXVJFQ5A Evaluator cleanups
  • [18] PMNWRTGJ Add multiple output support
  • [*] OOQ2D3KC * Refactoring: move fetchInput out of hydra_scheduler into a separate
  • [*] N22GPKYT * Put info about logs / build products in the DB.

Change contents

  • replacement in src/lib/Hydra/Helper/AddBuilds.pm at line 285
    [3.416][3.3393:3428](),[3.2134][3.3393:3428](),[3.3393][3.3393:3428]()
    return ($jobs, $nixExprInput);
    [3.3393]
    [3.3428]
    my %jobNames;
    my $errors;
    foreach my $job (@{$jobs->{job}}) {
    $jobNames{$job->{jobName}}++;
    if ($jobNames{$job->{jobName}} == 2) {
    $errors .= "warning: there are multiple jobs named ‘$job->{jobName}’; support for this will go away soon!\n\n";
    }
    }
    return ($jobs, $nixExprInput, $errors);
  • replacement in src/script/hydra-evaluator at line 136
    [3.5549][2.11556:11666]()
    my ($jobs, $nixExprInput) = evalJobs($inputInfo, $exprType, $jobset->nixexprinput, $jobset->nixexprpath);
    [3.5549]
    [3.5550]
    my ($jobs, $nixExprInput, $msg) = evalJobs($inputInfo, $exprType, $jobset->nixexprinput, $jobset->nixexprpath);
  • edit in src/script/hydra-evaluator at line 241
    [3.2840][3.755:773](),[3.755][3.755:773]()
    my $msg = "";