Fix some warnings

[?]

Jan 23, 2013, 12:41 PM

U2ZK6LZ7MTUISO6AXHAWGSQLWRJYAWMYZPN4MORRGUT6POM6X7HQC

Dependencies

[2] SDSIJMOH * Don't crawl the channel pages, particularly because the "all"
[3] G5ZR3ZVZ hydra: put contents links into html, add links to files from contents page
[4] HPEG2RHV Merge the BuildResultInfo table into the Builds table
[5] LKDWWJLM Doh
[6] IQBSH5A4 Also remove dep. graph from robots.txt.
[7] 57XH5AZ3 Set utf-8 encoding on raw log pages
[8] DGRP5VI2 Turn off overly verbose log messages by default
[9] MBNX3V52 hydra: disallow robots.txt for root and project all builds page
[10] Q7SVRTQU Disable Catalyst's Debug flag
[11] QE253KG4 * Option to show the tail of a log.
[12] LUPEGYR7 Hydra: In case of failure, also show changes between last succesful build and the first failed build after this
[13] QNYIOH25 * Generate a robots.txt.
[14] SJN2QPWH * Big speed-up of the job status page and the channel generation (such
[15] RU7AQO7U * Role-based access control. Only admins can create projects. Only
[16] 5EV65EDZ * Generate robots.txt in a more Catalystic way.
[17] J23PXOOI * hydra: add deps list to pages not to be indexed by google etc
[18] VIOVDBSD hydra: nar was replaced, so also move in robots.txt
[19] 4XVMHKBK
[20] SHYRGAWZ hydra: when no external url is given for diff's of git/hg input, revert to a diff done on a local available clone
[21] LBNVQXUB * Build the /build stuff in a separate controller.
[22] 7UJ5YV4V * Provide a channel for each project containing all the latest
[23] 4WJT7XZU * Don't index any of the logs (mostly because xsltproc can be a huge
[24] NZ2SIAI6 add /status to robots.txt
[25] 2GK5DOU7 * Downloading closures.
[26] TH674WKJ add log diff to compare logs to previous builds
[27] SHBLLAVH * More global substitution.
[28] FPK5LF53 * Put the project-related actions in a separate controller. Put the
[29] DXBTGOA4 Print out an Apache-style access log
[30] KAZWI5G4 * hydra: buildpage, show changes since last build/successful build
[31] CS7T2XFI
[32] OC4JSQJV * hydra: robots.txt, also disallow logs for the actual builds
[33] J5UVLXOK * Start of a basic Catalyst web interface.
[34] AFTXA575 * $HYDRA_DATA environment variable.
[35] S66BOMVU * Added authentication.

Change contents

replacement in src/lib/Hydra/Controller/Root.pm at line 121

[9.19]→[9.19:66](∅→∅)

my ($controller, $action, @args) = @_;

[9.19]

[9.66]

my ($c, $controller, $action, @args) = @_;
replacement in src/lib/Hydra/Controller/Root.pm at line 126

[9.186]→[9.186:228](∅→∅)

my ($controller, $bindings) = @_;

[9.186]

[9.228]

my ($c, $controller, $bindings) = @_;
replacement in src/lib/Hydra/Controller/Root.pm at line 128

[9.243]→[9.0:120](∅→∅),[9.178]→[9.178:294](∅→∅),[9.294]→[2.0:66](∅→∅)

( uri_for($controller, 'closure', $bindings, "*")
, uri_for($controller, 'manifest', $bindings)
, uri_for($controller, 'pkg', $bindings, "*")
, uri_for($controller, 'nixexprs', $bindings)
, uri_for($controller, 'channel_contents', $bindings)

[9.243]

[9.612]

( uri_for($c, $controller, 'closure', $bindings, "*")
, uri_for($c, $controller, 'manifest', $bindings)
, uri_for($c, $controller, 'pkg', $bindings, "*")
, uri_for($c, $controller, 'nixexprs', $bindings)
, uri_for($c, $controller, 'channel_contents', $bindings)
replacement in src/lib/Hydra/Controller/Root.pm at line 140

[9.274]→[6.0:42](∅→∅),[9.42]→[9.0:54](∅→∅),[6.42]→[9.0:54](∅→∅),[9.395]→[9.0:54](∅→∅),[9.54]→[9.0:97](∅→∅),[9.97]→[3.387:438](∅→∅),[3.438]→[9.0:42](∅→∅),[9.97]→[9.0:42](∅→∅),[9.42]→[9.0:40](∅→∅),[9.40]→[9.0:37](∅→∅),[9.37]→[9.963:1003](∅→∅),[9.1003]→[9.1232:1281](∅→∅),[9.1003]→[9.37:80](∅→∅),[9.1281]→[9.37:80](∅→∅),[9.37]→[9.37:80](∅→∅),[9.40]→[9.838:1058](∅→∅),[9.42]→[9.838:1058](∅→∅),[9.54]→[9.838:1058](∅→∅),[9.80]→[9.838:1058](∅→∅),[9.97]→[9.838:1058](∅→∅),[9.454]→[9.838:1058](∅→∅),[9.838]→[9.838:1058](∅→∅)

( uri_for('Build', 'deps', ["*"])
, uri_for('Build', 'view_nixlog', ["*"], "*")
, uri_for('Build', 'view_log', ["*"], "*")
, uri_for('Build', 'view_log', ["*"])
, uri_for('Build', 'download', ["*"], "*")
, uri_for('Root', 'nar', [], "*")
, uri_for('Root', 'status', [])
, uri_for('Root', 'all', [])
, uri_for('API', 'scmdiff', [])
, uri_for('API', 'logdiff', [],"*", "*")
, uri_for('Project', 'all', ["*"])
, channelUris('Root', ["*"])
, channelUris('Project', ["*", "*"])
, channelUris('Jobset', ["*", "*", "*"])
, channelUris('Job', ["*", "*", "*", "*"])
, channelUris('Build', ["*"])

[9.274]

[9.592]

( uri_for($c, 'Build', 'deps', ["*"])
, uri_for($c, 'Build', 'view_nixlog', ["*"], "*")
, uri_for($c, 'Build', 'view_log', ["*"], "*")
, uri_for($c, 'Build', 'view_log', ["*"])
, uri_for($c, 'Build', 'download', ["*"], "*")
, uri_for($c, 'Root', 'nar', [], "*")
, uri_for($c, 'Root', 'status', [])
, uri_for($c, 'Root', 'all', [])
, uri_for($c, 'API', 'scmdiff', [])
, uri_for($c, 'API', 'logdiff', [],"*", "*")
, uri_for($c, 'Project', 'all', ["*"])
, channelUris($c, 'Root', ["*"])
, channelUris($c, 'Project', ["*", "*"])
, channelUris($c, 'Jobset', ["*", "*", "*"])
, channelUris($c, 'Job', ["*", "*", "*", "*"])
, channelUris($c, 'Build', ["*"])
replacement in src/lib/Hydra/Helper/CatalystUtils.pm at line 11

[9.125]→[4.4711:4810](∅→∅)

getBuild getPreviousBuild getNextBuild getPreviousSuccessfulBuild getBuildStats getChannelData

[9.125]

[9.9702]

getBuild getPreviousBuild getNextBuild getPreviousSuccessfulBuild getBuildStats
replacement in src/lib/Hydra/View/Plain.pm at line 9

[7.40]→[7.40:80](∅→∅)

$c->res->content_encoding("utf-8");

[7.40]

[7.80]

$c->response->content_encoding("utf-8");
$c->response->content_type('text/plain') unless $c->response->content_type() ne "";
edit in src/lib/Hydra.pm at line 5

[9.7005]

[5.0]

use parent 'Catalyst';
edit in src/lib/Hydra.pm at line 7

[5.22]→[9.7005:7006](∅→∅),[9.942]→[9.7005:7006](∅→∅),[9.7005]→[9.7005:7006](∅→∅)
edit in src/lib/Hydra.pm at line 8

[9.7036]→[9.7036:7062](∅→∅)

use parent qw/Catalyst/;
replacement in src/lib/Hydra.pm at line 16

[9.4331]→[9.40:66](∅→∅),[9.66]→[8.0:38](∅→∅),[8.38]→[9.7172:7190](∅→∅),[9.66]→[9.7172:7190](∅→∅),[9.4331]→[9.7172:7190](∅→∅),[9.7172]→[9.7172:7190](∅→∅)

AccessLog
-Log=warn,fatal,error
/;

[9.4331]

[9.7190]

AccessLog/,
'-Log=warn,fatal,error';