{"header":{"message":"Don't show how long a machine has been idle","description":"Without an index on (machine, stoptime desc), this requires a\nsequential scan. And adding a whole index for this seems\noverkill. (Possibly the queue runner could maintain this info more\nefficiently.)","timestamp":"2015-07-10T13:34:29Z","authors":[{"email":"eelco.dolstra@logicblox.com","name":"Eelco Dolstra"}]},"hash":"UFFPFIXSKKIWSUHC6D4YPUZRNZJV2YW5V62L6ZQGMY7B3YNQJ43QC","authors":[],"deps":{"hashes":[["UFFPFIXSKKIWSUHC6D4YPUZRNZJV2YW5V62L6ZQGMY7B3YNQJ43QC","Don't show how long a machine has been idle"],["AA",null],["SQINIEM2EQD4U7MWXKJDTOK6KAMLGCEEVRKL67XYVAJEEWD2FWOQC","Fix colspan"],["RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC","Machine status: Don't show removed machines anymore"],["SMCOU72FKTPFNCDXFJAILVUWFE4DY33CJJE4436H5POKENFFDFFAC","hydra: add some admin for adding/enabling/etc build machines"],["HTL6HIBMRGSX2H2H7KB4MC3H6UQ5C752VC3UHC43SRA7V66PQCRQC","machine-status: Read /etc/nix.machines instead of using the BuildMachines table"],["J4R2VCPPXW6QPVIDNXVHFRTDAZAPLAFBBBPIQZLZVPUHFXCO67TAC","Fix showing build steps in the machine status page"],["BZUB3ZSH7ZVUTNQYNQYZOCZQ5UIQKDNBC5BJU3T6ITHZ2CERJJ5AC","Use get_column for 'as' column (max_stoptime)."],["36ZTCZ4FDV6ILURQEIGFHCP57ALZH6OWYNN3MBXG2QXZSBULBPMAC","Add basic Persona support"],["V6S6OYIAW3ZCBP6UHUYAZGG4P237WBB6HDG5NQIF3E5YFDTQRA4AC","Formatting tweaks"],["J5UVLXOK6EDIL5I7VKWH4V2QDS4DPD7FHRK6XBWSXFRQS4JKXFZQC","* Start of a basic Catalyst web interface."],["ZWCTAZGLJZQNTYWTC2XQUKMILJF6JGDL5IND6QNYWK4FIGMLRFXAC","added newsitems, added some admin options to clear various caches."]],"deps":["SQINIEM2EQD4U7MWXKJDTOK6KAMLGCEEVRKL67XYVAJEEWD2FWOQC"],"known":["SMCOU72FKTPFNCDXFJAILVUWFE4DY33CJJE4436H5POKENFFDFFAC","V6S6OYIAW3ZCBP6UHUYAZGG4P237WBB6HDG5NQIF3E5YFDTQRA4AC","HTL6HIBMRGSX2H2H7KB4MC3H6UQ5C752VC3UHC43SRA7V66PQCRQC","BZUB3ZSH7ZVUTNQYNQYZOCZQ5UIQKDNBC5BJU3T6ITHZ2CERJJ5AC","J4R2VCPPXW6QPVIDNXVHFRTDAZAPLAFBBBPIQZLZVPUHFXCO67TAC","RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC","36ZTCZ4FDV6ILURQEIGFHCP57ALZH6OWYNN3MBXG2QXZSBULBPMAC"]},"hunks":[{"Edit":{"inode":{"change":11,"pos":804},"path":"src/lib/Hydra/Controller/Root.pm","line":113,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":61},"to":{"change":3,"start":61,"end":396},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":82},"to":{"change":3,"start":346,"end":352},"introduced_by":3},{"previous":"","flag":"DELETED","from":{"change":3,"pos":396},"to":{"change":3,"start":346,"end":352},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":346},"to":{"change":3,"start":346,"end":352},"introduced_by":3}],"inode":{"change":11,"pos":804}}},"contents":[{"Del":{"text":"","pos":"RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC:61"}},{"Del":{"text":" # Get the last finished build step for each machine.","pos":"RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC:118"}},{"Del":{"text":" foreach my $m (keys %{$machines}) {","pos":"RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC:158"}},{"Del":{"text":" my $idle = $c->model('DB::BuildSteps')->find(","pos":"RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC:212"}},{"Del":{"text":" { machine => \"$m\", stoptime => { '!=', undef } },","pos":"RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC:274"}},{"Del":{"text":" { order_by => 'stoptime desc', rows => 1 });","pos":"RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC:331"}},{"Del":{"text":" ${$machines}{$m}{'idle'} = $idle ? $idle->stoptime : 0;","pos":"RFGPN7U7DOFZMPNLJDTS3IXEYSDN57HUDKI5I54NU4LC376JUR2AC:395"}},{"Del":{"text":" }","pos":"HTL6HIBMRGSX2H2H7KB4MC3H6UQ5C752VC3UHC43SRA7V66PQCRQC:351"}}]}},{"Replacement":{"inode":{"change":12,"pos":8348},"path":"src/root/machine-status.tt","line":44,"ins":{"up_context":[{"change":3,"pos":1374}],"down_context":[{"change":3,"pos":1496}],"flag":"BLOCK","start":0,"end":43,"inode":{"change":12,"pos":8348}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1374},"to":{"change":3,"start":1699,"end":1730},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1730},"to":{"change":2,"start":0,"end":112},"introduced_by":2},{"previous":"","flag":"DELETED","from":{"change":2,"pos":112},"to":{"change":3,"start":1844,"end":1863},"introduced_by":2},{"previous":"","flag":"DELETED","from":{"change":3,"pos":546},"to":{"change":3,"start":1844,"end":1863},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1844},"to":{"change":3,"start":1844,"end":1863},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1863},"to":{"change":2,"start":113,"end":164},"introduced_by":2},{"previous":"","flag":"DELETED","from":{"change":2,"pos":164},"to":{"change":3,"start":1915,"end":1933},"introduced_by":2},{"previous":"","flag":"DELETED","from":{"change":3,"pos":664},"to":{"change":3,"start":1915,"end":1933},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":1915},"to":{"change":3,"start":1915,"end":1933},"introduced_by":3}],"inode":{"change":12,"pos":8348}},"ins_contents":[{"Add":{"text":" Idle","pos":"UFFPFIXSKKIWSUHC6D4YPUZRNZJV2YW5V62L6ZQGMY7B3YNQJ43QC:42"}}],"del_contents":[{"Del":{"text":" [% IF m.value.idle %] ","pos":"HTL6HIBMRGSX2H2H7KB4MC3H6UQ5C752VC3UHC43SRA7V66PQCRQC:1729"}},{"Del":{"text":" Idle for [% INCLUDE renderDuration duration = curTime - m.value.idle %]","pos":"SQINIEM2EQD4U7MWXKJDTOK6KAMLGCEEVRKL67XYVAJEEWD2FWOQC:111"}},{"Del":{"text":" [% ELSE %]","pos":"HTL6HIBMRGSX2H2H7KB4MC3H6UQ5C752VC3UHC43SRA7V66PQCRQC:1862"}},{"Del":{"text":" Never used","pos":"SQINIEM2EQD4U7MWXKJDTOK6KAMLGCEEVRKL67XYVAJEEWD2FWOQC:163"}},{"Del":{"text":" [% END %]","pos":"HTL6HIBMRGSX2H2H7KB4MC3H6UQ5C752VC3UHC43SRA7V66PQCRQC:1932"}}]}}],"owner":"grahamc","repo":"hydra2","token":"foAa572VY1+Dmeg2eX9U/R5nohAkfhyDmD5ZVstZvmk=","login":null}

…

Dependencies

Change contents

Review