perlcritic: Don't conditionally declare variables

[?]
Sep 8, 2021, 1:35 AM
WDGF3BKGLNF4RBZXJUTTZMNEE6SPHDUCW7JTIGAUCX6TK3MGVU3QC

Dependencies

  • [2] VU2OLHD2 Move most of AddBuilds to hydra-eval-jobset
  • [3] SGG4O42H perl: jobsetevals -> jobset via by jobset_id
  • [4] UUWTUFAM CoverityScan: $b -> $build (perlcritic)
  • [5] VH5ZABDR Add a page to show the latest evaluations for the entire server
  • [6] THUMRES3 hydra: add Coverity Scan plugin
  • [7] IPBPZCWR Fix sysbuild
  • [8] MRJCQ4EO Don't use given/when
  • [9] UEMB7PTH Add option eval_substituter
  • [10] U5ZWDBW3 Ensure that each eval is compared to the previous one from the same jobset
  • [*] 2GK5DOU7 * Downloading closures.
  • [*] N22GPKYT * Put info about logs / build products in the DB.

Change contents

  • replacement in src/lib/Hydra/Helper/Nix.pm at line 309
    [3.1733][3.1733:1809]()
    my $prevInfo = getEvalInfo($cache, $prevEval) if defined $prevEval;
    [3.1733]
    [3.1700]
    my $prevInfo;
    $prevInfo = getEvalInfo($cache, $prevEval) if defined $prevEval;
  • replacement in src/lib/Hydra/Plugin/CoverityScan.pm at line 85
    [3.2697][3.2697:2781]()
    my $version = $2 if $shortName =~ /^($pkgNameRE)-($versionRE)-coverity-int.*$/;
    [3.2697]
    [3.2781]
    my $version;
    $version = $2 if $shortName =~ /^($pkgNameRE)-($versionRE)-coverity-int.*$/;
  • replacement in src/script/hydra-eval-jobset at line 125
    [2.2637][2.2637:2704]()
    my $version = $2 if $relName =~ /^($pkgNameRE)-($versionRE)$/;
    [2.2637]
    [2.2704]
    my $version;
    $version = $2 if $relName =~ /^($pkgNameRE)-($versionRE)$/;
  • replacement in src/script/hydra-eval-jobset at line 171
    [2.3955][2.3955:4026]()
    my $version = $2 if $relName =~ /^($pkgNameRE)-($versionRE)$/;
    [2.3955]
    [2.4026]
    my $version;
    $version = $2 if $relName =~ /^($pkgNameRE)-($versionRE)$/;