Fix incorrect removed jobs in eval pages

[?]
Aug 28, 2013, 1:04 PM
X46KWQFNQ4KFKCZHPT5UXKCFGV57WXUWPOHLUHQKIF3ZIQYGZBQQC

Dependencies

  • [2] 3PNG7NIB Remove trailing whitespace
  • [3] L7NUCXKS Show new and removed jobs
  • [4] DE2DNCOI Allow comparing an evaluation with an arbitrary other evaluation
  • [5] U4TD3AIQ Add support for viewing jobset evaluations

Change contents

  • replacement in src/lib/Hydra/Controller/JobsetEval.pm at line 54
    [3.1316][3.2110:2227](),[2.2209][3.2110:2227](),[3.2110][3.2110:2227](),[3.2227][3.1317:1474]()
    my @builds = $eval->builds->search({}, { order_by => ["job", "system", "id"], columns => [@buildListColumns] });
    my @builds2 = defined $eval2
    ? $eval2->builds->search({}, { order_by => ["job", "system", "id"], columns => [@buildListColumns] })
    : ();
    [2.2209]
    [3.2346]
    sub cmpBuilds {
    my ($a, $b) = @_;
    return $a->get_column('job') cmp $b->get_column('job')
    || $a->get_column('system') cmp $b->get_column('system')
    }
  • edit in src/lib/Hydra/Controller/JobsetEval.pm at line 60
    [3.2347]
    [3.2476]
    my @builds = $eval->builds->search({}, { columns => [@buildListColumns] });
    my @builds2 = defined $eval2 ? $eval2->builds->search({}, { columns => [@buildListColumns] }) : ();
    @builds = sort { cmpBuilds($a, $b) } @builds;
    @builds2 = sort { cmpBuilds($a, $b) } @builds2;
  • replacement in src/lib/Hydra/Controller/JobsetEval.pm at line 80
    [3.2754][3.2754:2914]()
    my $d = $build->get_column('job') cmp $build2->get_column('job')
    || $build->get_column('system') cmp $build2->get_column('system');
    [3.2754]
    [3.1499]
    my $d = cmpBuilds($build, $build2);