GitlabStatus: $build -> $topbuild, $b -> $build (perlcritic)
[?]
Aug 21, 2021, 1:40 AM
XXCNIG3GTOEB6PMTZX2WTYN5OJ5T5XXBRH64CR2IVDWXCQJQENEQCDependencies
- [2]
6HWIUOSUAvoid fetching Projects/Jobsets just to get the name column - [3]
5WNGKHLZPlugins: Add isEnabled method - [4]
YXU6JABKCreate a gitlab status plugin
Change contents
- replacement in src/lib/Hydra/Plugin/GitlabStatus.pm at line 40
my ($self, $build, $dependents, $status) = @_;my ($self, $topbuild, $dependents, $status) = @_; - replacement in src/lib/Hydra/Plugin/GitlabStatus.pm at line 44
foreach my $b ($build, @{$dependents}) {my $jobName = showJobName $b;my $evals = $build->jobsetevals;foreach my $build ($topbuild, @{$dependents}) {my $jobName = showJobName $build;my $evals = $topbuild->jobsetevals; - replacement in src/lib/Hydra/Plugin/GitlabStatus.pm at line 50
next if $status < 2 && $b->finished == 1;next if $status < 2 && $build->finished == 1; - replacement in src/lib/Hydra/Plugin/GitlabStatus.pm at line 52
my $state = toGitlabState($status, $b->buildstatus);my $state = toGitlabState($status, $build->buildstatus); - replacement in src/lib/Hydra/Plugin/GitlabStatus.pm at line 56
target_url => "$baseurl/build/" . $b->id,description => "Hydra build #" . $b->id . " of $jobName",name => "Hydra " . $b->get_column('job'),target_url => "$baseurl/build/" . $build->id,description => "Hydra build #" . $build->id . " of $jobName",name => "Hydra " . $build->get_column('job'),