{"header":{"message":"Implement a database connection pool","description":null,"timestamp":"2015-05-29T18:55:13Z","authors":[{"email":"eelco.dolstra@logicblox.com","name":"Eelco Dolstra"}]},"hash":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC","authors":[],"deps":{"hashes":[["YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC","Implement a database connection pool"],["AA",null],["62MQPRXCZCP7ZQKOOAFU5V36P7DBS6RCFDYK53PDCFGI4FAOQWMQC","Pass null values to libpqxx properly"],["T2EIYJNGPIANHKJ4HBJIPTINWKG7RDLHR3PVHFYAPPLHZAJQBVWAC","On SIGINT, shut down the builder threads"],["ENXUSMSVOU3AZFMH2ZXR4ZVPV2LRRQYQJ6IFX33YN6IH2ORSNSAAC","Make concurrency more robust"],["NJJ7H64SZOX5EGACDCQAUQ7R6UEWD5IIC35A2MWFOOJV55DJYPHAC","Very basic multi-threaded queue runner"],["24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC","Start of single-process hydra-queue-runner"]],"deps":["62MQPRXCZCP7ZQKOOAFU5V36P7DBS6RCFDYK53PDCFGI4FAOQWMQC","T2EIYJNGPIANHKJ4HBJIPTINWKG7RDLHR3PVHFYAPPLHZAJQBVWAC"],"known":["24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC","NJJ7H64SZOX5EGACDCQAUQ7R6UEWD5IIC35A2MWFOOJV55DJYPHAC","ENXUSMSVOU3AZFMH2ZXR4ZVPV2LRRQYQJ6IFX33YN6IH2ORSNSAAC"]},"hunks":[{"Edit":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":12,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":19}],"down_context":[{"change":4,"pos":19}],"flag":"BLOCK","start":0,"end":19,"inode":{"change":4,"pos":4840}}},"contents":[{"Add":{"text":"#include \"pool.hh\"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:18"}}]}},{"Replacement":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":149,"ins":{"up_context":[{"change":4,"pos":947}],"down_context":[{"change":3,"pos":75}],"flag":"BLOCK","start":20,"end":59,"inode":{"change":4,"pos":4840}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":947},"to":{"change":3,"start":41,"end":75},"introduced_by":3}],"inode":{"change":4,"pos":4840}},"ins_contents":[{"Add":{"text":"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:20"}},{"Add":{"text":" /* CV for waking up the queue. */","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:58"}}],"del_contents":[{"Del":{"text":" std::mutex queueMonitorMutex;","pos":"T2EIYJNGPIANHKJ4HBJIPTINWKG7RDLHR3PVHFYAPPLHZAJQBVWAC:74"}}]}},{"Edit":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":152,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":123}],"down_context":[{"change":4,"pos":947}],"flag":"BLOCK","start":60,"end":94,"inode":{"change":4,"pos":4840}}},"contents":[{"Add":{"text":" std::mutex queueMonitorMutex;","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:93"}}]}},{"Edit":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":170,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":172}],"down_context":[{"change":4,"pos":1019}],"flag":"BLOCK","start":95,"end":163,"inode":{"change":4,"pos":4840}}},"contents":[{"Add":{"text":"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:95"}},{"Add":{"text":" /* PostgreSQL connection pool. */","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:133"}},{"Add":{"text":" Pool dbPool;","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:162"}}]}},{"Replacement":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":179,"ins":{"up_context":[{"change":4,"pos":6457}],"down_context":[{"change":4,"pos":6539}],"flag":"BLOCK","start":164,"end":221,"inode":{"change":4,"pos":4840}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":6457},"to":{"change":4,"start":6457,"end":6539},"introduced_by":4}],"inode":{"change":4,"pos":4840}},"ins_contents":[{"Add":{"text":" void markActiveBuildStepsAsAborted(time_t stopTime);","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:220"}}],"del_contents":[{"Del":{"text":" void markActiveBuildStepsAsAborted(pqxx::connection & conn, time_t stopTime);","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:6538"}}]}},{"Replacement":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":191,"ins":{"up_context":[{"change":4,"pos":1058}],"down_context":[{"change":4,"pos":7042}],"flag":"BLOCK","start":222,"end":281,"inode":{"change":4,"pos":4840}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":1058},"to":{"change":4,"start":1058,"end":1142},"introduced_by":4}],"inode":{"change":4,"pos":4840}},"ins_contents":[{"Add":{"text":" void getQueuedBuilds(std::shared_ptr store);","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:280"}}],"del_contents":[{"Del":{"text":" void getQueuedBuilds(std::shared_ptr store, pqxx::connection & conn);","pos":"NJJ7H64SZOX5EGACDCQAUQ7R6UEWD5IIC35A2MWFOOJV55DJYPHAC:1141"}}]}},{"Edit":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":222,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":7535},"to":{"change":4,"start":7535,"end":7560},"introduced_by":4}],"inode":{"change":4,"pos":4840}}},"contents":[{"Del":{"text":" Connection conn;","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:7559"}}]}},{"Replacement":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":223,"ins":{"up_context":[{"change":4,"pos":7622}],"down_context":[{"change":4,"pos":7676}],"flag":"BLOCK","start":282,"end":330,"inode":{"change":4,"pos":4840}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":7622},"to":{"change":4,"start":7622,"end":7676},"introduced_by":4}],"inode":{"change":4,"pos":4840}},"ins_contents":[{"Add":{"text":" markActiveBuildStepsAsAborted(time(0));","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:329"}}],"del_contents":[{"Del":{"text":" markActiveBuildStepsAsAborted(conn, time(0));","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:7675"}}]}},{"Replacement":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":230,"ins":{"up_context":[{"change":4,"pos":7733}],"down_context":[{"change":4,"pos":7817}],"flag":"BLOCK","start":331,"end":390,"inode":{"change":4,"pos":4840}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":7733},"to":{"change":4,"start":7733,"end":7817},"introduced_by":4}],"inode":{"change":4,"pos":4840}},"ins_contents":[{"Add":{"text":"void State::markActiveBuildStepsAsAborted(time_t stopTime)","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:389"}}],"del_contents":[{"Del":{"text":"void State::markActiveBuildStepsAsAborted(pqxx::connection & conn, time_t stopTime)","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:7816"}}]}},{"Replacement":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":232,"ins":{"up_context":[{"change":4,"pos":7819}],"down_context":[{"change":2,"pos":0}],"flag":"BLOCK","start":391,"end":447,"inode":{"change":4,"pos":4840}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":7819},"to":{"change":4,"start":7819,"end":7845},"introduced_by":4}],"inode":{"change":4,"pos":4840}},"ins_contents":[{"Add":{"text":" auto conn(dbPool.get());","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:419"}},{"Add":{"text":" pqxx::work txn(*conn);","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:446"}}],"del_contents":[{"Del":{"text":" pqxx::work txn(conn);","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:7844"}}]}},{"Edit":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":280,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":1480},"to":{"change":4,"start":1480,"end":1502},"introduced_by":4}],"inode":{"change":4,"pos":4840}}},"contents":[{"Del":{"text":"","pos":"NJJ7H64SZOX5EGACDCQAUQ7R6UEWD5IIC35A2MWFOOJV55DJYPHAC:1480"}},{"Del":{"text":" Connection conn;","pos":"NJJ7H64SZOX5EGACDCQAUQ7R6UEWD5IIC35A2MWFOOJV55DJYPHAC:1501"}}]}},{"Replacement":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":282,"ins":{"up_context":[{"change":3,"pos":256}],"down_context":[{"change":4,"pos":1560}],"flag":"BLOCK","start":448,"end":480,"inode":{"change":4,"pos":4840}},"del":{"edges":[{"previous":"","flag":"DELETED","from":{"change":3,"pos":256},"to":{"change":4,"start":1522,"end":1560},"introduced_by":3},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":1522},"to":{"change":4,"start":1522,"end":1560},"introduced_by":4}],"inode":{"change":4,"pos":4840}},"ins_contents":[{"Add":{"text":" getQueuedBuilds(store);","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:479"}}],"del_contents":[{"Del":{"text":" getQueuedBuilds(store, conn);","pos":"NJJ7H64SZOX5EGACDCQAUQ7R6UEWD5IIC35A2MWFOOJV55DJYPHAC:1559"}}]}},{"Replacement":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":294,"ins":{"up_context":[{"change":4,"pos":1807}],"down_context":[{"change":4,"pos":9878}],"flag":"BLOCK","start":481,"end":542,"inode":{"change":4,"pos":4840}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":1807},"to":{"change":4,"start":1807,"end":1893},"introduced_by":4}],"inode":{"change":4,"pos":4840}},"ins_contents":[{"Add":{"text":"void State::getQueuedBuilds(std::shared_ptr store)","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:541"}}],"del_contents":[{"Del":{"text":"void State::getQueuedBuilds(std::shared_ptr store, pqxx::connection & conn)","pos":"NJJ7H64SZOX5EGACDCQAUQ7R6UEWD5IIC35A2MWFOOJV55DJYPHAC:1892"}}]}},{"Edit":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":297,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":1943}],"down_context":[{"change":4,"pos":1943}],"flag":"BLOCK","start":543,"end":573,"inode":{"change":4,"pos":4840}}},"contents":[{"Add":{"text":"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:543"}},{"Add":{"text":" auto conn(dbPool.get());","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:572"}}]}},{"Replacement":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":317,"ins":{"up_context":[{"change":4,"pos":1805}],"down_context":[{"change":4,"pos":1835}],"flag":"BLOCK","start":574,"end":605,"inode":{"change":4,"pos":4840}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":1805},"to":{"change":4,"start":1805,"end":1835},"introduced_by":4}],"inode":{"change":4,"pos":4840}},"ins_contents":[{"Add":{"text":" pqxx::work txn(*conn);","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:604"}}],"del_contents":[{"Del":{"text":" pqxx::work txn(conn);","pos":"ENXUSMSVOU3AZFMH2ZXR4ZVPV2LRRQYQJ6IFX33YN6IH2ORSNSAAC:1834"}}]}},{"Replacement":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":349,"ins":{"up_context":[{"change":4,"pos":10582}],"down_context":[{"change":4,"pos":10645}],"flag":"BLOCK","start":606,"end":641,"inode":{"change":4,"pos":4840}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":10611},"to":{"change":4,"start":10611,"end":10645},"introduced_by":4}],"inode":{"change":4,"pos":4840}},"ins_contents":[{"Add":{"text":" pqxx::work txn(*conn);","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:640"}}],"del_contents":[{"Del":{"text":" pqxx::work txn(conn);","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:10644"}}]}},{"Replacement":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":369,"ins":{"up_context":[{"change":4,"pos":11214}],"down_context":[{"change":4,"pos":11277}],"flag":"BLOCK","start":642,"end":677,"inode":{"change":4,"pos":4840}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":11243},"to":{"change":4,"start":11243,"end":11277},"introduced_by":4}],"inode":{"change":4,"pos":4840}},"ins_contents":[{"Add":{"text":" pqxx::work txn(*conn);","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:676"}}],"del_contents":[{"Del":{"text":" pqxx::work txn(conn);","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:11276"}}]}},{"Replacement":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":627,"ins":{"up_context":[{"change":4,"pos":15497}],"down_context":[{"change":4,"pos":15518}],"flag":"BLOCK","start":678,"end":707,"inode":{"change":4,"pos":4840}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":15497},"to":{"change":4,"start":15497,"end":15518},"introduced_by":4}],"inode":{"change":4,"pos":4840}},"ins_contents":[{"Add":{"text":" auto conn(dbPool.get());","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:706"}}],"del_contents":[{"Del":{"text":" Connection conn;","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:15517"}}]}},{"Replacement":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":631,"ins":{"up_context":[{"change":4,"pos":15572}],"down_context":[{"change":4,"pos":15602}],"flag":"BLOCK","start":708,"end":739,"inode":{"change":4,"pos":4840}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":15572},"to":{"change":4,"start":15572,"end":15602},"introduced_by":4}],"inode":{"change":4,"pos":4840}},"ins_contents":[{"Add":{"text":" pqxx::work txn(*conn);","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:738"}}],"del_contents":[{"Del":{"text":" pqxx::work txn(conn);","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:15601"}}]}},{"Replacement":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":677,"ins":{"up_context":[{"change":4,"pos":9007}],"down_context":[{"change":4,"pos":16152}],"flag":"BLOCK","start":740,"end":771,"inode":{"change":4,"pos":4840}},"del":{"edges":[{"previous":"","flag":"DELETED","from":{"change":4,"pos":9007},"to":{"change":4,"start":16122,"end":16152},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":16122},"to":{"change":4,"start":16122,"end":16152},"introduced_by":4}],"inode":{"change":4,"pos":4840}},"ins_contents":[{"Add":{"text":" pqxx::work txn(*conn);","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:770"}}],"del_contents":[{"Del":{"text":" pqxx::work txn(conn);","pos":"24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC:16151"}}]}},{"Replacement":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":766,"ins":{"up_context":[{"change":4,"pos":3200}],"down_context":[{"change":4,"pos":3285}],"flag":"BLOCK","start":772,"end":810,"inode":{"change":4,"pos":4840}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":3200},"to":{"change":4,"start":3200,"end":3285},"introduced_by":4}],"inode":{"change":4,"pos":4840}},"ins_contents":[{"Add":{"text":" markActiveBuildStepsAsAborted(0);","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:809"}}],"del_contents":[{"Del":{"text":" {","pos":"NJJ7H64SZOX5EGACDCQAUQ7R6UEWD5IIC35A2MWFOOJV55DJYPHAC:3205"}},{"Del":{"text":" Connection conn;","pos":"NJJ7H64SZOX5EGACDCQAUQ7R6UEWD5IIC35A2MWFOOJV55DJYPHAC:3230"}},{"Del":{"text":" markActiveBuildStepsAsAborted(conn, 0);","pos":"NJJ7H64SZOX5EGACDCQAUQ7R6UEWD5IIC35A2MWFOOJV55DJYPHAC:3278"}},{"Del":{"text":" }","pos":"NJJ7H64SZOX5EGACDCQAUQ7R6UEWD5IIC35A2MWFOOJV55DJYPHAC:3284"}}]}},{"Edit":{"inode":{"change":4,"pos":4840},"path":"src/hydra-queue-runner/hydra-queue-runner.cc","line":791,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":1272}],"down_context":[{"change":4,"pos":19072}],"flag":"BLOCK","start":811,"end":887,"inode":{"change":4,"pos":4840}}},"contents":[{"Add":{"text":"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:811"}},{"Add":{"text":" printMsg(lvlError, format(\"psql connections = %1%\") % dbPool.count());","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:886"}}]}},{"FileAdd":{"meta":{"basename":"pool.hh","metadata":0},"context":[{"change":4,"pos":187}],"contents":[{"Add":{"text":"#pragma once","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:902"}},{"Add":{"text":"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:903"}},{"Add":{"text":"#include ","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:921"}},{"Add":{"text":"#include ","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:937"}},{"Add":{"text":"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:938"}},{"Add":{"text":"#include \"sync.hh\"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:957"}},{"Add":{"text":"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:958"}},{"Add":{"text":"/* This template class implements a simple pool manager of resources","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1027"}},{"Add":{"text":" of some type R, such as database connections. It is used as","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1090"}},{"Add":{"text":" follows:","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1102"}},{"Add":{"text":"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1103"}},{"Add":{"text":" class Connection { ... };","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1134"}},{"Add":{"text":"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1135"}},{"Add":{"text":" Pool pool;","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1163"}},{"Add":{"text":"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1164"}},{"Add":{"text":" {","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1171"}},{"Add":{"text":" auto conn(pool.get());","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1201"}},{"Add":{"text":" conn->exec(\"select ...\");","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1234"}},{"Add":{"text":" }","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1241"}},{"Add":{"text":"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1242"}},{"Add":{"text":" Here, the Connection object referenced by ‘conn’ is automatically","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1315"}},{"Add":{"text":" returned to the pool when ‘conn’ goes out of scope.","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1374"}},{"Add":{"text":"*/","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1377"}},{"Add":{"text":"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1378"}},{"Add":{"text":"template ","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1397"}},{"Add":{"text":"class Pool","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1408"}},{"Add":{"text":"{","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1410"}},{"Add":{"text":"private:","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1419"}},{"Add":{"text":" struct State","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1436"}},{"Add":{"text":" {","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1442"}},{"Add":{"text":" unsigned int count = 0;","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1474"}},{"Add":{"text":" std::list> idle;","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1518"}},{"Add":{"text":" };","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1525"}},{"Add":{"text":"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1526"}},{"Add":{"text":" Sync state;","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1549"}},{"Add":{"text":"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1550"}},{"Add":{"text":"public:","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1558"}},{"Add":{"text":"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1559"}},{"Add":{"text":" class Handle","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1576"}},{"Add":{"text":" {","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1582"}},{"Add":{"text":" private:","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1595"}},{"Add":{"text":" Pool & pool;","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1616"}},{"Add":{"text":" std::shared_ptr r;","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1646"}},{"Add":{"text":"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1647"}},{"Add":{"text":" friend Pool;","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1668"}},{"Add":{"text":"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1669"}},{"Add":{"text":" Handle(Pool & pool, std::shared_ptr r) : pool(pool), r(r) { }","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1742"}},{"Add":{"text":"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1743"}},{"Add":{"text":" public:","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1755"}},{"Add":{"text":" Handle(Handle && h) : pool(h.pool), r(h.r) { h.r.reset(); }","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1823"}},{"Add":{"text":"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1824"}},{"Add":{"text":" Handle(const Handle & l) = delete;","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1867"}},{"Add":{"text":"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1868"}},{"Add":{"text":" ~Handle()","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1886"}},{"Add":{"text":" {","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1896"}},{"Add":{"text":" auto state_(pool.state.lock());","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1940"}},{"Add":{"text":" if (r) state_->idle.push_back(r);","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1986"}},{"Add":{"text":" }","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1996"}},{"Add":{"text":"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:1997"}},{"Add":{"text":" R * operator -> () { return r; }","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2038"}},{"Add":{"text":" R & operator * () { return *r; }","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2079"}},{"Add":{"text":" };","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2086"}},{"Add":{"text":"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2087"}},{"Add":{"text":" Handle get()","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2104"}},{"Add":{"text":" {","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2110"}},{"Add":{"text":" {","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2120"}},{"Add":{"text":" auto state_(state.lock());","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2159"}},{"Add":{"text":" if (!state_->idle.empty()) {","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2200"}},{"Add":{"text":" auto p = state_->idle.back();","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2246"}},{"Add":{"text":" state_->idle.pop_back();","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2287"}},{"Add":{"text":" return Handle(*this, p);","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2328"}},{"Add":{"text":" }","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2342"}},{"Add":{"text":" state_->count++;","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2371"}},{"Add":{"text":" }","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2381"}},{"Add":{"text":" /* Note: we don't hold the lock while creating a new instance,","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2452"}},{"Add":{"text":" because creation might take a long time. */","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2507"}},{"Add":{"text":" return Handle(*this, std::make_shared());","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2560"}},{"Add":{"text":" }","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2566"}},{"Add":{"text":"","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2567"}},{"Add":{"text":" unsigned int count()","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2592"}},{"Add":{"text":" {","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2598"}},{"Add":{"text":" auto state_(state.lock());","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2633"}},{"Add":{"text":" return state_->count;","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2663"}},{"Add":{"text":" }","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2669"}},{"Add":{"text":"};","pos":"YZAI5GQU3HNMK5MEGF2Y7WS445AN4YKD3HNJQVQP545ODN3F5DLAC:2672"}}]}}],"owner":"grahamc","repo":"hydra2","token":"ULn9xg1sXpHPOGrBFEPcwsNsywI83YddQW0tBtjYGyw=","login":null}

…

Dependencies

Change contents

Review