grahamc/hydra2 - Change 2AZSF326LF44FIXRMC3QU3D2TA3ZCNNAJYI23226GLMKVEGOPFUQC

getQueuedBuilds(): Don't catch errors while loading a build from the queue

Otherwise we never recover from reset daemon connections, e.g.

hydra-queue-runner[16106]: while loading build 599369: cannot start daemon worker: reading from file: Connection reset by peer hydra-queue-runner[16106]: while loading build 599236: writing to file: Broken pipe …

The error is now handled queueMonitor(), causing the next call to queueMonitorLoop() to create a new connection.

Created by Eelco Dolstra on June 26, 2015

2AZSF326LF44FIXRMC3QU3D2TA3ZCNNAJYI23226GLMKVEGOPFUQC

Dependencies

[2] TKA75HWSC2NRTRYQU6UNT7V55VPH25CQIE7H3CKI34E4ZJEDMQQAC
[3] 24BMQDZAWDQ7VNIA7TIROXSOYLOJBNZ2E4264WHWNJAEN6ZB3UOAC

In channels

main

Change contents

Replacement in src/hydra-queue-runner/hydra-queue-runner.cc at line 722 [3.4840]

B:BD[2.76] → [2.76:216]

            printMsg(lvlError, format("while loading build %1%: %2%") % build->id % e.what());
            continue; // FIXME: retry later?

[2.76]

[2.216]

            e.addPrefix(format("while loading build %1%: ") % build->id);
            throw;